Are nested classes a good way to model identifying relationships in Kotlin?
Requirements:
an issue can not be without a serno
a revocation can not be without an issue
an affirmation can not be without a revocation
Looks quite verbose:
class Have {
inner class Serno(val value: String) {
override fun toString(): String = "serno: $value"
fun nothing () = this#Have
inner class Issue(val value: String) {
override fun toString(): String = "issue: $value (${serno()})"
fun serno () = this#Serno
inner class Revocation(val value: String) {
override fun toString(): String = "revocation: $value (${issue()})"
fun issue () = this#Issue
inner class Affirmation(val value: String) {
override fun toString(): String = "affirmation: $value (${revocation()})"
fun revocation () = this#Revocation
}
}
}
}
}
val serno: Have.Serno = Have().Serno("123")
val issue: Have.Serno.Issue = serno.Issue("SUP-1")
val revocation: Have.Serno.Issue.Revocation = issue.Revocation("2020")
val affirmation: Have.Serno.Issue.Revocation.Affirmation = revocation.Affirmation("2022")
println(serno)
println(issue)
println(revocation)
println(affirmation)
println(serno == affirmation.revocation().issue().serno())
Is there a simpler way to achieve the same?
This would usually be achieved with simple non-null properties:
class Serno(val value: String) {
override fun toString(): String = "serno: $value"
}
class Issue(val value: String, val serno: Serno) {
override fun toString(): String = "issue: $value ($serno)"
}
class Revocation(val value: String, val issue: Issue) {
override fun toString(): String = "revocation: $value ($issue)"
}
class Affirmation(val value: String, val revocation: Revocation) {
override fun toString(): String = "affirmation: $value ($revocation)"
}
val serno = Serno("123")
val issue = Issue("SUP-1", serno)
val revocation = Revocation("2020", issue)
val affirmation = Affirmation("2022", revocation)
And if you're not strict on the toString format, you could even use the built-in toString of data classes, and simplify further:
data class Serno(val value: String)
data class Issue(val value: String, val serno: Serno)
data class Revocation(val value: String, val issue: Issue)
data class Affirmation(val value: String, val revocation: Revocation)
I am getting this error while getting a response from an API.
Sometimes, it works fine but 8/10 times it crashes and shows me this error
java.lang.NullPointerException: Attempt to invoke virtual method 'int java.lang.String.hashCode()' on a null object reference
at com.example.newsapi.db.Entities.Source.hashCode(Unknown Source:2)
at com.example.newsapi.db.Entities.Article.hashCode(Unknown Source:50)
This is the Article entity
#Entity(tableName = "Article_Table")
data class Article(
#PrimaryKey(autoGenerate = true)
val id: Int?=null,
val author: String,
val content: String,
val description: String,
val publishedAt: String,
val source: Source,
val title: String,
val url: String,
val urlToImage: String
): Serializable
This is the Source class declared in the Article class
data class Source(
val id: String,
val name: String
)
Here is where I'm trying to put that Article object inside a Bundle
setOnClickListener {
val bundle = Bundle().apply {
putSerializable("article", currentArticle)
}
when (from) {
"BreakingNewsFragment" -> findNavController().navigate(R.id.action_breakingNewsFragment_to_articleFragment, bundle)
"SearchNewsFragment" -> findNavController().navigate(R.id.action_searchNewsFragment_to_articleFragment, bundle)
"SavedNewsFragment" -> findNavController().navigate(R.id.action_savedNewsFragment_to_articleFragment, bundle)
}
}
Here is the API call function
#GET("v2/top-headlines")
suspend fun getBreakingNews(
#Query("country")
countryCode: String = "us",
#Query("page")
pageNumber : Int = 1,
#Query("apiKey")
apiKey: String = API_KEY
): Response<NewsResponse>
calling that function from the repository
suspend fun getBreakingNews(countryCode: String, pageNumber: Int): Response<NewsResponse> {
return RetrofitInstance.api.getBreakingNews(
countryCode = countryCode,
pageNumber = pageNumber
)
}
calling that repository function from the viewmodel
fun getBreakingNews(countryCode: String){
viewModelScope.launch(Dispatchers.IO) {
breakingNews.postValue(Resource.Loading())
val response = articleRepository.getBreakingNews(countryCode, breakingNewsPage)
breakingNews.postValue(handleBreakingNewsResponse(response))
}
}
Here is the NewsResponse Class
data class NewsResponse(
val articles: List<Article>,
val status: String,
val totalResults: Int
)
So I have a sample app that is currently using Retrofit to fetch data and display it in a recyclerview with its custom adapter. I want to pass the data to the a more details page when I click on a character name on my recyclerView. I found some tutorials and decided to use the Parcelize annotation like this:
#Parcelize data class Character (
val charID: Long,
val name: String,
val birthday: String,
val occupation: List<String>,
val img: String,
val status: String,
val nickname: String,
val appearance: List<Long>,
val portrayed: String,
val category: String,
val betterCallSaulAppearance: List<Long> ) : Parcelable
My adapter looks like this:
override fun onBindViewHolder(holder: ViewHolder, position: Int) {
val character = characters[position]
holder.characterNameText.text = character.name
holder.characterNameText.setOnClickListener {
holder.passData(character)
}
}
override fun getItemCount() = characters.size
class ViewHolder(itemView : View) : RecyclerView.ViewHolder(itemView) {
val characterNameText = itemView.findViewById<TextView>(R.id.character_name)
fun passData(character : Character) {
val intent = Intent(itemView.context, CharacterDetails::class.java)
intent.putExtra(CHARACTER, character)
itemView.context.startActivity(intent)
}
}
And in the CharacterDetails Activity it looks like this:
companion object {
const val CHARACTER = "character"
}
override fun onCreate(savedInstanceState: Bundle?) {
super.onCreate(savedInstanceState)
setContentView(R.layout.activity_character_details)
val bundle = intent.extras
val character = bundle!!.getParcelable<Character>(CHARACTER)
val characterName = findViewById<TextView>(R.id.character_details_name)
Yet I get a
java.lang.NullPointerException: Attempt to invoke interface method 'int java.util.List.size()' on a null object reference
at com.example.myapplication.models.Character.writeToParcel(Unknown Source:85)
I'm still new to this so I really need your help.Thanks!
Obviously, the error caused by the list reference of the data class is null. You can modify the code like this.
#Parcelize data class Character (
val charID: Long,
val name: String,
val birthday: String,
val occupation: List<String>?,
val img: String,
val status: String,
val nickname: String,
val appearance: List<Long>?,
val portrayed: String,
val category: String,
val betterCallSaulAppearance: List<Long>? ) : Parcelable
Is it possible to convert the following nested groupingBy to Kotlin Collections equivalent?
run this code: https://rextester.com/IYJ63609
fun main(args: Array<String>) {
data class Person(val name: String, val city: String, val phone: String)
val people = listOf(
Person("John", "Boston", "+1-888-123456"),
Person("Svyatoslav", "Saint-Petersburg", "+7-999-456700"),
Person("Svyatoslav", "Saint-Petersburg", "+7-999-456789"),
Person("Vasilisa", "Saint-Petersburg", "+7-999-123456"))
val phoneBook = people.stream().collect(
java.util.stream.Collectors.groupingBy(Person::city,
java.util.stream.Collectors.groupingBy(Person::name)
)
)
println(phoneBook)
}
The order is a bit different but yes, it is possible:
fun main(args: Array<String>) {
data class Person(val name: String, val city: String, val phone: String)
val people = listOf(
Person("John", "Boston", "+1-888-123456"),
Person("Svyatoslav", "Saint-Petersburg", "+7-999-456700"),
Person("Svyatoslav", "Saint-Petersburg", "+7-999-456789"),
Person("Vasilisa", "Saint-Petersburg", "+7-999-123456"))
val phoneBook = people.groupBy(Person::city)
.mapValues { (_, v) -> v.groupBy(Person::name) }
println(phoneBook)
}
I am using Kotlin 1.30. I have the following entity classes that will be populated from the API. And some of the properties could be null from the API so I have declared them using the safe null type.
However, I will map this entity class to my domain model class. And just wondering what is the best way to handle the null types?
I have 2 ideas on how to do this when I map the classes.
declare all the equivalent properties as safe null types
use the elivs operator to return either a empty string or a emptylist
In the following snippet I am using the elvis operator. Just wondering what is the best practice for this?
class LoginResponseDomainMapperImp : LoginResponseDomainMapper {
override fun map(entity: LoginResponseEntity): LoginResponse {
return LoginResponse(
entity.token ?: "",
mapUsers(entity.user),
mapEnterprises(entity.enterprises ?: emptyList()),
mapVendors(entity.vendors ?: emptyList()))
}
private fun mapUsers(userEntity: UserEntity?): User {
return User(
userEntity?.id,
userEntity?.email,
userEntity?.firstName,
userEntity?.lastName,
userEntity?.phone,
userEntity?.address,
userEntity?.dob,
userEntity?.customer,
userEntity?.enterpriseIds ?: emptyList(),
userEntity?.vendorIds ?: emptyList())
}
private fun mapEnterprises(enterprisesEntity: List<EnterprisesEntity>): List<Enterprises> {
val enterpriseList = mutableListOf<Enterprises>()
enterprisesEntity.forEach {
val enterprise = Enterprises(
it.id,
it.enterpriseName,
it.typeLabel,
it.country,
it.imageId,
it.managers,
it.members,
it.stripe,
it.locations)
enterpriseList.add(enterprise)
}
return enterpriseList.toList()
}
private fun mapVendors(vendorsEntity: List<VendorsEntity>): List<Vendors> {
val vendorList = mutableListOf<Vendors>()
vendorsEntity.forEach {
val vendor = Vendors(
it.id,
it.vendorName,
it.typeLabel,
it.userRole,
it.latitude,
it.longitude,
it.partner,
it.country,
it.imageId,
it.stripe)
vendorList.add(vendor)
}
return vendorList.toList()
}
}
Entity class that will populate from the API, so any of these could be null
data class LoginResponseEntity(
#SerializedName("token") val token: String?,
#SerializedName("user") val user: UserEntity?,
#SerializedName("enterprises") val enterprises: List<EnterprisesEntity>?,
#SerializedName("vendors") val vendors: List<VendorsEntity>?)
data class UserEntity(
#SerializedName("id") val id: String?,
#SerializedName("email") val email: String?,
#SerializedName("first_name") val firstName: String?,
#SerializedName("last_name") val lastName: String?,
#SerializedName("phone") val phone: String?,
#SerializedName("address") val address: String?,
#SerializedName("dob") val dob: String?,
#SerializedName("customer") val customer: String?,
#SerializedName("enterprise_ids") val enterpriseIds: List<String>?,
#SerializedName("vendor_ids") val vendorIds: List<String>?)
data class EnterprisesEntity(
#SerializedName("id") val id: String?,
#SerializedName("enterprise_name") val enterpriseName: String?,
#SerializedName("type_label") val typeLabel: String?,
#SerializedName("referral_code") val referralCode: String?,
#SerializedName("country") val country: String?,
#SerializedName("image_id") val imageId: String?,
#SerializedName("managers") val managers: List<String>?,
#SerializedName("members") val members: List<String>?,
#SerializedName("stripe") val stripe: Boolean,
#SerializedName("locations") val locations: List<String>?)
data class VendorsEntity(
#SerializedName("id") val id: String?,
#SerializedName("vendor_name") val vendorName: String?,
#SerializedName("type_label") val typeLabel: String?,
#SerializedName("user_role") val userRole: String?,
#SerializedName("latitude") val latitude: Float,
#SerializedName("longitude") val longitude: Float,
#SerializedName("partner") val partner: Boolean,
#SerializedName("country") val country: String?,
#SerializedName("image_id") val imageId: String?,
#SerializedName("stripe") val stripe: Boolean)
Data model class in the domain, Its it better to declare them all safe null types?
data class LoginResponse(
val token: String,
val user: User?,
val enterprises: List<Enterprises>,
val vendors: List<Vendors>)
data class User(
val id: String?,
val email: String?,
val firstName: String?,
val lastName: String?,
val phone: String?,
val address: String?,
val dob: String?,
val customer: String?,
val enterpriseIds: List<String>,
val vendorIds: List<String>)
data class Enterprises(
val id: String,
val enterpriseName: String,
val typeLabel: String,
val country: String,
val imageId: String,
val managers: List<String>,
val members: List<String>,
val stripe: Boolean,
val locations: List<String>)
data class Vendors(
val id: String,
val vendorName: String,
val typeLabel: String?,
val userRole: String,
val latitude: Float,
val longitude: Float,
val partner: Boolean,
val country: String?,
val imageId: String,
val stripe: Boolean)
First of all there are no safe null types in Kotlin. A variable is either nullable or not.
If the API delivers null values, either by absence or by setting them explicitely null, your data classes should reflect that in the way that those variables are nullable (question mark ? right after the data type).
The moment you map those data classes to your entities (domain model) you should handle the null case properly. Since it is a valid case, that the API serves null values, which you expect, you should handle that case by assigning a default value.
Using the elvis operator is just a way to deal with nullable types elegantely, but if you use it, remains your choice.
If you declare all the properties as nullable that's not much better than Java, even when you access them with the null safety operator. If your JSON properties have null value, that means that in your business logic they don't always have a value, and is your responsibility to handle that, by fallback to a default value (i.e. emptyList() or ""), or maybe something more complicated like redirecting to a sign in screen.