How do I Optimization sql Query and replace CURSOR - sql

Question

How would I Optimize this code removing the cursor
BEGIN TRANSACTION;
BEGIN
if exists (select AgreementNo from PFAgreements where Approved = 1 and finalized = 1 )
begin
if #Agreements <> 'ALL'
BEGIN
SELECT #CursorState = CURSOR_STATUS('global','curAgreement1')
if #CursorState = 1
--The cursor allocated to this variable is open.
--For insensitive and keyset cursors, the result set has at least one row.
--For dynamic cursors, the result set can have zero, one, or more rows
begin
CLOSE curAgreement1
DEALLOCATE curAgreement1
end
else if #CursorState = 0
--The cursor allocated to this variable is open, but the result set is definitely empty.*
begin
CLOSE curAgreement1
DEALLOCATE curAgreement1
end
else if #CursorState = -1
--The cursor allocated to this variable is closed.
begin
DEALLOCATE curAgreement1
end
declare curAgreement1 cursor for
(Select AgreementNo from PFAgreements where Approved = 1 and finalized = 1 AND AgreementNo = #Agreements)
END
ELSE
BEGIN
declare curAgreement1 cursor for
(Select AgreementNo from PFAgreements where Approved = 1 and finalized = 1)
END
open curAgreement1
Fetch next from curAgreement1 into #AgreementAno
while (##fetch_status = 0)
begin
SELECT
#Cno = ISNULL(BaseNo, ''),
#StartDate = CommencementDate,
#MaturityDate = MaturityDate,
#FirstInstalDate = FirstInstallmentDate,
#Tranch = ISNULL(Tranche, 0),
#MyCurrency = ISNULL(Currency, ''),
#Term = ISNULL(NoOfRepayments, 0),
#ApprovedAmount = ISNULL(LoanAppliedAmount , 0),
--#ApprovedAmount = ISNULL(LoanAppliedAmount - deposit , 0),
#IntRate = ISNULL(IntRate, 0),
#Registered = 0,
#RegisteredCollateral = '',
#DisbursementDate = ActivationDate,
#ProdCode = Product,
#CurOfRepayment = CurrencyRepayment
FROM dbo.PFAgreements
WHERE AgreementNo = #AgreementAno
--call saveupdate transitems
--ensures there is no accrual that hasent been paid up in transbill
exec uspsaveupdatetransitems #AgreementAno , #LogIP , #LogUser , #Compname
select #myrate = (select top 1 EXCHRATE from EXCHRATES where Company = #Company and CURRENCYDATE <= #ProcDate and CURRENCYCODE =#MyCurrency order by CURRENCYDATE desc)
select ISNULL(#MyRate , 1)
set #Rental = 0
set #rental = (Select top 1 rental from schedules where AgreementNo = #AgreementAno ORDER BY ID desc)
set #rental = isnull(#rental,0)
If exists(select DateDue from Schedules where agreementno = #AgreementAno)
begin
Set #maturityDate = (Select Max(DateDue) From schedules where AgreementNo = #AgreementAno)
end
set #Names =( Select dbo.GetCustomerNamePF (#AgreementAno))
--deallocate rowcount
set #rowcount =0
set #rowcount = (Select count(AgreementNo) from PFAgreements Where AgreementNo=#AgreementAno and Finalized = 1 and Approved = 1 )
if #rowcount>0
begin
declare #TxRow int
set #TxRow =#rowcount - 1
Declare #TotalInt as numeric(18,2)
select #TotalInt = isnull((Select case when Sum(AmountDue) is null then 0 else Sum(AmountDue) end Amount from Schedules where AgreementNo = #AgreementAno and ItemCode = '11' and Processed = 0 ),0)
--Tom 2017-04-18: Check if there is Written Off or Terminated Interest
select #TerminatedInt = isnull((select UFCBal from IPFTerminatedAgreements where AgreementNo = #AgreementAno ),0)
select #WritenOffInt = isnull((select isnull(sum((AmountDue-AmountPaid)),0) from WriteOffDetails where ContractNo = #AgreementAno and REJECTED=0),0)
--Therefore the Interest Balance
select #TotalInt = #TotalInt - #TerminatedInt - #WritenOffInt
--End of Tom
if #TotalInt < 0
begin
select #TotalInt = 0
end
select #LastCreditDate = ISNULL(dbo.LastCreditDate(#AgreementAno),'1900-01-01'), #NoOFArr = dbo.NoOfArrsModif(#AgreementAno,#ProcDate) ,
#NoOfArrReal = dbo.NoOfArrs(#AgreementAno,#ProcDate) , #nextduedate = isnull(dbo.FirstAccrualDate(#AgreementAno),dbo.FirstAccrualDatePaid(#AgreementAno)) ,
#PrincipalBal = dbo.GetPrinBalBFPF(#AgreementAno,#ProcDate) ,#PrincipalBalBccy = #PrincipalBal * #MyRate ,
--#InterestBal =#TotalInt + ( Select case when Sum(AmountDue) is null then 0 else Sum(AmountDue) end Amount from Trans_Bill where AgreementNo = #AgreementAno and ItemCode = '11' and ReAccrual = 0 ),
#InterestBal =#TotalInt ,
--kenwillis 12042016
--commented line shows initial interest. above new shows interest to maturity un processesd
#InterestBalBccy = ( #InterestBal * #MyRate ) ,
#TrustBal = (Select case when Sum(AmountFcy) IS null then 0 else Sum(AmountFcy) end Amount from ReceiptOverPayments where AgreementNo = #AgreementAno ) ,
#TrustBalBccy = (#TrustBal * #myrate) ,
#OtherBal = (select case when Sum(Amountdue - AmountPaid) IS null then 0 else Sum(Amountdue - AmountPaid) end Amount from Trans_Bill where AgreementNo = #AgreementAno
and DateDue < = #procdate and ItemCode in(Select chargesCode from charges) and AmountDue > 0 ) ,
#OtherBalBccy = #OtherBal * #myrate ,
#PrincipalArrears = dbo.GetPrinArrBF(#AgreementAno , #ProcDate ) , #PrincipalArrearsBccy = #PrincipalArrears * #MyRate ,
#InterestArrears = (Select case when Sum(AmountDue-AmountPaid) is null then 0 else Sum(AmountDue-AmountPaid) end Amount from Trans_Bill where AgreementNo = #AgreementAno and DateDue < = #ProcDate
and ItemCode = '11' and Item not like '%default%' and (ReAccrual = 0 or ReAccrual = 1) ) ,
#InterestArrearsBccy = ( #InterestArrears * #MyRate ) ,
#OtherArrears = (Select case when Sum(AmountDue-AmountPaid) is null then 0 else Sum(AmountDue-AmountPaid) end Amount from Trans_Bill where AgreementNo = #AgreementAno and DateDue < = #procdate and ItemCode NOT in('10','11','19') and AmountDue > 0 ),
#OtherArrearsBccy = #OtherArrears * #myrate ,
#ArrearsInterest = ( Select case when Sum(AmountDue-AmountPaid) is null then 0 else Sum(AmountDue-AmountPaid) end Amount from Trans_Bill where AgreementNo = #AgreementAno and DateDue < = #procdate and ItemCode = '11' and
Item like '%Default%' ) ,
#ArrearsInterestBccy = #ArrearsInterest * #MyRate ,
#PrinArrearsNotdue = 0 , #PrinArrearsNotdueBccy = 0 , #MoOut = 0,
#DaysInArr = dbo.NoOfArrs(#AgreementAno,#ProcDate),
#chargesSp = (Select case when Sum(AmountDue-AmountPaid) is null then 0 else Sum(AmountDue-AmountPaid) end Amount from Trans_Bill where AgreementNo = #AgreementAno and DateDue < = #procdate and ItemCode in(Select chargesCode from charges where affectsincome = 0) and AmountDue > 0 )
select #nextduedate = isnull(#nextduedate,(select TOP 1 datedue from schedules where agreementno = #AgreementAno and processed = 0 ))
select #BaldateRep = #nextduedate
if #InterestArrears < 0
begin
select #InterestArrears = 0
select #InterestArrearsBccy = #InterestArrears * #MyRate
end
end
else
begin
-- select #PrincipalBal = #ApprovedAmount, #PrincipalBalBccy = #ApprovedAmount , #InterestBal = 0 ,
-- #TrustBal = 0 , #TrustBalBccy = 0 , #OtherBal = 0 , #OtherBalBccy = 0 , #PrincipalArrears = 0 ,
-- #PrincipalArrearsBccy = 0 , #InterestArrears = 0 , #InterestArrearsBccy = 0 , #OtherArrears = 0 ,
-- #OtherArrearsBccy = 0 , #ArrearsInterest = 0 , #ArrearsInterestBccy = 0 , #MoOut = 0 ,
-- #PrinArrearsNotdue = 0 , #PrinArrearsNotdueBccy = 0 , #LastCreditDate = '1900-01-01' , #NoOFArr = 0 ,
-- #NoOfArrReal = 0 , #BaldateRep = '1900-01-01' , #DaysInArr = 0
-- end
-- INSERT INTO LhTransBalancePF
-- (
-- BalDate, Currency, ExchangeRate, BaseNo, AgreementNo, Names, PostDate, Tranche , StartDate ,
-- FirstInstaldate , MaturityDate, Term, ApprovedAmount , PaymentFrequency , Rental ,
-- LastPaymentDate , NoOfArrears, ProdCode, ProdName , DaysInArrears, PrincipalBal ,
-- PrincipalBalBccy , InterestBal, InterestBalBccy , TrustBal , TrustBalBccy, OtherBal, OtherBalBccy ,
-- PrincipalArrears , PrincipalArrearsBccy , InterestArrears , InterestArrearsBccy , OtherArrears ,
-- OtherArrearsBccy, ArrearsInterest, ArrearsInterestBccy, MoOutstanding, PostingUser,LastAccrualdate ,
-- IntRate,PricipalArrearsNotDue,PrincipalArrNotDueBccy,NoOfArrearsReal
-- )
-- VALUES
-- (
-- ISNULL(#BalDate,'1900-01-01') ,ISNULL(#MyCurrency,'') ,ISNULL(#MyRate,1) ,ISNULL(#Cno,'') , ISNULL(#AgreementAno,'') ,ISNULL(#Names,'') , ISNULL(#Baldate,'1900-01-01') , ISNULL(#Tranch,0) , ISNULL(#StartDate,'1900-01-01') ,
-- ISNULL(#FirstInstaldate,'1900-01-01') , ISNULL(#MaturityDate,'1900-01-01') , ISNULL(#Term,0) , ISNULL(#ApprovedAmount,0) ,3 ,iif(#Rental=null,0,#Rental) ,
-- #LastCreditDate , ISNULL(#NoOFArr,0) , '' , '' , ISNULL(#DaysInArr,0) , ISNULL(#PrincipalBal,0) ,
-- ISNULL(#PrincipalBalBccy,0) , ISNULL(#InterestBal,0) , ISNULL(#InterestBalBccy,0) , ISNULL(#TrustBal,0) ,ISNULL(#TrustBalBccy,0) ,ISNULL(#OtherBal,0), ISNULL(#OtherBalBccy,0) ,
-- ISNULL(#PrincipalArrears,0) , ISNULL(#PrincipalArrearsBccy,0) , ISNULL(#InterestArrears,0) , ISNULL(#InterestArrearsBccy,0) , ISNULL(#OtherArrears,0) ,
-- ISNULL(#OtherArrearsBccy,0) , ISNULL(#ArrearsInterest,0) , ISNULL(#ArrearsInterestBccy,0) , ISNULL(#MoOut,0) , 'SYSTEM',ISNULL(#BaldateRep,'1900-01-01') ,
-- ISNULL(#intRate,0),ISNULL(#PrinArrearsNotdue,0) ,ISNULL(#PrinArrearsNotdueBccy,0) ,ISNULL( #NoOfArrReal ,0)
-- )
--update LHTransBalancePF set Registered = #Registered, RegisteredCollateral = #RegisteredCollateral,
--ProdCode = #ProdCode ,loansizecategory = case when ApprovedAmount < = 5000000 then 'SMALL'
--WHEN ApprovedAmount > 5000000 and ApprovedAmount < = 30000000 then 'MEDIUM'
--ELSE 'LARGE' END
--WHERE AgreementNo = #AgreementAno AND LhTransBalancePF.Baldate = #Baldate
--UPDATE LhTransBalancePF SET ProdName = Product.ProductName FROM LhTransBalancePF INNER JOIN Product
--ON LhTransBalancePF.ProdCode = Product.ProductCode
--WHERE AgreementNo = #AgreementAno AND BalDate = #Baldate
select #PrincipalBal = #ApprovedAmount, #PrincipalBalBccy = #ApprovedAmount , #InterestBal = 0 ,
#TrustBal = 0 , #TrustBalBccy = 0 , #OtherBal = 0 , #OtherBalBccy = 0 , #PrincipalArrears = 0 ,
#PrincipalArrearsBccy = 0 , #InterestArrears = 0 , #InterestArrearsBccy = 0 , #OtherArrears = 0 ,
#OtherArrearsBccy = 0 , #ArrearsInterest = 0 , #ArrearsInterestBccy = 0 , #MoOut = 0 ,
#PrinArrearsNotdue = 0 , #PrinArrearsNotdueBccy = 0 , #LastCreditDate = '1900-01-01' , #NoOFArr = 0 ,
#NoOfArrReal = 0 , #BaldateRep = '1900-01-01' , #DaysInArr = 0,#chargesSp =0
end
INSERT INTO LhTransBalance
(
BalDate, Currency, ExchangeRate, BaseNo, AgreementNo, Names, PostDate, Tranche , StartDate ,
FirstInstaldate , MaturityDate, Term, ApprovedAmount , PaymentFrequency , Rental ,
LastPaymentDate , NoOfArrears, ProdCode, ProdName , DaysInArrears, PrincipalBal ,
PrincipalBalBccy , InterestBal, InterestBalBccy , TrustBal , TrustBalBccy, OtherBal, OtherBalBccy ,
PrincipalArrears , PrincipalArrearsBccy , InterestArrears , InterestArrearsBccy , OtherArrears ,
OtherArrearsBccy, ArrearsInterest, ArrearsInterestBccy, MoOutstanding, PostingUser,LastAccrualdate ,
IntRate,PricipalArrearsNotDue,PrincipalArrNotDueBccy,NoOfArrearsReal, ChargesArrearsSp
)
VALUES
(
ISNULL(#BalDate,'1900-01-01') ,ISNULL(#MyCurrency,'') ,ISNULL(#MyRate,1) ,ISNULL(#Cno,'') , ISNULL(#AgreementAno,'') ,ISNULL(#Names,'') , ISNULL(#Baldate,'1900-01-01') , ISNULL(#Tranch,0) , ISNULL(#StartDate,'1900-01-01') ,
ISNULL(#FirstInstaldate,'1900-01-01') , ISNULL(#MaturityDate,'1900-01-01') , ISNULL(#Term,0) , ISNULL(#ApprovedAmount,0) ,3 ,iif(#Rental=null,0,#Rental) ,
#LastCreditDate , ISNULL(#NoOFArr,0) , '' , '' , ISNULL(#DaysInArr,0) , ISNULL(#PrincipalBal,0) ,
ISNULL(#PrincipalBalBccy,0) , ISNULL(#InterestBal,0) , ISNULL(#InterestBalBccy,0) , ISNULL(#TrustBal,0) ,ISNULL(#TrustBalBccy,0) ,ISNULL(#OtherBal,0), ISNULL(#OtherBalBccy,0) ,
ISNULL(#PrincipalArrears,0) , ISNULL(#PrincipalArrearsBccy,0) , ISNULL(#InterestArrears,0) , ISNULL(#InterestArrearsBccy,0) , ISNULL(#OtherArrears,0) ,
ISNULL(#OtherArrearsBccy,0) , ISNULL(#ArrearsInterest,0) , ISNULL(#ArrearsInterestBccy,0) , ISNULL(#MoOut,0) , 'SYSTEM',ISNULL(#BaldateRep,'1900-01-01') ,
ISNULL(#intRate,0),ISNULL(#PrinArrearsNotdue,0) ,ISNULL(#PrinArrearsNotdueBccy,0) ,ISNULL( #NoOfArrReal ,0) ,ISNULL( #chargesSp ,0)
)
update LHTransBalance set Registered = #Registered, RegisteredCollateral = #RegisteredCollateral,
ProdCode = #ProdCode ,loansizecategory = case when ApprovedAmount < = 5000000 then 'SMALL'
WHEN ApprovedAmount > 5000000 and ApprovedAmount < = 30000000 then 'MEDIUM'
ELSE 'LARGE' END
WHERE AgreementNo = #AgreementAno AND LhTransBalance.Baldate = #Baldate
--NO' 2017-09-19
update LhTransBalance set OldAno= pfagreements.oldagreementno, residualvalue = pfagreements.residualValue
from pfagreements inner join lhtransbalance on pfagreements.agreementno= LhTransBalance.agreementno
WHERE lhtransbalance.AgreementNo = #AgreementAno AND LhTransBalance.Baldate = #Baldate
--End
UPDATE LhTransBalance SET ProdName = Product.ProductName FROM LhTransBalance INNER JOIN Product
ON LhTransBalance.ProdCode = Product.ProductCode
WHERE AgreementNo = #AgreementAno AND BalDate = #Baldate
Fetch next from curAgreement1 into #AgreementAno
end
close curAgreement1
deallocate curAgreement1
Thank you for your help