Required message is displayed even if the field is provided C# - asp.net-core

Using ASP.Net Core, I am developing a simple form to reset the password using email address.
My model is as follow:
public class EmailViewModel
{
[Required(ErrorMessageResourceName = "Model_RequireEmail", ErrorMessageResourceType = typeof(Resources.Identity))]
[Display(Name = "Models_Account_Email", ResourceType = typeof(Resources.Identity))]
[DataType(DataType.EmailAddress)]
[EmailAddress(ErrorMessage = "Models.EmailFormat")]
[MaxLength(100, ErrorMessage = "Models.MaxLength")]
public string? Email { get; set; }
}
And my view:
<form method="post">
<div class="uk-text-danger">
#Html.ValidationSummary()
</div>
<div class="uk-margin">
<div class="uk-inline">
<span class="uk-form-icon" uk-icon="icon: mail"></span>
#Html.TextBoxFor(m => m.Data.EmailViewModel.Email, new
{
#class = "validate uk-input",
placeholder = Html.DisplayNameFor(m => m.Data.EmailViewModel.Email)
})
#Html.HiddenFor(m => m.Data.ResetPasswordAction)
#Html.HiddenFor(m => m.Data.ResetPasswordController)
</div>
</div>
<button class="uk-button uk-button-default">#Html.LocalizedIdentity("Views.Account.PassReset")</button>
</form>
My issue is that even if I provide a correct email address, I keep getting the message of the "required" data annotation. What did I miss?
EDIT 13/12/2021
The issue occurs when I used a nested ViewModel. For example, the viewModel associated with my form is
public class ForgotPasswordViewModel
{
public EmailViewModel EmailViewModel => new EmailViewModel();
[HiddenInput]
public string? ResetPasswordAction { get; set; }
[HiddenInput]
public string? ResetPasswordController { get; set; }
}
using the EmailViewModel above. This give a ModelState.IsValid= false because the email is null even if provided.
If I bypass the EmailViewModel and use for my ForgotPasswordViewMode, the following:
public class ForgotPasswordViewModel
{
[Display(Name = "Models_Account_Email", ResourceType = typeof(Resources.Identity))]
[Required]
[DataType(DataType.EmailAddress)]
[EmailAddress(ErrorMessage = "Models.EmailFormat")]
[MaxLength(100, ErrorMessage = "Models.MaxLength")]
public string? Email { get; set; }
[HiddenInput]
public string? ResetPasswordAction { get; set; }
[HiddenInput]
public string? ResetPasswordController { get; set; }
}
It works nicely.
The problem is that I want to use the nested ViewModel to avoid repeating it.
Why doesn't it work with the nested EmailViewModel?

This is my model and my test view, it will lead to ModelState.IsValid == false because the input form should have a property of emailVM.Email but not EmailViewModel.
public class EmailViewModel
{
//[Required(ErrorMessageResourceName = "Model_RequireEmail", ErrorMessageResourceType = typeof(Resources.Identity))]
//[Display(Name = "Models_Account_Email", ResourceType = typeof(Resources.Identity))]
[Display(Name = "Models_Account_Email")]
[Required]
[DataType(DataType.EmailAddress)]
[EmailAddress(ErrorMessage = "Models.EmailFormat")]
[MaxLength(100, ErrorMessage = "Models.MaxLength")]
public string? Email { get; set; }
}
public class ForgotPasswordViewModel
{
//public EmailViewModel emailVM => new EmailViewModel();
public EmailViewModel emailVM { get; set; }
[HiddenInput]
public string? ResetPasswordAction { get; set; }
[HiddenInput]
public string? ResetPasswordController { get; set; }
}
<form method="POST" asp-action="Edit">
<div class="uk-text-danger">
#Html.ValidationSummary()
</div>
<div class="uk-inline">
<span class="uk-form-icon" uk-icon="icon: mail"></span>
#Html.TextBoxFor(m => m.emailVM.Email, new
{
placeholder = Html.DisplayNameFor(m => m.emailVM.Email)
})
</div>
<div class="form-group">
<input type="submit" value="Save" class="btn btn-primary" />
</div>
</form>

Related

Model Binding Error for Parent Object Entity

Using latest ASP.NET Core, Windows 10 Pro
TLDR: my controller is returning a "Microsoft.AspNetCore.Mvc.ModelBinding.ModelError" for an entity's parent.
Entity: Schedule
public class Schedule
{
[Key]
[DatabaseGenerated(DatabaseGeneratedOption.Identity)]
public int ScheduleId { get; set; }
[Required]
[Display(Name = "Start On")]
public DateTime StartDateTime { get; set; } = DateTime.Now.AddMinutes(1);
[Display(Name = "Reschedule On")]
public string Recurrence { get; set; }
[Display(Name = "Parameter 1")]
[MaxLength(256), StringLength(256)]
public string Param1 { get; set; }
// ... more properties
[Display(Name = "Parameter 7")]
[MaxLength(256), StringLength(256)]
public string Param7 { get; set; }
[Display(Name = "Message Text")]
public string MessageText { get; set; }
#region relationships
[Required]
[Display(Name = "For Process")]
public int ProcessId { get; set; }
[Required]
[Display(Name = "For Process")]
public virtual Process Process { get; set; }
public virtual ICollection<ScheduleNotification> ScheduleNotifications { get; set; }
#endregion
}
Entity: Process
public class Process : IValidatableObject
{
private int? _ApplicationId;
[DatabaseGenerated(DatabaseGeneratedOption.Identity)]
[Key]
public int ProcessId { get; set; }
[Required]
[StringLength(80, MinimumLength = 5, ErrorMessage = "Names must be between 5 and 80 characters")]
[MaxLength(80)]
public string Name { get; set; }
public string Description { get; set; }
[Required]
[Display(Name = "Process Type")]
public ProcessTypeEnum ProcessType { get; set; }
// ... more properties
[Display(Name = "Primary Application")]
public int? ApplicationId
{
get
{
return _ApplicationId;
}
set
{
_ApplicationId = value == 0 ? null : value;
}
}
public Application Application { get; set; }
public ICollection<Schedule> Schedules { get; set; }
}
Controller Action on Create Get
public IActionResult Create(int? processId)
{
// no value provided, so redirect to view that prompts for process
if (!processId.HasValue || processId == 0)
{
TempData["Error"] = "You must select a process to schedule";
return RedirectToAction("Processes");
}
var schedule = new Schedule()
{
ProcessId = processId.GetValueOrDefault(),
Process = _context.Processes.Find(processId.GetValueOrDefault()),
ScheduleNotifications = new List<ScheduleNotification>()
};
return View(schedule);
}
Razor view called on create
#model HangfireServer.Models.Schedule
#{
ViewData["Title"] = "Create";
}
<h1>Schedule</h1>
<hr />
<div class="row">
<div class="col">
<form asp-action="Create">
<div asp-validation-summary="ModelOnly" class="text-danger"></div>
<div class="text-danger" style="direction:rtl" asp-validation-summary="All"></div>
#Html.HiddenFor(m => m.ProcessId)
#Html.HiddenFor(m => m.Process)
<div class="form-group row">
<text class="control-label col-sm-2">#Html.DisplayNameFor(m => m.Process.Name)</text>
<div class="col-sm-4">
#Html.DisplayFor(m => m.Process.Name)
</div>
<text class="text-left col-sm-6 text-secondary">Process to schedule</text>
</div>
<div class="form-group row">
<label asp-for="StartDateTime" class="control-label col-sm-2"></label>
<div class="col-sm-4">
<input asp-for="StartDateTime" class="control-label" />
<span asp-validation-for="StartDateTime" class="text-danger"></span>
</div>
<text class="text-left col-sm-6 text-secondary">Date and time to initiate process</text>
</div>
<!-- more stuff -->>
<div class="form-group">
<input type="submit" value="Create" class="btn btn-primary" />
</div>
</form>
</div>
</div>
Create post controller
// POST: Schedules/Create
[HttpPost]
[ValidateAntiForgeryToken]
public async Task<IActionResult> Create([Bind("ScheduleId,StartDateTime,Recurrence,Param1,Param2,Param3,Param4,Param5,Param6,Param7,ProcessId,Process,ScheduleNotifications")] Schedule schedule)
{
if (ModelState.IsValid)
{
// save the new schedule
schedule.Process = await _context.Processes.FindAsync(schedule.ProcessId);
_context.Add(schedule);
await _context.SaveChangesAsync();
// queue the new schedule
EnqueueProcess(schedule);
TempData["Success"] = $"Process {schedule.Process.Name} has been scheduled";
return RedirectToAction(nameof(Index));
}
// display additional errors not caught in page validation
string errorMessage = "";
foreach (var modelState in ViewData.ModelState.Values)
{
foreach (var error in modelState.Errors)
{
errorMessage = String.IsNullOrEmpty(errorMessage) ? error.ToString() : "<br>" + error.ToString();
}
}
TempData["Error"] = errorMessage;
// return to current view
return RedirectToAction("Create", new { processId = schedule.ProcessId });
}
On trace, the GET is passing to the view schedule with its parent process id and process object populated. On POST
ModelState.IsValid = False
schedule.processId = 2 (or whatever the value sent from GET was
schedule.process is null (even though there's a hidden field for process in vie)
ModelState only has 1 invalid key
SubKey={Process}, Key="Process", ValidationState=Invalid
I think I figured it out - but this is just a hack, there's probably a correct way to do it
// populate process property with an instance of a process object
schedule.Process = await _context.Processes.Include(p => p.Application).FirstOrDefaultAsync(p => p.ProcessId == schedule.ProcessId);
ModelState.Clear();
Then either
ModelState.Remove("Process");
Or
TryValidateModel(schedule);
Regardless ModelState.IsValid is now true

MVC4 Compare attribute and nested object properties

Getting a model error when using MVC4 Compare attribute against a nested property.
Error is as follows Could not find a property named PASSWORD.
What is the correct way to use Compare for Nested Property comparison?
User.cs
public partial class User
{
public User()
{
this.Mobilizations = new HashSet<Mobilization>();
}
[Required(ErrorMessage="Password is required")]
[DataType(DataType.Password)]
public string PASSWORD { get; set; }
}
UserViewModel.cs
using System;
using System.Collections.Generic;
using System.Linq;
using System.Web;
using System.ComponentModel.DataAnnotations;
using System.Web.Mvc;
using CompareAttribute = System.Web.Mvc.CompareAttribute;
public class userViewModel
{
public User User { get; set; }
[DataType(DataType.Password)]
[Required(ErrorMessage = "CONFIRM PASSWORD is required")]
[Display(Name="CONFIRM PASSWORD")]
[CompareAttribute("PASSWORD",ErrorMessage="Password didnot match")]
public string ComparePassword { get; set; }
public IEnumerable<Designation> DesignationList { get; set; }
public SelectList MenuList { get; set; }
[Required(ErrorMessage="Select some menu items")]
public string[] MenuIds { get; set; }
}
Controller
[HttpPost]
public ActionResult Create(userViewModel model)
{
if (ModelState.IsValid) //<= **Getting Model error here**
{
_db.Entry(model.User).State = EntityState.Modified;
_db.SaveChanges();
}
return RedirectToAction("Create");
}
The View is as follows
<div class="form-group">
#Html.LabelFor(model => model.User.PASSWORD, new { #class = "col-sm-2 control-label " })
<div class="col-sm-6 ">
#Html.EditorFor(model => model.User.PASSWORD, new { #class = "form-control" })
#Html.ValidationMessageFor(model => model.User.PASSWORD)
</div>
</div>
<div class="form-group">
#Html.LabelFor(model => model.ComparePassword, new { #class = "col-sm-2 control-label " })
<div class="col-sm-6 ">
#Html.EditorFor(model => model.ComparePassword, new { #class = "form-control" })
#Html.ValidationMessageFor(model => model.ComparePassword)
</div>
</div>
How can i solve this issue?
Try like this:
[CompareAttribute("User.Password", ErrorMessage="Password didnot match")]
public string ComparePassword { get; set; }
Or, remove the User property from your ViewModel and add
public string Password {get; set;}
[CompareAttribute("Password", ErrorMessage="Password didnot match")]
public string CinfirmPassword {get; set;}
Later you can populate your User object.
And here you can find a workaround.

Model evaluating to false while saving to database

So I have this problem when trying to save an item to the database in my asp.net mvc4 web app.
I have three classes listed below
public class Posts
{
[Key]
public int PostID { get; set; }
[Required(ErrorMessage="A Title is required for your Post")]
[Display(Name="Title")]
public string PostTitle { get; set; }
[Required(ErrorMessage="This Field is Required")]
[Display(Name = "Post")]
public string PostContent { get; set; }
[Required()]
[DataType(DataType.DateTime)]
public DateTime PostDate { get; set; }
//public int AuthorID { get; set; }
//public int CommentID { get; set; }
[NotMapped]
public virtual List<Comments> Comment { get; set; }
public virtual Users user { get; set; }
}
and this class has a many to one relationship with the users class below
public class Users
{
public Users()
{
}
[Key]
public int UserID { get; set; }
[Required()]
public string Firstname { get; set; }
[Required()]
public string Lastname { get; set; }
[Required()]
[DataType(DataType.Date, ErrorMessage="Enter a Valid Date")]
public DateTime DOB { get; set; }
//[Required()]
//public string Photo { get; set; }
[Required()]
public string Sex { get; set; }
[Required()]
[DataType(DataType.EmailAddress)]
public string Email { get; set; }
public DateTime RegDate { get; set; }
[Required()]
[Column("Username")]
//[Remote("doesUserNameExist", "Account", HttpMethod = "POST", ErrorMessage = "User name has already been taken. Please enter a different User name.")]
public string Username { get; set; }
[Required()]
[DataType(DataType.Password)]
public string Password { get; set; }
public string PasswordSalt { get; set; }
[System.ComponentModel.DataAnnotations.Compare("Password", ErrorMessage="Passwords do not match")]
[DataType(DataType.Password)]
//[NotMapped]
//public string ConfirmPassword { get; set; }
public virtual List<Posts> Post { get; set; }
public virtual List<Comments> Comment { get; set; }
}
The database table for the Posts.cs class has a field called user_UserID which i assume is to store the id of the user that creates a post. I'm trying to save the posts to the database using the below code
#using (Html.BeginForm()) {
#Html.AntiForgeryToken()
#Html.ValidationSummary(true)
<fieldset>
<legend>Posts</legend>
<div class="form-group">
#Html.LabelFor(model => model.PostTitle)
#Html.TextBoxFor(model => model.PostTitle, new {#class = "form-control"})
#Html.ValidationMessageFor(model => model.PostTitle)
</div>
<div class="form-group">
#Html.LabelFor(model => model.PostContent)
#Html.TextAreaFor(model => model.PostContent, new {#class = "form-control"})
#Html.ValidationMessageFor(model => model.PostContent)
</div>
<input type="hidden" name="user.UserID" value="#Session["LoggedUserID"]" />
<div>
<input type="submit" value="Submit" />
</div>
</fieldset>
}
As you can see, the user ID i'm saving to the database table is gotten from the user ID stored in the Session["LoggedUserID"] variable. The controller that handles the saving is below
public class PostsController : Controller
{
//
// GET: /Posts/
BlogContext db = new BlogContext();
public ActionResult Index()
{
return View();
}
[HttpGet]
public ActionResult Create()
{
return View();
}
[HttpPost]
public ActionResult Create(Posts Post)
{
var errors = ModelState.Values.SelectMany(v => v.Errors);
try
{
if (ModelState.IsValid)
{
var newPost = db.Post.Create();
newPost.PostTitle = Post.PostTitle;
newPost.PostContent = Post.PostContent;
newPost.PostDate = DateTime.Now;
newPost.user.UserID = Post.user.UserID;
db.Post.Add(newPost);
db.SaveChanges();
return RedirectToAction("Index", "Posts");
}
else
{
ModelState.AddModelError("", "Something is wrong with the model");
}
}
catch (NullReferenceException ex)
{
Debug.WriteLine("Processor Usage" + ex.Message);
}
return View();
}
}
I attached a breakpoint to the Modelstate.IsValid line and then debugged, but i noticed the ModelState is always evaluating to false and the ModelState.AddModelError is showing that is there is something wrong with validating the model. Ive tried all possible tweakings all to no avail. I need help. How can i save the Posts to the database table without this problem.
Please what am i doing wrong?
I suspect ModelState is invalid because you are posting a value for user.UserId (the hidden input) which is initializing the property User which is invalid because of the validation attributes applied to other properties of User. It would be better to create a view model for creating new Posts that contain only the properties you need to display/edit. It is not necessary to include a property for User (the author of the post) since this can be set in the controller when you save the data (similar to what you are doing for the PostDate property
View model
public class PostVM
{
[Required(ErrorMessage="A Title is required for your Post")]
[Display(Name="Title")]
public string Title { get; set; }
[Required(ErrorMessage="This Field is Required")]
[Display(Name = "Post")]
public string Content { get; set; }
}
Controller
[HttpGet]
public ActionResult Create()
{
PostVM model = new PostVM();
return View(model);
}
[HttpPost]
public ActionResult Create(PostVM model)
{
if(!ModelState.IsValid)
{
return View(model);
}
// Initialize new Posts
// Map properties from the view model, set the user and date
// Save and redirect
}
View
#model PostVM
#using (Html.BeginForm()) {
....
<div class="form-group">
#Html.LabelFor(model => model.Title)
#Html.TextBoxFor(model => model.Title, new {#class = "form-control"})
#Html.ValidationMessageFor(model => model.Title)
</div>
<div class="form-group">
#Html.LabelFor(model => model.Content)
#Html.TextAreaFor(model => model.Content, new {#class = "form-control"})
#Html.ValidationMessageFor(model => model.Content)
</div>
<input type="submit" value="Submit" />
}

What is the name convention of binding a complex ViewModels?

I have these two ViewModels
public class AboutViewModel : ViewModel
{
public override long Id { get; set; }
public override string PageTitle { get; set; }
public override string TitleDescription { get; set; }
public override string ContentTitle { get; set; }
public virtual AboutItemViewModel AboutItem { get; set; }
}
public class AboutItemViewModel
{
public long Id { get; set; }
[AllowHtml]
public string Content { get; set; }
public string ImageUrl { get; set; }
public HttpPostedFileBase FileToUpload { get; set; }
}
Here is my controller:
[ValidateInput(false)]
[ValidateAntiForgeryToken, HttpPost]
public ActionResult Create(long? siteid, long? cid, AboutViewModel model)
{
return View(model);
}
Here is my View:
#using (Html.BeginForm("Create", "About", new { siteid = ViewData["siteid"], cid = ViewData["cid"] },FormMethod.Post,new { enctype = "multipart/form-data", #class = "form-horizontal rtl", autocomplete = "off" }))
{
<div class="controls">
<input type="file" name="FileToUpload" id="FileToUpload" style="margin-right: -9px;">
</div>
<div class="controls">
#Html.ValidationMessageFor(o => o.AboutItem.FileToUpload, "", new { id = "spanfile", #class = "alert alert-block alert-error span3 pull-right", style = "margin-right: 160px;" })
</div>
<div class="control-group pull-left">
<button type="submit" class="btn btn-large" data-toggle="button">Save</button>
</div>
}
How to bind the file to FileToUpload to stop returning me a null?
Except:
If I put it in the main AboutViewModel than it's returns a correct value.
Since the FileToUpload property is in the AboutItem proprety, which is a class property of the parent ViewModel, you need to preface the name of your input element with the property it came from. That's a long way of saying that the name of your file input should be AboutItem.FileToUpload.
<input type="file" name="AboutItem.FileToUpload" id="AboutItem_FileToUpload" />
This should take care of the model binding for you. Additionally, you can test this by using an HTML helper on on of the other properties of the AboutItem class. For instance:
#Html.TextBoxFor(x=>x.AboutItem.Id)
This should render in the HTML
<input type="text" name="AboutItem.Id" id="AboutItem_Id />
EDIT
Apparently the id attribute will be rendered with an underscore instead of a dot. However, since the ID attribute is not used in model binding, it shouldn't really matter.

ASP.NET MVC 4, Multiple model in View, System.NullReferenceException:

I have a problem with my App.
I have This Multiple Model:
public class MultipleModel
{
public Staff Staff;
public RegisterModel RegisterModel;
}
public class RegisterModel
{
[Required]
[Display(Name = "User name")]
public string UserName { get; set; }
[Required]
[StringLength(100, ErrorMessage = "The {0} must be at least {2} characters long.", MinimumLength = 6)]
[DataType(DataType.Password)]
[Display(Name = "Password")]
public string Password { get; set; }
[DataType(DataType.Password)]
[Display(Name = "Confirm password")]
[Compare("Password", ErrorMessage = "The password and confirmation password do not match.")]
public string ConfirmPassword { get; set; }
}
public partial class Staff
{
public Staff()
{
this.Tables = new HashSet<Tables>();
}
public int EmployeeID { get; set; }
public string First_name { get; set; }
public string Last_name { get; set; }
public string Telephone { get; set; }
public string Description { get; set; }
public string Username { get; set; }
public virtual ICollection<Tables> Tables { get; set; }
}
The controler is:
[HttpPost]
[AllowAnonymous]
[ValidateAntiForgeryToken]
public ActionResult MultipleModelView(MultipleModel model)
{
if (ModelState.IsValid)
{
try
{
WebSecurity.CreateUserAndAccount(model.RegisterModel.UserName, model.RegisterModel.Password);
Roles.AddUserToRole(model.RegisterModel.UserName, "Customer");
Staff staff = new Staff();
staff.Username = model.RegisterModel.UserName;
staff.First_name = model.Staff.First_name;
staff.Last_name = model.Staff.Last_name;
staff.Telephone = model.Staff.Telephone;
db.Staff.Add(staff);
db.SaveChanges();
WebSecurity.Login(model.RegisterModel.UserName, model.RegisterModel.Password);
return RedirectToAction("Index", "Home");
}
catch (MembershipCreateUserException e)
{
ModelState.AddModelError("", ErrorCodeToString(e.StatusCode));
}
}
return View(model);
}
And View is:
#model test13.Models.MultipleModel
#{
ViewBag.Title = "MultipleModelView";
}
<h2>MultipleModelView</h2>
#using (Html.BeginForm("MultipleModelView", "Account", FormMethod.Post))
{
#Html.AntiForgeryToken()
#Html.ValidationSummary()
<fieldset>
<legend>Registration Form</legend>
<ol>
<li>
#Html.LabelFor(m => m.RegisterModel.UserName)
#Html.TextBoxFor(m => m.RegisterModel.UserName)
</li>
<li>
#Html.LabelFor(m => m.RegisterModel.Password)
#Html.PasswordFor(m => m.RegisterModel.Password)
</li>
<li>
#Html.LabelFor(m => m.RegisterModel.ConfirmPassword)
#Html.PasswordFor(m => m.RegisterModel.ConfirmPassword)
</li>
<li>
#Html.LabelFor(m => m.Staff.First_name)
#Html.TextBoxFor(m => m.Staff.First_name)
</li>
<li>
#Html.LabelFor(m => m.Staff.Last_name)
#Html.TextBoxFor(m => m.Staff.Last_name)
</li>
<li>
#Html.LabelFor(m => m.Staff.Telephone)
#Html.TextBoxFor(m => m.Staff.Telephone)
</li>
</ol>
<input type="submit" value="Register" />
</fieldset>
}
#section Scripts {
#Scripts.Render("~/bundles/jqueryval")
}
When i Fill data to the TextBoxs and Post them, App get me Exception in this part of code:
WebSecurity.CreateUserAndAccount(model.RegisterModel.UserName, model.RegisterModel.Password);
System.NullReferenceException: Object reference not set to an instance of an object.
Help me plese with this. Thank you.
Use properties and not fields in your view model:
public class MultipleModel
{
public Staff Staff { get; set; }
public RegisterModel RegisterModel { get; set; }
}
The default model binder in ASP.NET MVC works only with properties. Fields are ignored.
initializes register model in constructor
public class MultipleModel
{
public MultipleModel()
{
this.RegisterModel = new RegisterModel();
}
public Staff Staff{get;set;};
public RegisterModel RegisterModel{get;set;};
}