INSERT return value of stored procedure - sql

Question

I'm trying to INSERT a RETURN value for a stored procedure and I just can't get it to work.
I have one table called "person.person_ids" with fields "id int, uid uniqueidentifier"
and a bunch of other tables called for example "person.employee", "person.client" etc. These tables all get their "id"s as foreign keys from the "person.person_ids" table.
The procedure does this:
CREATE PROCEDURE PERSON.NewPerson
AS
BEGIN
DECLARE #ret INT;
INSERT INTO PERSON.ID_PERSON
VALUES (NEWID());
SET #ret = SCOPE_IDENTITY()
RETURN #ret;
END
GO
and my INSERT looks like this:
INSERT INTO PERSON.EMPLOYEE VALUES
(EXECUTE PERSON.NewPerson, 1, '15434235', '10768348153', '1962-3-2', '1999-10-2', 'PETER', '', 'SMITH', 'HAMMER')
GO
Basically I'm trying to create a stored procedure of function that I can call to automatically generate a new record in "person.person_ids" whenever I insert a new record into "person.employee".
I tried using OUTPUT from INSERT but I could not get it to work and INSERT isn't allowed inside of functions.

Answer 1

Here is your code with the issues fixed and some recommended improvements. The comments explain what and why.
SP:
CREATE PROCEDURE PERSON.NewPerson
(
-- Use an output parameter to get values out of an SP
#NewId INT OUT
)
AS
BEGIN
-- Recommended to always list the columns you are inserting to
-- Personally my preference is to select them (because that scales to multiple inserts), I never use the 'values' clause.
INSERT INTO PERSON.ID_PERSON (uid)
SELECT NEWID();
SET #NewId = SCOPE_IDENTITY();
-- The return statement is for a status for the SP, usually 0 for success, some other int for an error
RETURN 0;
END
GO
Calling SP:
DECLARE #MyNewId INT;
-- Run the SP before your insert to get your new value
EXEC PERSON.NewPerson #MyNewId OUT;
-- Then insert - ideally with a list of columns
INSERT INTO PERSON.EMPLOYEE
SELECT #MyNewId, 1, '15434235', '10768348153', '1962-3-2', '1999-10-2', 'PETER', '', 'SMITH', 'HAMMER'