A problem in returning a table with Null On it - sql

Question

i want my function to return a A table with some values
I must fix something in the update but i don't know what
this is the function FngetTableH BELOW
ALTER FUNCTION [dbo].[FnGetTableH]
(
#Date DateTime
)
RETURNS #Listeab_ Table(CLOSING_PRICE money,IdValeur int)
AS
BEGIN
Insert #Listeab_
( CLOSING_PRICE ,IdValeur)
select Distinct 0 , IdValeur
From Historique
Update #Listeab_
Set CLOSING_PRICE = (Select CLOSING_PRICE
from Historique H
inner join (Select MAX(#Date) As DATEDU,IdValeur FROM Historique
where
DATE_NEGO<= #Date
group by IdValeur ) L2
on
H.DATE_NEGO=L2.DATEDU
and
H.IdValeur=L2.IdValeur
)
return
END
when i Execute this code
declare #Date date = '10/09/2013'
---select*from FnGetTableH(#Date)
select C.IdClient,H.IdValeur,C.RaisonSocial,SUM( case I.sens
WHEN 'c' then + I.Qantite
WHEN'd' then - I.Qantite
END) as 'Solde', H.closing_price
from Imputations I
Inner join FnGetTableH(#Date) H
on H.IdValeur=I.IdValeur
Inner join Clients C
on C.IdClient=I.IdClient
where I.DateImputation=#Date
group by C.IdClient,RaisonSocial,H.closing_price,H.IdValeur
Order by IdClient asc
i get
Msg 512, Niveau 16, État 1, Ligne 4
La sous-requête a retourné plusieurs valeurs. Cela n'est pas autorisé quand la sous-requête suit =, !=, <, <= , >, >= ou quand elle est utilisée en tant qu'expression.
L'instruction a été arrêtée.

Answer 1

In your innermost query I think MAX(#Date) should be MAX(DATE_NEGO), which might explain why the closing price query is returning multiple results.
There is still the possibility of multiple results, so you might need to account for that You could select max(closing_price) if it doesn't matter which, though I suspect it might, in which case you need to do some ordering to select the correct price to use.
EDIT: Try this:
ALTER FUNCTION [dbo].[FnGetTableH]
(
#Date DATETIME
)
RETURNS #Listeab_ TABLE
(
CLOSING_PRICE MONEY,
IdValeur INT
)
AS
BEGIN
WITH prices AS
(
SELECT IdValeur,
CLOSING_PRICE,
ROW_NUMBER() OVER (PARTITION BY IdValuer ORDER BY DATE_NEGO DESC) rn
FROM Historique
WHERE DATE_NEGO <= #Date
)
INSERT #Listeab_(CLOSING_PRICE, IdValeur)
SELECT DISTINCT ISNULL(p.CLOSING_PRICE, 0),
h.IdValeur
FROM Historique h
LEFT OUTER JOIN prices p ON h.IdValeur = p.IdValeur
AND p.rn = 1
RETURN;
END;

Answer 2

your query "Select CLOSING_PRICE from Historique H inner..." may be returning more than 1 value.

Answer 3

Use top to select 1 record. May be it will solve your error.
select Distinct 0 , IdValeur
From Historique
Update #Listeab_
Set CLOSING_PRICE = (Select Top 1 CLOSING_PRICE
from Historique H
inner join (Select MAX(#Date) As DATEDU,IdValeur FROM Historique
where
DATE_NEGO<= #Date
group by IdValeur ) L2
on
H.DATE_NEGO=L2.DATEDU and H.IdValeur=L2.IdValeur
)