Aggregation, grouping error even using OVER PARTITION BY - sql

Question

I'm getting this error
'PRINTING_DATE' is invalid in the select list because it is not contained in either an aggregate function or the GROUP BY clause
but by using OVER PARTITION BY I expected this issues won't appear, why am I still getting this error?
DECLARE #REPORT AS NVARCHAR(50) = '2019-06-19 00:00:00.000'
SELECT
SUM(CASE
WHEN (P_DATE < #REPORT AND P_DATE > DATEADD(DAY, -7, #REPORT))
THEN QTY_PICKED
ELSE 0
END) OVER (PARTITION BY PLANT, PARTS, P_DATE) AS SHIPPED,
SUM(CASE
WHEN E_DATE > #REPORT AND E_DATE < DATEADD(DAY, 7, #REPORT)
THEN QTY_MII
ELSE 0
END) - SUM(CASE
WHEN E_DATE > #REPORT AND E_DATE < DATEADD(DAY, 7, #REPORT)
THEN QTY_PICKED
ELSE 0
END) AS TO_SHIP
FROM
TABLE1 T1
INNER JOIN
TABLE2 T2 ON T1.DELIVERY = T2.DELIVERY
WHERE
PLANT = 'XXX'

Answer 1

As HoneyBadger pointed out, you only have a "OVER PARTITION BY" in the first SUM, not the second.
Try this as a simplified version:
DECLARE #T1 TABLE(PLANT INT,PARTS INT,P_DATE DATE,QTY1 INT, QTY2 INT)
INSERT INTO #T1 VALUES(1,1,'2019-07-03',40,60)
INSERT INTO #T1 VALUES(1,1,'2019-07-03',50,80)
SELECT
SUM(QTY1) OVER (PARTITION BY PLANT, PARTS, P_DATE) AS SHIPPED
,SUM(QTY1) OVER (PARTITION BY PLANT, PARTS, P_DATE) -
SUM(QTY2) OVER (PARTITION BY PLANT, PARTS, P_DATE) AS TOSHIP
,SUM(QTY1) - SUM(QTY2) AS TOSHIP2
FROM #T1
WHERE PLANT = 1
This will raise an error:
Column '#T1.PLANT' is invalid in the select list because it is not contained in either an aggregate function or the GROUP BY clause.
If you comment/delete the line
,SUM(QTY1) - SUM(QTY2) AS TOSHIP2
it will produce a result.
BTW: in this example the error also points to the first SUM, but this one is not the problem.

Answer 2

It is rather unclear what you are trying to do. But I can give a hint: window functions are of no use if your result set is an aggregation that returns a single row.
So, you might want this:
SELECT SUM(CASE WHEN (P_DATE < #REPORT AND P_DATE > DATEADD(DAY, -7, #REPORT))
THEN QTY_PICKED
ELSE 0
END) AS SHIPPED,
(SUM(CASE WHEN E_DATE > #REPORT AND E_DATE < DATEADD(DAY, 7, #REPORT)
THEN QTY_MII
ELSE 0
END) -
SUM(CASE WHEN E_DATE > #REPORT AND E_DATE < DATEADD(DAY, 7, #REPORT)
THEN QTY_PICKED
ELSE 0
END)
) AS TO_SHIP
FROM TABLE1 T1 INNER JOIN
TABLE2 T2
ON T1.DELIVERY = T2.DELIVERY
WHERE PLANT = 'XXX';
Of course, you might want an aggregation query that returns more than one row:
SELECT PLANT, PARTS, P_DATE,
SUM(CASE WHEN (P_DATE < #REPORT AND P_DATE > DATEADD(DAY, -7, #REPORT))
THEN QTY_PICKED
ELSE 0
END) AS SHIPPED,
(SUM(CASE WHEN E_DATE > #REPORT AND E_DATE < DATEADD(DAY, 7, #REPORT)
THEN QTY_MII
ELSE 0
END) -
SUM(CASE WHEN E_DATE > #REPORT AND E_DATE < DATEADD(DAY, 7, #REPORT)
THEN QTY_PICKED
ELSE 0
END)
) AS TO_SHIP
FROM TABLE1 T1 INNER JOIN
TABLE2 T2
ON T1.DELIVERY = T2.DELIVERY
WHERE PLANT = 'XXX'
GROUP BY PLANT, PARTS, P_DATE;