Procedure finding senior employees [closed] - sql

Question

Closed. This question is not reproducible or was caused by typos. It is not currently accepting answers.
This question was caused by a typo or a problem that can no longer be reproduced. While similar questions may be on-topic here, this one was resolved in a way less likely to help future readers.
Closed 4 years ago.
Improve this question
I tried writing a PL/SQL procedure to find if an employee has worked for at least 10 years.
create or REPLACE PROCEDURE IsSenEmp IS
jdate date;
years NUMBER;
BEGIN
SELECT HIRE_DATE into jdate
FROM EMPLOYEES
WHERE EMPLOYEE_ID = 100;
years := "MONTHS_BETWEEN"(SYSDATE, jdate)/12;
if years >= 10 THEN
dbms_output.put_line(first_name||' has worked for more than 10 years.');
ELSE
dbms_output.put_line(first_name||' has NOT worked for 10 years.');
end if;
END;
But I'm getting
Procedure created with compilation error.
in SQL Plus.

Answer 1

You have to declare first_name local variable, something like this:
CREATE OR REPLACE PROCEDURE IsSenEmp IS
-- When declaring local variables let's use table fields' types: %type
jdate EMPLOYEES.HIRE_DATE%TYPE;
years NUMBER;
first_name EMPLOYEES.FIRST_NAME%TYPE; -- <- first_name must be declared
BEGIN
SELECT HIRE_DATE,
FIRST_NAME -- reading FIRST_NAME field ...
INTO jdate,
first_name -- ... into first_name local variable
FROM EMPLOYEES
WHERE EMPLOYEE_ID = 100;
years := "MONTHS_BETWEEN"(SYSDATE, jdate) / 12;
if years >= 10 THEN
dbms_output.put_line(first_name || ' has worked for more than 10 years.');
ELSE
dbms_output.put_line(first_name || ' has NOT worked for 10 years.');
END IF;
END;

Answer 2

I don't have access to HR schema so I created my own sample table. Here you go:
SQL> CREATE TABLE employees
2 (
3 employee_id NUMBER,
4 hire_date DATE,
5 first_name VARCHAR2 (20)
6 );
Table created.
SQL> INSERT INTO employees
2 VALUES (100, DATE '2017-10-25', 'Littlefoot');
1 row created.
SQL> CREATE OR REPLACE PROCEDURE IsSenEmp
2 IS
3 jdate DATE;
4 l_first_name employees.first_name%TYPE;
5 years NUMBER;
6 BEGIN
7 SELECT HIRE_DATE, first_name
8 INTO jdate, l_first_name
9 FROM EMPLOYEES
10 WHERE EMPLOYEE_ID = 100;
11
12 years := MONTHS_BETWEEN (SYSDATE, jdate) / 12;
13
14 IF years >= 10
15 THEN
16 DBMS_OUTPUT.put_line (
17 l_first_name || ' has worked for more than 10 years.');
18 ELSE
19 DBMS_OUTPUT.put_line (l_first_name || ' has NOT worked for 10 years.');
20 END IF;
21 END;
22 /
Procedure created.
SQL> EXEC issenemp;
Littlefoot has NOT worked for 10 years.
PL/SQL procedure successfully completed.
SQL>

Answer 3

you forgot to declare first_name
create or REPLACE PROCEDURE IsSenEmp IS
jdate date;
years NUMBER;
first_name VARCHAR2(100);
BEGIN
SELECT HIRE_DATE into jdate
FROM EMPLOYEES
WHERE EMPLOYEE_ID = 100;
SELECT first_name into first_name
FROM EMPLOYEES
WHERE EMPLOYEE_ID = 100;
years := "MONTHS_BETWEEN"(SYSDATE, jdate)/12;
if years >= 10 THEN
dbms_output.put_line(first_name||' has worked for more than 10 years.');
ELSE
dbms_output.put_line(first_name||' has NOT worked for 10 years.');
end if;
END;