Creating a Procedure with Oracle - sql

Question

im trying to get a job (ORACLE SHEDULER) done in oracle every week.
The point is to loop through the 'Historico' table every week, and check every 'ID_Academista' that is linked to the
'Academista' Table. After that it should compare 'Valor_Atual' to see if its > 20 (it comes from the table 'Tecnologia')
If so, it decrements by 1, if not, it stays the same.
To put it in better english: Every 'Tecnologia' Is a technology, each technology has a individual grade(Valor_Atual)
That will be inside the 'Academista'(student)
Table Historico
Database
Here is the code :
CREATE OR REPLACE PROCEDURE notas
IS
contar INTEGER := 0;
contar2 INTEGER;
BEGIN
SELECT COUNT(*) INTO contar2 FROM Academista;
WHILE contar <= contar2
LOOP
SELECT h.Valor_Atual, h.Valor_Antigo, h.Id_academista FROM HISTORICO h
WHERE h.Id_academista = contar ;
IF
h.Valor_Atual > 20
THEN
UPDATE HISTORICO
SET Valor_Atual = Valor_Atual + 1
WHERE h.Id_academista = contar;
ELSE
UPDATE HISTORICO
SET Valor_Atual = Valor_Atual - 1
WHERE h.Id_academista = contar ;
SET contar := contar + 1;
END IF;
END LOOP;
END;
Errors

Answer 1

You can't use selects inside a pl/sql block without a variable.
CREATE OR REPLACE PROCEDURE notas
IS
contar INTEGER := 0;
contar2 INTEGER;
h_var HISTORICO%rowtype;
BEGIN
SELECT COUNT(*) INTO contar2 FROM Academista;
WHILE contar <= contar2
LOOP
SELECT h.* into h_var FROM HISTORICO h
WHERE h.Id_academista = contar ;
IF
h_var.Valor_Atual > 20
THEN
UPDATE HISTORICO
SET Valor_Atual = Valor_Atual + 1
WHERE h_var.Id_academista = contar;
ELSE
UPDATE HISTORICO
SET Valor_Atual = Valor_Atual - 1
WHERE h_var.Id_academista = contar ;
SET contar := contar + 1;
END IF;
END LOOP;
END;