While loop taking so much time in SQL Server - sql

Question

In my stored procedure, I have 2 while loops and I need to avoid those loops and use cursor or recursive cte
create procedure Parent_Child_UserDetails_Schedule
as
begin
Set nocount on
create table #temptab(id int, userid int, parentid int)
select userid, 1 as valid
into #users
from userdetails
where isactive = 1
truncate table Parent_Child_UserDetails
while(select count(*) from #users where valid = 1) > 0
begin
declare #userid int
select top 1 #userid = userid
from #users
where valid = 1
truncate table #temptab
insert into #temptab(id, userid, parentid)
values(1, #userid, #userid)
declare #id int
set #id = 1
while((select count(*) from userdetails
where parentid in (select userid from #temptab where id=#id ) and isactive = 1) > 0)
begin
insert into #temptab (id, userid, parentid)
select #id + 1, userid, #userid
from userdetails
where parentid in (select userid from #temptab where id = #id)
and isactive = 1
set #id= #id + 1
end
insert into Parent_Child_UserDetails(Parentid, Userid)
select parentid, userid
from #temptab
update #users
set valid = 0
where userid = #userid
end
drop table #temptab
drop table #users
Set nocount off
end
Please help me .....

Answer 1

Following our conversation in the comments, what you need is to insert to the Parent_Child_UserDetails table all the parent ids and user ids where both are active,
you can replace that RBAR nightmare of a code with a single insert....select statement, like this:
insert into Parent_Child_UserDetails(Parentid, Userid)
select parentid, userid
from userdetails as t0
where isactive = 1
and exists
(
select 1
from userdetails as t1
where t1.isavtice = 1
and t1.userId = t0.ParentId
)