Error in my stored procedure in SQL Server - sql

Question

I try to write stored procedure which will check:
If table and columns exists then we write data
If table not exist then we create it and write data
If table exist then we check existing columns and we write data into exists
columns
This is the code:
CREATE PROCEDURE [dbo].[my_proc] #file_path VARCHAR(1000) = NULL
,#file_type VARCHAR(1000) = NULL
,#file_name VARCHAR(1000) = NULL
,#table_name VARCHAR(1000)
AS
BEGIN
DECLARE #sql NVARCHAR(4000);
SET #table_name = '[dbo].[' + #table_name + ']'
SET #sql = '
DECLARE #msg VARCHAR(max)
--if column and table exist
IF (
EXISTS (
SELECT *
FROM sys.objects
WHERE object_id = OBJECT_ID(''' + #table_name + ''', ''U'')
) --табличка
AND EXISTS (
SELECT *
FROM sys.columns
WHERE object_id = OBJECT_ID(''' + #table_name + ''', ''U'')
AND (
NAME = '' path_file ''
AND NAME = '' file_type ''
AND NAME = '' file_name ''
)
)
) --поля
BEGIN
INSERT INTO ' + #table_name + ' (
file_path
,file_type
,file_name
)
VALUES (
''' + isnull(#file_path, '') + '''
,''' + isnull(#file_type, '') + '''
,''' + isnull(#f ile_name, '') + '''
)
END
--if table not exist
IF NOT EXISTS (
SELECT *
FROM sys.objects
WHERE object_id = OBJECT_ID(''' + #table_name + ''', ''U'')
)
BEGIN
CREATE TABLE ' + #table_name + ' (
id INT NOT NULL identity(1, 1) PRIMARY KEY
,file_path TEXT
,file_name TEXT
,file_type TEXT
)
END
--if table exist
IF EXISTS (
SELECT *
FROM sys.objects
WHERE object_id = OBJECT_ID(''' + #table_name + ''', ''U'')
)
BEGIN
--check for columns in table
--file_path
IF NOT EXISTS (
SELECT *
FROM sys.columns
WHERE object_id = OBJECT_ID(''' + #table_name + ''', ''U'')
AND (
NAME = ''path_file''
OR NAME = ''file_path''
)
)
BEGIN
PRINT (''NOT COLUMN path_file'')
END
--file name
IF NOT EXISTS (
SELECT *
FROM sys.columns
WHERE object_id = OBJECT_ID(''' + #table_name + ''', '' U '')
AND NAME = '' file_name ''
)
BEGIN
PRINT ('' NOT COLUMN file_name '')
END
--file_type
IF NOT EXISTS (
SELECT *
FROM sys.columns
WHERE object_id = OBJECT_ID(''' + #table_name + ''', ''U'')
AND (
NAME = ''file_type''
OR NAME = ''file_type''
)
)
BEGIN
PRINT (''NOT COLUMN file_type'')
END
ELSE
INSERT INTO ' + #table_name + ' (
file_path
,file_name
,file_type
)
VALUES (
''' + isnull(#file_path, '') + '''
,''' + isnull(#file_name, '') + '''
,''' + isnull(#f ile_type, '') + '''
)
END';
EXEC (#sql);
END
Trouble with already existing table, but without columns I need
Help me please

Answer 1

I tried to run your script and the only error was happening was a miss declared variable.
You were writing "#f ile_name" with an empty space.
BTW I would suggest you to split your code to read. I tried to mess as little as possible.
CREATE PROCEDURE [dbo].[my_proc]
#file_path VARCHAR(1000) = NULL
,#file_type VARCHAR(1000) = NULL
,#file_name VARCHAR(1000) = NULL
,#table_name VARCHAR(1000)
AS
BEGIN
DECLARE #sql NVARCHAR(4000);
DECLARE #msg VARCHAR(max);
SET #table_name = '[dbo].[' + #table_name + ']'
SET #sql = '
--If table not exist then we create it
IF NOT EXISTS (
SELECT *
FROM sys.objects
WHERE object_id = OBJECT_ID(N''' + #table_name + ''')
AND type IN (N''U'')
)
BEGIN
CREATE TABLE ' + #table_name + ' (
id INT NOT NULL identity(1, 1) PRIMARY KEY
,file_path TEXT
,file_name TEXT
,file_type TEXT
)
END';
EXEC (#sql);
SET #sql = '
--If table exist then we check existing columns and we write data into exists columns
IF EXISTS (
SELECT *
FROM sys.objects
WHERE object_id = OBJECT_ID(''' + #table_name + ''', ''U'')
)
BEGIN
PRINT (''TABLE found'')
--check for columns in table
--file_path
IF NOT EXISTS (
SELECT *
FROM sys.columns
WHERE object_id = OBJECT_ID(''' + #table_name + ''', '' U '')
AND (
NAME = '' path_file ''
OR NAME = ''file_path''
)
)
BEGIN
PRINT (''NOT COLUMN path_file'')
END
--file name
IF NOT EXISTS (
SELECT *
FROM sys.columns
WHERE object_id = OBJECT_ID(''' + #table_name + ''', ''U'')
AND NAME = ''file_name''
)
BEGIN
PRINT (''NOT COLUMN file_name'')
END
--file_type
IF NOT EXISTS (
SELECT *
FROM sys.columns
WHERE object_id = OBJECT_ID(''' + #table_name + ''', ''U'')
AND (
NAME = ''file_type''
OR NAME = ''file_type''
)
)
BEGIN
PRINT (''NOT COLUMN file_type'')
END
ELSE
INSERT INTO ' + #table_name + ' (
file_path
,file_name
,file_type
)
VALUES (
''' + isnull(#file_path, '') + '''
,''' + isnull(#file_name, '') + '''
,''' + isnull(#file_type, '') + '''
)
END';
EXEC (#sql);
SET #sql = '
--If table and columns exists then we write data
IF (
EXISTS (
SELECT *
FROM sys.objects
WHERE object_id = OBJECT_ID(''' + #table_name + ''', ''U'')
) --табличка
AND EXISTS (
SELECT *
FROM sys.columns
WHERE object_id = OBJECT_ID(''' + #table_name + ''', ''U'')
AND (
NAME = ''path_file''
AND NAME = ''file_type''
AND NAME = ''file_name''
)
)
) --поля
BEGIN
INSERT INTO ' + #table_name + ' (
file_path
,file_type
,file_name
)
VALUES (
''' + isnull(#file_path, '') + '''
,''' + isnull(#file_type, '') + '''
,''' + isnull(#file_name, '') + '''
)
END';
EXEC (#sql);
END