Prestashop ajax error when decommissioning or quantity increase - prestashop

Question

my big problem is when I choose a version of product or that I update the quantity I have an error ajax "Looking at the console in the console the url of the query ajax the parameters token, id_product and id_customization are duplicated like this:
https://xeof.com/index.php?controller=product?token=64c9f388aad0883a78f350addff907a8&id_product=81&id_customization=0&group%5B19%5D=291&qty=2&token=64c9f388aad0883a78f350addff907a8&id_product=119&id_customization=0&token=64c9f388aad0883a78f350addff907a8&id_product=74&id_customization=0
but that's not all in the log php error I have this error: Undefined variable: find_best in G: \ Dropbox \ Sites \ xeof.com \ classes \ Product.php on line 6103
In the class the call method is this:
/**
* Get an id_product_attribute by an id_product and one or more
* id_attribute.
*
* e.g: id_product 8 with id_attribute 4 (size medium) and
* id_attribute 5 (color blue) returns id_product_attribute 9 which
* is the dress size medium and color blue.
*
* #param int $idProduct
* #param int|int[] $idAttributes
* #param bool $findBest
* #return int
* #throws PrestaShopException
*/
public static function getIdProductAttributeByIdAttributes($idProduct, $idAttributes, $findBest = false)
{
$idProduct = (int) $idProduct;
if (!is_array($idAttributes) && is_numeric($idAttributes)) {
$idAttributes = array((int) $idAttributes);
}
if (!is_array($idAttributes) || empty($idAttributes)) {
throw new PrestaShopException(sprintf('Invalid parameter $idAttributes with value: "%s"', print_r($idAttributes, true)));
}
$idAttributesImploded = implode(',', array_map('intval', $idAttributes));
$idProductAttribute = Db::getInstance()->getValue('
SELECT
pac.`id_product_attribute`
FROM
`' . _DB_PREFIX_ . 'product_attribute_combination` pac
INNER JOIN `' . _DB_PREFIX_ . 'product_attribute` pa ON pa.id_product_attribute = pac.id_product_attribute
WHERE
pa.id_product = ' . $idProduct . '
AND pac.id_attribute IN (' . $idAttributesImploded . ')
GROUP BY
pac.`id_product_attribute`
HAVING
COUNT(pa.id_product) = ' . count($idAttributes)
);
if ($idProductAttribute === false && $findBest) {
//find the best possible combination
//first we order $idAttributes by the group position
$orderred = array();
$result = Db::getInstance()->executeS('
SELECT
a.`id_attribute`
FROM
`'._DB_PREFIX_.'attribute` a
INNER JOIN `'._DB_PREFIX_.'attribute_group` g ON a.`id_attribute_group` = g.`id_attribute_group`
WHERE
a.`id_attribute` IN (' . $idAttributesImploded . ')
ORDER BY
g.`position` ASC'
);
foreach ($result as $row) {
$orderred[] = $row['id_attribute'];
}
while ($idProductAttribute === false && count($orderred) > 0) {
array_pop($orderred);
$idProductAttribute = Db::getInstance()->getValue('
SELECT
pac.`id_product_attribute`
FROM
`'._DB_PREFIX_.'product_attribute_combination` pac
INNER JOIN `'._DB_PREFIX_.'product_attribute` pa ON pa.id_product_attribute = pac.id_product_attribute
WHERE
pa.id_product = '.(int)$idProduct.'
AND pac.id_attribute IN ('.implode(',', array_map('intval', $orderred)).')
GROUP BY
pac.id_product_attribute
HAVING
COUNT(pa.id_product) = '.count($orderred)
);
}
}
if (empty($idProductAttribute)) {
throw new PrestaShopObjectNotFoundException('Can not retrieve the id_product_attribute');
}
return $idProductAttribute;
}
I replace the variable like this on line 6103:
Before:
if ($ idProductAttribute === false && $ find_best)
After:
if ($ idProductAttribute === false && $ findBest)
But no luck I have an exception:
Can not retrieve the id_product_attribute at line 6143 in file classes / Product.php
which I do not find the solution!
I noticed that when I change theme for the classic without having to change php code these settings are not duplicate and I am no other php error.

Answer 1

change this:
if ($ idProductAttribute === false && $ findBest)
to:
$findBest = true;
if ($ idProductAttribute === false && $ findBest)

Answer 2

On Prestashop 1.7.4 I have added this override/classes/Products.php file in order to solve the error during AJAX calls
<?php
class Product extends ProductCore {
public static function getIdProductAttributeByIdAttributes($idProduct, $idAttributes, $findBest = true)
{
return parent::getIdProductAttributeByIdAttributes($idProduct, $idAttributes, $findBest);
}
/**
* #deprecated 1.7.3.1
* #see Product::getIdProductAttributeByIdAttributes()
*/
public static function getIdProductAttributesByIdAttributes($id_product, $id_attributes, $find_best = true)
{
return self::getIdProductAttributeByIdAttributes($id_product, $id_attributes, $find_best);
}
}
Now combinations works properly