how to add wait in framework in selenium - selenium

Question

this is my test:
public void Add_Store()
{
StepDescription = " Create a Store";
Thread.Sleep(15000);
Store_Link.Click();
Thread.Sleep(15000);
Create_Store_Button.Click();
System.Threading.Thread.Sleep(Convert.ToInt32("5000"));
}
I want to remove all the sleep; where should i add the wait now? i want to make it generic; so it make sense to add in the element locator itself?
the element locator looks as below:
[Find(ControlType = ElementType.Hyperlink, Properties = "XPath=//a[starts-with(#id, 'Stores')]")]
private Element Store_Link { get; set; }
since i want to make the wait generic, can you guide me how to remove the sleep and add the wait?

Answer 1

As you have tagged Python :
You can use explicit wait as #Ishita has mentioned. Though you want to have generic wait , that can be used every where.
For generic, you may create instance of WebDriverWait in setup/fixtures level.Something like :
from selenium.webdriver.support.ui import WebDriverWait
from selenium.webdriver.support import expected_conditions as EC
wait = WebDriverWait(webDriverInstance, timeInSec)
#wait = WebDriverWait(driver, 30)
wait.until(EC.visibility_of_element_located((By.ID, 'Some id')))
or may be somewhere else in your code :
wait.until(EC.element_to_be_clickable((By.ID, 'Some id')))
Now you can use this wait reference, in your code where ever it has the accessibility.
For Reference, you can use this link Selenium_explicit_wait_Python
and the code you have shared look likes in C# :
You can use this code in this case :
WebDriverWait wait = new WebDriverWait(driver, TimeSpan.FromSeconds(Time));
wait.Until(ExpectedConditions.ElementToBeClickable(locator));
Note that we can bind conditions with EC (ExpectedConditions).
Hope this will help.

Answer 2

you can use Explicit wait instead of sleep,
Python:
from selenium.webdriver.support.ui import WebDriverWait
from selenium.webdriver.support import expected_conditions as EC
WebDriverWait(driver, 10).until(EC.visibility_of_element_located((By.XPATH, ""))).click()
//EC.presence_of_element_located
//EC.element_to_be_clickable
C#:
WebDriverWait wait = new WebDriverWait(Driver, TimeSpan.FromSeconds(10));
wait.Until(ExpectedConditions.ElementToBeClickable(webElement)).Click();
There are many types of wait.
One of the best Solution for creating JS wait Framework for project:
Blog Link : https://www.swtestacademy.com/selenium-wait-javascript-angular-ajax/
& Github link : https://github.com/swtestacademy/JSWaiter