MS Access query with parameter from combobox in form does not return any results - vba

I have created an MS Access database with several tables and queries but the problem described further down is about the following:
tEmployee table contains employee data as the name implies.
tCases table contains data about court cases.
Each case can be assigned to only one employee. I have created a relationship from [tCases]![assignedTo] field to tEmployee.
fSearches is a form to perform searches among the cases. It includes a combobox cEmployee which is populated from [tEmployee].[surname] and a command button to perform the search.
GOAL: to select employee in [fSearches]![cEmployee], hit the button and show all the cases assigned to this employee in another form named fResultsCases.
This is the code for the button where lines in comments are some of the things I've tried:
If cEmploee.ListIndex = -1 Then
MsgBox "You have to select employee to perform search.", title:="Missing value!"
Else
tHidden2.SetFocus
tHidden2.Text = "assigned to " & cEmploee & "."
DoCmd.OpenForm "fResultsCases"
'Forms("fResultsCases").RecordSource = "SELECT * FROM tCases WHERE [tCases]![assignedTo] like [Forms]![fSearches]![cEmploee];"
'Forms("fResultsCases").RecordSource = "SELECT * FROM tCases WHERE tCases .[assignedTo] = [Forms]![fSearches]![cEmploee];"
Forms("fResultsCases").RecordSource = "SELECT * FROM tCases WHERE [assignedTo] = [Forms]![fSearches]![cEmploee];"
Forms("fResultsCases").Recalc
End If
With all the above mentioned I get the following:
[fResultsCases] opens but does not return any case.
I tried to omit the WHERE clause and [fResultsCases] returns all cases as expected.
Then I tried to narrow things down to understand the problem by creating a simple query with one parameter and got exactly the same results.
SELECT tCases.[case number], tCases.subject, tCases.fromDt, tCases.toDt,
tCases.assignedTo, tCases.[date assigned], tCases.[date completed]
FROM tCases
WHERE (((tCases.assignedTo)=[Forms]![fSearches]![cEmploee]));
It seems like I'm missing something about the WHERE clause when it comes to combobox values but I can't figure it out. I am new to MS Access. Any help will be very appreciated.
UPDATE:
cEmploee rowsource property: SELECT [tEmployee].surname FROM tEmployee ORDER BY [surname];
cEmploee bound column property: 1

I cannot recreate your issue replicating your setup with combox that triggers an update of form's recordsource. And because neither an error is raised nor parameter input prompt appears, likely the WHERE clause is returning False (i.e., no matching records) and hence no rows are returned.
The reason can likely be due to the combobox [Forms]![fSearches]![cEmploee] which show Employee's surname but is bound to the unique ID as the default setup of Access' comboboxes (if using wizard). See Data tab of combobox's properties in Design View.
The reason for this hidden bound field is users never know the unique ID of a record but do know the value (i.e., name). So when they select the recognized name they are really selecting the corresponding unique ID. Therefore, consider adjusting WHERE condition accordingly where ID is the unique table ID field which matches the bound field of combobox.
Forms("fResultsCases").RecordSource = "SELECT * FROM tCases WHERE [ID] = [Forms]![fSearches]![cEmploee];"
Forms("fResultsCases").Recalc
Forms("fResultsCases").Form.Requery ' USUALLY THE RECORDSOURCE UPDATE CALL

After about ten days of "struggle" with this brainteaser, I decided to post this question to ask for help. Fortunatelly #Parfait has involved with my problem and with his/her accurate remarks helped me understand my mistakes. It also helped me Ken Sheridan's post here. So I am posting my answer just for future reference. #Parfait, I sincerely thank you for your time.
So the problem in this case was primarily understanding how relationships between tables affect data types. If you want to connect a textfield of tableA to tableB, then there are two cases. If the primary key in tableB is number then textfield becomes number. If the primary key in tableB is text then textfield remains text.
In my case it was the first one. Specifically the field [tCases]![assignedTo] after creating relationship with table [tEmployee], was turned automatically into number (It still shows the surname but contains the corresponding primary key in tEmployee). On the contrary combobox [cEmploee] still contained text. This why this line:
Forms("fResultsCases").RecordSource = "SELECT * FROM tCases WHERE [assignedTo] = [Forms]![fSearches]![cEmploee];"
was not returning any record as #Parfait successfully guessed.
At this point there were two possible solutions:
1) Set surname as primary key to agree with combobox contents.
delete the relationship between [tCases]![assignedTo] and [tEmployee].
set field [tEmployee]![surname] (which is text) as primary key in table [tEmployee].
create a new relationship between [tCases]![assignedTo] and [tEmployee].
I did not try this solution though, as a problem would occur if 2 employees had the same surname. So I suggest following the second.
2) Keep the same primary key and use it to match the records from tableA to the surname from tableB.
To achieve this you have to inform access, that you want the records from tableA that have the ID, while in tableB this ID corresponds to the surname inserted in the combobox (hope this makes sense). In other words create a recordset of both tables (union query). For this purpose I replaced the above refered line of code with the following:
Forms("fResultsCases").RecordSource = "SELECT tCases.* FROM tCases INNER JOIN tEmployee ON tCases.[assignedTo] = tEmployee.[employeeID] " & _
"WHERE tEmployee.[surname]=[Forms]![fSearches]![cEmploee] AND tCases![assignedTo]=[tEmployee]![employeeID];"
Hope this saves some time from other people. Have a nice day!

Related

Why can't I use the field name as a parameter in an Access parameter query?

Working through some insert/update queries on an application today and came across a result I hadn't expected.
Queries
My insert queries look similar to this:
PARAMETERS nm TEXT(10), st TEXT(2);
INSERT INTO park(pname, pstate)
VALUES([nm],[st]);
And their companion updates were like this:
PARAMETERS id LONG, nm TEXT(10), st TEXT(2);
UPDATE park
SET
pname = [nm], pstate = [st]
WHERE
ID = [id];
The table they were updating was similar to this:
park
ID LONG | pname TEXT(10) | pstate TEXT(2)
Unexpected Result
Working through writing the queries, I tested each by running it against the database and providing test values for the various parameters. After the insert query, I'd test the update by updating the newly inserted record.
In most cases the tables were empty, so the update would simply update the single record in place.
However as soon as I ran the update on a previously populated table, I found the query was attempting to update ALL records, not just the one whose ID was being provided through the parameter.
The question is why??
Problem
While ID certainly was a field in the park table, using id as a parameter was essentially stating the following in the WHERE clause:
WHERE ID = id;
or
WHERE ID = ID;
Since ID is always equal to itself, the UPDATE attempted to update ALL records instead of only the expected record with the provided ID.
Solution
To fix the problem, I simply used the first and last letter of the table being updated before the id for each case I was updating a record identified by its ID. So the working code - that updates only the record identified - is:
PARAMETERS pkid LONG, nm TEXT(10), st TEXT(2);
UPDATE park
SET
pname = [nm], pstate = [st]
WHERE
ID = [pkid];
Obviously I wasn't paying close attention while I was writing the query -- while I'd used different names for other parameters, I didn't do so when it came to the ID for the update query.
Bottom Line
Whenever working with paramaterized queries, make sure your parameter names DO NOT match your table's field names.
Doing so will avoid the issue noted above as well as other related issues.
You'll also want to avoid reserved words for your table, field, and parameter names.
Hope this helps someone avoid a possibly nasty surprise when updating records -- or trying to figure out why their parameter queries didn't seem to work.

Using Lookup in MS Access Forms

I have a MS Access Form that has Student ID,
This is ok, I can see student ID as it should be
What I want is to display Student Name instead of Student ID
I used SELECT StID, StName From Students in "Row Source"
"Row Source Type" = Table/Query
"Bound Column" = 1
I could not find any property where I can decide the Display Column
Help is much appreciated.
Thanks
Go to the "FORMAT" tab of the Form Properties Dialog Window (the same one you used to set the Row Source and Row Source Type properties)
You'll see two fields (Column Count and Column Widths)
Set Column Count to 2.
Set Column Widths to 0";1"
This works in Access 2007. Any version later then 2007 should also work.
By setting the column count to '2' you're displaying the StudentId and the Name. Then by setting StudentId column width to '0' you are hiding the column.
When you switch to Form View you will see the Student Names, but the value stored underneath is really the StudentId. Neat trick.
Hope this helps.

Access 2010 SQL - UPDATE query not working

I need to create a query for updating a column in a table with values taken from another table and matching a field.
These are the 2 tables:
tblMain
ID Autonumbering
Key Text
Stat1 Integer
tblStat1
ID Autonumbering
Key Text
Freq Integer
I want to UPDATE the tblMain.Stat1 column with tblStat1.Freq value on each record in which tblMain.Key = tblStat1.Key.
I tried this syntax (found somewhere as an example)
UPDATE tblMain
SET tblMain.Stat1 = tblStat1.Freq
WHERE tblMain.Key = tblStat1.Key;
This doesn't work and returns an error on the 2nd row.
After some trials I found that the correct syntax (built with the Access query generator) is this:
UPDATE (tblMaibn INNER JOIN tblStat1 ON tblMain.Key = tblStat1.Key)
SET tblMain.Stat1 = tblStat1.Freq;
In this 2nd syntax, there is no trace of the WHERE condition.
Can someone help me to understand what's wrong with the 1st syntax.
Since I'm building a new table (the join), how can it work on tblMain?
As I said, I found the wrong syntax as an example of UPDATE statement.
Thank you in advance.
Bye,
Ivano
What is happening in your first query on the 2nd row, is that Access isn't aware of what tblStat1 represents in your query.
The reason your 2nd query is working is because it uses an inner join on the relevant key. In order for SQL to be aware of what record in tblMain relates to which record in tblStat1, you need to use a join.
You can see in the generated code that it is updating your desired table, but joining onto the second table. The where condition is redundant as you're updating every record.
In 1st syntax, you can change:
UPDATE tblMain
SET tblMain.Stat1 = (SELECT Freq
FROM tblStat1
WHERE tblMain.Key = tblStat1.Key)

MS Access Query-By-Form Issue

I have a form (fCen1-20) containing two combo boxes. The first combo box is called Lookup Value and the dropdown contains the field Lookup_Value which serves as the primary key for every table in the database. The second combo box is called Category and the dropdown contains the fields Category, Code, and Table.
I would like for the user to select the Lookup Value and Category and for those selections to inform a query which returns the value of the selected Category for the selected Lookup Value. The complicating factor is that each Lookup Value is associated with over 1500 unique categories of information which are each assigned a unique code -- the code serves as the field name.
For your reference, I have pasted my code, along with my rationale, below:
SELECT [Forms]![fCen1-20]![Category 1].Code
' Rationale: Get the value for the Code associated with a given category
FROM [Forms]![fCen1-20]![Category 1].Table
' Rationale: Reference the Table where the selected Category/Code is housed
ON [Forms]![fCen1-20]![Category 1].Table.Lookup_Value = _
[Forms]![fCen1-20].[Lookup Value];
' Rationale: Select only those records in the table
' for which the Lookup_Value field matches the Lookup Value
' selected in the form
When I run this code, I'm given a "Syntax error in FROM clause" error. Any suggestions on how to make this work? Please let me know if you'd like any additional detail or clarification. Thanks!
If you use this in a query, it will probably work assuming the form fCen1-20 is open in Form View.
SELECT [Forms]![fCen1-20]![Category 1]
The value returned will be from the bound column of the currently selected combo box row. The fact that [Category 1] includes 3 columns does not matter. The db engine only sees the column which is "bound". (Check the combo's Bound Column property on the Data tab of the combo's property sheet.) The bound value is the only combo value available in a query.
You can not append a column name to the combo name to retrieve the values from those columns, so these will both fail:
[Forms]![fCen1-20]![Category 1].Code
[Forms]![fCen1-20]![Category 1].Table
That was my explanation for why I believe your approach is not working. However, I don't know what to suggest instead. In general, if you use a table's primary key as a combo's bound value, you can use that bound value with a DLookup expression in a query. As an example, assuming all values are numeric ...
SELECT fld1, fld2, etc
FROM YourTable
WHERE some_field = DLookup(
"lookup_field",
"AnotherTable",
"pkey_field = " & [Forms]![fCen1-20]![Category 1]
);
Unfortunately I don't know whether that suggestion is useful for your situation because I don't clearly understand what you're trying to accomplish.

Error in Querying Concatenation of 2 fields in LibreOffice Base SQL

My apologies for wrong terminilogies, I am not actually a programmer, just a Base user confronted with a problem.
I'm having trouble querying a column which is supposed to be a concatenation of two fields of two separate tables. I'm using LibreOffice Base Version 1:3.6.2 and it has the default HSQL engine.
My two tables are as follows:
Table 1 is named "Prefectures" and has the following fields: ID, "Prefecture Name", and "State"
Table 2 is named "Ward" and has the following fields: ID, "Ward Name", and Prefecture ID which is a foreign key referencing table 1.
What I want my query to produce is these two colums: "Ward Name, Prefecture Name" as a concatenation of the Ward.WardName and Prefecture.PrefectureName, and the Ward ID
For example. If I had a prefecture named "Cebu" and a ward named "Lahug" which has a ward ID of 0, I want the query to come up with "Lahug, Cebu" on column 1, and "0" in column 2
The Base tutorial I used seems to have a modified language compared to the actual HSQL language, at least based on my programmer friends reaction. I know that attributes are referred to as Table.Attribute, for example, but in Base, they use "Attribute", or, if I am not mistaken, when one needs to specify the table of origin, "Table"("Attribute"). However, I know that this modified language works because I used it to create the my two tables.
Anyways, hazarding on what I learned from Base the tutorial document, I came up with:
SELECT "Ward Name" || ', ' || "Prefecture Name" AS "Wrd_Pref",
"Ward ID"
FROM "Prefecture" INNER JOIN "Ward" ON "Prefecture" ("Prefecture ID") = "Ward" ("Prefecture ID")
;
And the error message that came up was:
"The data content could not be loaded. Access is denied: PREFECTURE in statement [the whole code above]"
I have a suspicion this is a misread due to wrong syntax on my part. Perhaps my guess on using perentheses in this case is wrong? If so, why is the error message "Access denied"? I checked both the records and the sql codes of the two tables, both were perfectly normal.
EDIT: No, I don't want to just split the two fields. I need them concatenated as I am going to use them as list items in a dropdown list for a form I am making.
The SQL query is this one. You say your tables are called "Prefectures" and "Ward", which are used in the FROM clause.
SELECT "Ward Name" || ', ' || "Prefecture Name" AS "Wrd_Pref", "Ward ID"
FROM "Prefectures" INNER JOIN "Ward" ON "Prefectures"."Prefecture ID" = "Ward"."Prefecture ID";