check for duplicates in diffrent worksheets and thereafter print value - vba

Question

I have searched but i cant seem to figure out how to print specified value in the column next to where i find my duplicate. What i have since earlier are code that first specify the diffrent ranges and thereafter look if a duplicate is found in sheet Y from sheet X. Sheet Le is this weeks information and sheet Be is the last weeks information.
IF i find a duplicate in the specified range i want to on my Delivery sheet print in column A next to the duplicate either Delivered or not delivered depending on if my output from function compareAEO print true or false.
The conditions that i am looking for are that if the we can find the same value that are in column B in sheet (Le) on sheet (Be) it will then check if the text in column F has changed. IF SO then it shall print in column A on sheet (Le) = Delivered. Otherwise not delivered.
It then checks to se if the dates in column M is the same. IF not then it shall print Replanned in column A on sheet (Le).
Shortly
IF value in cell on column B, Sheet (Le) = Value in column B, Sheet (Be) then
value in column A on sheet Le = "Delivered" Else "not deliverd".
Then
If value in cell in column M, Sheet (Le) <> If value in cell in column M, Sheet (Be) then value in column A, Sheet(Le) = "replanned"
This is how my data looks like,
Sheet (Le)
Col B Col F Col M
PZ2408 X13 2017-02-13
PZ2345 X30 2017-02-23
PZ2463 X45 2017-02-25
PZ2513 X13 2017-02-10
PZ2533 X70 2017-02-05
PZ2561 X60 2017-02-20
For sheet (Be) my data looks like this
Col B Col F Col M
PZ2408 X30 2017-02-13
PZ2345 X30 2017-02-23
PZ2463 X30 2017-02-25
PZ2513 X13 2017-02-05
PZ2533 X13 2017-02-10
PZ2561 X60 2017-02-17
After the code has done its course i would like it to show for example,
Sheet (Le)
col A Col B Col F Col M
Delivered PZ2408 X13 2017-02-13
Not Delivered PZ2345 X30 2017-02-23
Delivered PZ2463 X45 2017-02-25
replanned PZ2513 X13 2017-02-10
Delivered PZ2533 X70 2017-02-05
replanned PZ2561 X60 2017-02-20
Bascilly my Not delivered, delivered and Replanned statements does not work and my brain does not work.
Can SO help save my day?
Sub checkASMT()
Dim rng1 As Range
Dim rng2 As Range
Dim lastRowSource As Long
Dim lastRowTarget As Long
Dim row As Long
Dim ASMT As String
'Looping trough Range
With ThisWorkbook.Worksheets("Le")
lastRowTarget = .Range("B" & .Rows.Count).End(xlUp).row
For i = 29 To lastRowTarget
ASMT = .Range("b" & i).value
'Define range and see if we can find duplicates
With ThisWorkbook.Worksheets("Be")
lastRowSource = .Range("B" & .Rows.Count).End(xlUp).row
Set rng1 = .Range("B3", "B" & lastRowSource)
row = findValueInRangeReturnRow(rng1, ASMT)
'Check FAX
If compareAEO(i, row, "FAX") = True Then
'Debug.Print compareASMT(i, row, "FAX")
Worksheets("Le").Cells(i, ASMT).value = "Not Delivered"
Else
.Worksheets("Le").Cells(i, ASMT).value = "delivered"
'Check if dax are correct
If compareAEO(i, row, "DAX") = False Then
.Worksheets("Le").ASMT.Offset(0, 1).value = "Replan"
End If
End With
Next i
End With
End Sub
here are my first function
Function findValueInRangeReturnRow(rng As Range, value As Variant) As Long
Set c = rng.Find(value, LookIn:=xlValues)
If Not c Is Nothing Then
findValueInRangeReturnRow = c.row
End If
End Function
My second function that checks if duplicates are found in specified ranges.
Function compareAEO(rad1 As Variant, rad2 As Variant, typeCOMPARE As String) As Boolean
Dim col1 As String
Dim col2 As String
Select Case typeCOMPARE
Case "FAX"
col1 = "F"
col2 = "F"
Case "DAX"
col1 = "M"
col2 = "M"
End Select
If ThisWorkbook.Worksheets("Le").Range(col1 & rad1).value = ThisWorkbook.Worksheets("Be").Range(col2 & rad2).value Then
compareAEO = True
Else
compareAEO = False
End If
End Function

Answer 1

You were getting the last row of both pages in each loop. It is only necessary to get them once at the top, outside the loop. Same for the range you were setting. You can see that I put them at the top, before the loop.
I don't really know what you were using ASMT for. It looks like you were trying to use it as a range in some of your coding instead of range("B" & I). I used strings in the "B" column of Le to compare to the "B" column of Be when I tested it.
It works for me. You'll have to change it to suit your needs. You don't need all the functions, what they accomplished are all within this subroutine.
Sub checkASMT()
Dim rng1 As Range
Dim rng2 As Range
Dim lastRowLE As Long
Dim lastRowBe As Long
Dim row As Long
Dim ASMT As String
Dim LEws As Worksheet
Dim tmpRng As Range
Set LEws = Worksheets("Le")
lastRowLE = Sheets("Le").Cells(ActiveSheet.Rows.Count, "B").End(xlUp).row
lastRowBe = Sheets("Be").Cells(ActiveSheet.Rows.Count, "B").End(xlUp).row
Set rng1 = Sheets("Be").Range("B3", "B" & lastRowBe)
For i = 29 To lastRowLE
Set tmpRng = Sheets("Le").Range("b" & i)
ASMT = tmpRng.Value
Set c = rng1.Find(ASMT, LookIn:=xlValues)
If Not c Is Nothing Then
row = c.row
If ThisWorkbook.Worksheets("Le").Range("F" & i).Value = ThisWorkbook.Worksheets("Be").Range("F" & row).Value Then
' Worksheets("Le").Cells(i, ASMT).Value = "Not Delivered"
' Did you intend to use ASMT as the column number?
' I'm going to hard code that as column 27 for my purposes. You can change it if you need to
LEws.Cells(i, 27).Value = "Not Delivered" ' column 27 is "AA"
Else
LEws.Cells(i, 27).Value = "Delivered"
End If
If ThisWorkbook.Worksheets("Le").Range("M" & i).Value = ThisWorkbook.Worksheets("Be").Range("M" & row).Value Then
' .Worksheets("Le").ASMT.Offset(0, 1).Value = "Replan"
' again I don't understand the reference to ASMT. That is a string value - unless it is a numeric value in the string
' I'm going to assume that you intended for "Replan" to go into column C on row i
Else
LEws.Range("C" & i).Value = "Replan"
End If
End If
Next i
End Sub

Answer 2

Try this; place data in single sheet from B to G (Le then Be); place this formula in column H
=IF(VLOOKUP(E2,B$2:D$7,2,FALSE)=F2,IF(G2<D2,"replanned","Not Delivered"),"delivered")
tweak this formula to suit your needs to make it work across sheets