How to assign value in stored procedure variable when executing it? - sql

Question

This is my SQL code
CREATE PROC sp_procedure
(#Name VARCHAR(50),
#Stock numeric)
AS
DECLARE #Code CHAR(4)
BEGIN
UPDATE tbProcedure
SET Name = #Name, Stock = #Stock
WHERE Code = #Code
SELECT * FROM tbProcedure
END
Then I execute the code like this
EXEC sp_procedure 'Name',15,2
Then I got error result saying too many argument specified.
I also tried this
EXEC sp_procedure 'Name',15
It doesn't return an error, but 0 rows affected.
I want to assign #Code value when I execute the stored procedure, is it even possible to do that ?
EDIT:
Sorry, it's actually a CHAR(4), not INT
Again sorry, I just copy paste all code without looking at it first, above is the actual code, I am very sorry for the confuse...

Answer 1

It looks like you are providing the parameters in a different order than you have declared them. Choice is declared before Name but you are providing Name first when executing the procedure. Also, don't you want your update statement to say "code = #choice"? The local variable is undefined and not needed.

Answer 2

For Microsoft SQL Server
For your problem:
(don't use sp prefix) and (#code is not a parameter so we cannot pass value, it is local variable)
If you are having some problems with IF then, make #code as parameter but pass null value when needed and make that null check in procedure.
See below to assign values:
USE [databasename]
GO
DECLARE #return_value int
EXEC #return_value = <procedurename>
#stringvariable = N'<stringvalue>',
#Flag = <integervalue>
SELECT 'Return Value' = #return_value (return value if any)
GO

Answer 3

I have come to a conclusion that its impossible to combine branching stored procedure if one of the branch do not use all the parameters.
And because of that I have write 2 stored procedures, below is my full code :
For insert procedure: [this is the procedure that using a variable]
CREATE PROC InsProcedure
(#Name VARCHAR(50),
#Stock numeric)
AS
DECLARE #CODE INT
DECLARE #CODE2 CHAR(4)
BEGIN
// Creating custom auto number
SET #CODE = 0
SELECT #CODE = ISNULL(MAX(CAST(KodeBarang AS INT)), 0)
FROM tbProcedure
SET #CODE2 = #CODE + 1
SET #CODE2 = REPLICATE('0', 4 - LEN(#CODE2)) + #CODE2
// End Custom auto number
INSERT INTO tbProcedure VALUES(#CODE2, #Name, #Stock)
SELECT * FROM tbProcedure
END
For update, delete, and show procedure:
CREATE PROC OtherProcedure
(#choice int, // this is for branching option later
#Code CHAR(4),
#Name VARCHAR(50),
#Stock numeric)
AS
IF #choice = 1
BEGIN
UPDATE tbProcedure
SET Name = #Name, Stock = #Stock
WHERE Code = #Code
SELECT * FROM tbProcedure
END
ELSE IF #choice = 2
DELETE FROM tbProcedure
WHERE KodeBarang = #Code
ELSE
SELECT * FROM tbProcedure
and use the procedures like this :
InsProcedure 'Laptop', 5
Result:
00001, Laptop, 5
Branch 1 [Update]
OtherProcedure 1, 'Laptops', 10, 00001
Result:
Before : 00001, Laptop, 5
After : 00001, Laptops, 10
Branch 2 [Delete]
OtherProcedure 2, '', 0, 00001 // Delete record where Code is '00001'
Branch 3 [Show]
OtherProcedure 3, '', 0, 0 // You can also use any number besides 3

Answer 4

First of all, your variable #Stock doesn't return decimal because it's INT variable, you might try float or something else. It's the reason why it shows an error if you give it "15,2"
WHERE Code = #Code
And 0 rows affected was caused because you didn't set that variable properly.
You have to assign a valid value to it.