I have some tables with more than 700 columns/1000 columns.
Now I want to display all columns from this table to ISNULL(col1,0) format because when I use PIVOT/UNPIVOT and if there are some NULL values then they wont be converted to NULL and becomes empty strings. So I am trying to replace those NULLs with 0.
In this example I used sysobjects table so that you can try it in your ssms.
The result of this is incomplete as neither VARCHAR(MAX) nor NVARCHAR(MAX) is enough. How do I get all rows rather than few rows here?
DECLARE #colsUnpivot VARCHAR(MAX)
SET #colsUnPivot = STUFF((
SELECT ',' + 'ISNULL(' + QUOTENAME(name) + ', 0) AS '
+ QUOTENAME(name)
FROM sysobjects t
FOR XML PATH(''), TYPE ).value('.', 'NVARCHAR(MAX)') ,1,1,'')
PRINT #colsUnPivot
set #query = 'SELECT id,code_name,lkp_value
FROM
(
SELECT unitid,institution,city,state,zip, '+ #colsUnpivot+'
FROM sysobjects) AS cp
UNPIVOT (lkp_value for code_name IN ('+#colsUnPivot+')
) AS up'
--PRINT #Query
--PRINT #Query1
exec(#query)
I mean the code above does not make sense but I can not produce same thing that I have as i have to use sysobjects here.
But above code is throwing an error:
Msg 102, Level 15, State 1, Line 6
Incorrect syntax near '('.
And that's because there is so much data and it's being truncated.
Here is what my PRINT says,
,ISNULL([opd_
So I still think its truncating.
Your problem is that the PRINT command will truncate the data for display in SSMS.
I would suggest leaving it as XML and doing a SELECT, if you just need to see the data in SSMS without truncating:
DECLARE #colsUnpivot xml
SET #colsUnPivot = (SELECT ',' + 'ISNULL(' + QUOTENAME(name) + ', 0) AS '
+ QUOTENAME(name)
FROM sysobjects t
FOR XML PATH(''), TYPE ).value('.', 'NVARCHAR(MAX)')
SELECT #colsUnPivot
SSMS treats XML output differently and has a higher threshold for truncating the data.
Use SELECT instead of print in your SQL.
SELECT #colsUnPivot
Also, make sure that these values are maxed out in Results to Grid:
Related
I'm trying to get the column names of a table using XML datatype and information_schema columns. When I tried to use the result in another select statement, I have the results with the repeated column name instead of the results set. I have even tried to cast it to varchar but it still failed. what have done wrong ?
DECLARE #TSQL1 varchar(1000);
SELECT #TSQL1 = CAST((SELECT SUBSTRING((SELECT ', ' + QUOTENAME(COLUMN_NAME)
FROM [ProdLS].[ information_schema.columns]
WHERE table_name = 'roles'
ORDER BY ORDINAL_POSITION
FOR XML PATH('')), 3, 200000)) AS varchar(max));
SELECT #TSQL1
FROM [aubeakon_scrm4].[acl_roles]
My query to get the results from roles table using the column name retrieved from.
You cannot execute dynamic SQL like that. You need to use sp_executesql. You also need to declare dynamic SQL as nvarchar(max).
You should also use .value to unescape the XML
DECLARE #TSQL1 nvarchar(max) = N'
SELECT
' + STUFF((
SELECT ', ' + QUOTENAME(COLUMN_NAME)
FROM [ProdLS].[information_schema].columns
WHERE table_name = 'roles'
ORDER BY ORDINAL_POSITION
FOR XML PATH(''), TYPE
).value('text()[1]', 'nvarchar(max)'), 1, LEN(', '), '') + '
FROM [aubeakon_scrm4].[acl_roles];
';
EXEC sp_executesql #TSQL1;
I am writing the following dynamic SQL, and getting an error around the FROM keyword.
Incorrect syntax near the keyword 'FROM'.
' + #columnList + '
FROM [History]
I know why, its because there shouldn't be a comma that precedes it. However, since the column before it (#columnList) is a result of dynamic SQL, how do I go about resolving this?
Basically, I need a way to make
SELECT #columnList =....
not append a comma at the end to the LAST column/Account selected.
The comma is added at the end at this part:
quotename(AccTbl.Account), ',',
Full Query:
DECLARE #sqlCommand NVARCHAR(MAX) = '',
#columnList NVARCHAR(MAX) = '',
#pivotColumns NVARCHAR(MAX) = '';
SELECT #columnList =
(SELECT DISTINCT concat(CHAR(9), 'COALESCE(', quotename(AccTbl.Account), ', 0)', quotename(AccTbl.Account), ',', CHAR(10)) --CHAR(9) & CHAR(10) for indentation/formatting
FROM [Accounts] AccTbl
WHERE AccTbl.Account NOT IN ('WS')
FOR XML Path(''), TYPE).value('(./text())[1]', 'NVARCHAR(MAX)');
SELECT #pivotColumns = STUFF(
(SELECT DISTINCT concat(CHAR(9), ',', quotename(AccTbl.Account), CHAR(10))
FROM [Accounts] AccTbl
WHERE AccTbl.Account NOT IN ('WS')
FOR XML Path(''), TYPE).value('(./text())[1]', 'NVARCHAR(MAX)'), 1, 1, '');
/*
EXEC the sqlCommand as separate batches to prevent this error: 'CREATE VIEW' must be the first statement in a query batch.
https://stackoverflow.com/a/39135516/8397835
*/
SET #sqlCommand = '
USE [ABC_DB]
--GO
DROP VIEW IF EXISTS [dbo].[Piv];
--GO
SET ANSI_NULLS ON
--GO
SET QUOTED_IDENTIFIER ON
--GO
';
Execute sp_executesql #sqlCommand;
SET #sqlCommand = '
CREATE VIEW [dbo].[Piv]
AS
(SELECT
[Style Code],
' + #columnList + '
FROM [History]
PIVOT (SUM([Value]) FOR [Accounts] IN (
' + #pivotColumns + '
)
)
AS Piv);
';
PRINT #sqlCommand;
Execute sp_executesql #sqlCommand;
In other words, whats happening right now is something like this:
UPDATE:
#columnList was fixed with leading comma instead of trailing comma, but leading comma nor trailing comma would work for #pivotColumns because we don't have a pre-existing column in the PIVOT part of the query like we do in the SELECT statement with Style Code.
Don't put the commas at the end, put them at the start, and then strip the first character, using STUFF, that's far easier in T-SQL.
So instead of {Expression} + ',' do ',' + {Expression}. Then you can simply do STUFF(#columnList,1,1,'') to remove the leading comma instead.
Part of the problem is your 'formatting' of the code. Generally I would agree that formatting the dynamic code can help in debugging - here it is getting in the way.
SELECT #columnList = STUFF(
(SELECT DISTINCT concat(', ', quotename(AccTbl.Account))
FROM [Accounts] AccTbl
WHERE AccTbl.Account NOT IN ('WS')
FOR XML Path(''), TYPE).value('(./text())[1]', 'NVARCHAR(MAX)'), 1, 1, '');
SELECT #pivotColumns = STUFF(
(SELECT DISTINCT concat(', ', quotename(AccTbl.Account))
FROM [Accounts] AccTbl
WHERE AccTbl.Account NOT IN ('WS')
FOR XML Path(''), TYPE).value('(./text())[1]', 'NVARCHAR(MAX)'), 1, 1, '');
Removing those - we see that both statements are exactly the same. Assume the results from the Accounts table are: Acct1, Acct2
You would get the result as '[Acct1], [Acct2]' for both #columnList and #pivotColumns. So - if you want to expand on the column list portion, for example add the table alias (which is what I would do):
SELECT #columnList = STUFF(
(SELECT DISTINCT concat(', ', 'h.', quotename(AccTbl.Account))
FROM [Accounts] AccTbl
WHERE AccTbl.Account NOT IN ('WS')
FOR XML Path(''), TYPE).value('(./text())[1]', 'NVARCHAR(MAX)'), 1, 1, '');
I would not bother with formatting these columns in the final result, since you will be recreating the view as needed using dynamic SQL.
SET #sqlCommand = '
CREATE VIEW [dbo].[Piv]
AS
(SELECT
h.[Style Code],
' + #columnList + '
FROM [History] h
PIVOT (SUM(h.[Value]) FOR [Accounts] IN (
' + #pivotColumns + '
)
)
AS Piv);
';
I am new here.
I have the fallowing data on a table:
And I need to get the fallowing result:
I am using the fallowing SQL query:
SQL Query
DECLARE #sql AS NVARCHAR(MAX)=''
DECLARE #cols AS NVARCHAR(MAX)=''
select #cols = STUFF((SELECT distinct ',' + QUOTENAME(Date)
FROM vRecords
ORDER BY ',' + QUOTENAME(Date)
FOR XML PATH(''), TYPE
).value('.', 'NVARCHAR(MAX)')
,1,1,'')
SET #sql = N'
SELECT EmpID, Name, ' + #cols + '
FROM (
select EmpID,Name,Date,Time
from vRecords
) a
PIVOT(COUNT(Time) FOR Date IN (' + #cols + ')) p'
EXECUTE(#sql)
What I need to accomplish is to know how many TIMES the user have a record on each DATE
But I am getting wrong result:
What am I doing wrong?
Sorry for all the links but because I am new I can't embed images.
I figured the issue.
All the problem was related to date format.
The columns were been generated with this format 2018-09-12 and the data was on this format 12/09/2018.
Any way, thanks for the comments.
I'm using a pivot command and I've got it producing the desired output as written below:
SET ANSI_NULLS ON
GO
SET QUOTED_IDENTIFIER ON
GO
SELECT Id, IssuedCN, [EmailAddress], [ServerHostName], [ManagerEmail]
FROM (SELECT Id, IssuedCN, StringValue, Name
FROM dbo.certmetadata) AS Source
PIVOT(
MAX(StringValue)
FOR Name IN ([EmailAddress], [ServerHostName], [ManagerEmail])
)
AS PvtTable_1;
But the pivoted table names are going to be user defined. The current ones, [EmailAddress] [ServerHostName] [ManagerEmail], will probably stay there but could be changed or even non-existent. The user defined names are stored in a table but I can't seem to figure out how, if possible, to bring them into the above code.
I'm using server 2012.
If that doesn't make sense let me know and I can try to provide more detail.
Thanks!
If you are going to have an unknown number of columns, then you will need to look at using dynamic SQL. The basic syntax will be similar to this:
DECLARE #cols AS NVARCHAR(MAX),
#query AS NVARCHAR(MAX)
-- get the list of columns
-- apply a filter on the columns here if needed
select #cols = STUFF((SELECT ',' + QUOTENAME(Name)
from dbo.certmetadata
group by name
order by name
FOR XML PATH(''), TYPE
).value('.', 'NVARCHAR(MAX)')
,1,1,'')
set #query = 'SELECT Id, IssuedCN,' + #cols + '
from
(
SELECT Id, IssuedCN, StringValue, Name
from dbo.certmetadata
) x
pivot
(
min(stringvalue)
for name in (' + #cols + ')
) p '
exec sp_executesql #query;
I am trying to generate an Pivot table with SQL (SQL Server 2008). To get the column list I am using stuff function which works great if we use it with SQL.
Although due to dynamic nature of Pivot structure (selection by user) I want to make column name set as a variable. I can catch correct SQL Stuff syntax but not able to execute it. Any Idea?
See code example as below:
Working Code:
DECLARE #cols AS NVARCHAR(MAX),
#query AS NVARCHAR(MAX)
select #cols = STUFF((SELECT distinct ',' + QUOTENAME(Station)
from #ResultCrosstab
FOR XML PATH(''), TYPE
).value('.', 'NVARCHAR(MAX)')
,1,1,'')
Select #cols
Not Working Code as below
Declare #ColumnName varchar(100)
set #ColumnName='Station'
DECLARE #cols1 AS NVARCHAR(MAX)
DECLARE #queryCol AS NVARCHAR(MAX)
set #queryCol='STUFF((SELECT distinct '','' + QUOTENAME(' + #ColumnName + ')
from #ResultCrosstab
FOR XML PATH(''), TYPE
).value(''.'', ''NVARCHAR(MAX)'')
,1,1,'''')'
Select #queryCol
Select #cols1=(#queryCol)
Not Working code returns the sql query itself rather than result.
Any Idea or suggestions?
Cheers
Hardeep
Execute the query rather than select it. Select #queryCol will return the value of #queryCol
Select #cols1=(#queryCol) will put the value of #queryCol into #cols1
You will need to EXEC SP_EXECUTESQL(#queryCol) or EXEC(#queryCol) to execute the actual query