SQL Server: Update, set a value that is within another select - sql

Question

I have the following query:
update UpdCmmPartnerArticleGroup
set IsActive = 1,
Name = a.GroupName
from
(
select t.Name as GroupName
from #ArticleGroupsTable t
left join UpdCmmPartnerArticleGroup s on s.PartnerID=t.PartnerID and s.Name=t.Name
where s.PartnerID is null
) a
where Name = '' and IsActive = 0
It's purpose is to take a list of GroupNames and assign them to the UpdCmmPartnerArticleGroup.Name field. The list has 8 values and it uses only the first and the last to update.
What am I doing wrong, it looks pretty straight forward, but it's behavior is strange.

Answer 1

You can use a little bit simplified version.
UPDATE u
SET IsActive = 1, Name = t.Name
FROM #ArticleGroupsTable t
LEFT JOIN UpdCmmPartnerArticleGroup u
ON u.PartnerID=t.PartnerID AND u.Name=t.Name
WHERE u.Name = '' and u.IsActive = 0 and u.PartnerID IS NULL

Answer 2

Why not use subquery
update s
set IsActive = 1,
Name = (select t.Name from #ArticleGroupsTable t WHERE s.PartnerID=t.PartnerID and s.Name=t.Name AND s.PartnerID is null)
from UpdCmmPartnerArticleGroup s
where Name = '' and IsActive = 0

Answer 3

Try this,
UPDATE s
SET s.IsActive = 1
,s.NAME = t.NAME
FROM #ArticleGroupsTable t
LEFT JOIN UpdCmmPartnerArticleGroup s ON s.PartnerID = t.PartnerID
AND s.NAME = t.NAME
WHERE s.PartnerID IS NULL
AND s.NAME = ''
AND s.IsActive = 0

Answer 4

Try this:
IF OBJECT_ID('tempdb..#UpdCmmPartnerArticleGroup') IS NOT NULL
DROP TABLE #UpdCmmPartnerArticleGroup;
IF OBJECT_ID('tempdb..#ArticleGroupsTable') IS NOT NULL
DROP TABLE #ArticleGroupsTable;
CREATE TABLE #UpdCmmPartnerArticleGroup
(
PartnerId INT IDENTITY(1, 1)
,Name VARCHAR(50)
,IsActive BIT
);
INSERT INTO [#UpdCmmPartnerArticleGroup]
( [Name], [IsActive] )
VALUES ( 'Test1' -- Name - varchar(50)
, 1 -- IsActive - bit
),
( 'Test2' -- Name - varchar(50)
, 0 -- IsActive - bit
),
( '' -- Name - varchar(50)
, 0 -- IsActive - bit
);
CREATE TABLE #ArticleGroupsTable
(
PartnerId INT
,Name VARCHAR(50)
);
INSERT INTO [#ArticleGroupsTable]
( [PartnerId], [Name] )
VALUES ( 1, 'Test1' ),
( 2, 'Test2' ),
( 4, 'Test4' );
SELECT *
FROM [#UpdCmmPartnerArticleGroup];
SELECT *
FROM [#ArticleGroupsTable];
UPDATE [#UpdCmmPartnerArticleGroup]
SET [IsActive] = 1
, [Name] = (
SELECT t.[Name] AS GroupName
FROM [#ArticleGroupsTable] t
LEFT JOIN [#UpdCmmPartnerArticleGroup] s
ON [s].[PartnerId] = [t].[PartnerId]
AND [s].[Name] = [t].[Name]
WHERE [s].[PartnerId] IS NULL
)
WHERE [#UpdCmmPartnerArticleGroup].[Name] = ''
AND [IsActive] = 0;
SELECT *
FROM [#UpdCmmPartnerArticleGroup];