VBA Sum up values in row based on condition - vba

Question

I need to write a VBA code based on conditions:
-if orders have the same value in column D, column F, column P and column P = unit then sum up values in column Q; if column P=amount then sum up values in column S.
Dim lastrow1 As Long
Dim startrow As Long
Dim Cumulative As Variant
Dim y As Long
With Wb2.Worksheets.Item(1)
lastrow1 = Cells.Find("*", SearchOrder:=xlByRows, SearchDirection:=xlPrevious).Row
Cumulative = 0
startrow = 4 'Row where your data starts + 1, so row 3 + 1 in this case
For y = startrow To lastrow1
If Range("P" & y - 1).Value = "Unit" Then
Cumulative = Cumulative + Range("Q" & y - 1).Value
If Range("F" & y).Value = Range("F" & y - 1).Value And Range("D" & y).Value = Range("D" & y - 1).Value And Range("P" & y).Value = Range("P" & y - 1).Value Then
Range("Q" & y - 1 & .Rows.Count).End(xlUp).Value = Cumulative
Cumulative = 0
End If
ElseIf Range("P" & y - 1).Value = "Amount" Then
Cumulative = Cumulative + Range("S" & y - 1).Value
If Range("F" & y).Value = Range("F" & y - 1).Value And Range("D" & y).Value = Range("D" & y - 1).Value And Range("P" & y).Value = Range("P" & y - 1).Value Then
Range("S" & y - 1 & .Rows.Count).End(xlUp).Value = Cumulative
Cumulative = 0
End If
End If
Next y
End With
But the code doesn't work, I got the range object error 1004 in line Range("S" & y - 1 & .Rows.Count).End(xlUp).Value = Cumulative.
Where is the problem in my code?

Answer 1

This is wrong Range("S" & y - 1 & .Rows.Count).End(xlUp).Value = Cumulative
It evaluates to something like for example S9:1048576 , which will throw error 1004.
Change it to :
Range("S" & y - 1 & ":S" & .Rows.Count).End(xlUp).Value = Cumulative