Update statement in JdbcBatchItemWriter - sql

Question

I am not able to update the database table correctly using JdbcBatchItemWriter. Below is the code fragment. insert on an empty table is getting correct response but update is not happening on input table.
<bean id="odbWriter" class="org.springframework.batch.item.database.JdbcBatchItemWriter">
<property name="dataSource" ref="dataSource"></property>
<property name="sql">
<value>
<![CDATA[
update employeethree set salary = :salary, designation = :designation, promotioneligibility = :promotionEligibility
]]>
</value>
</property>
<property name="itemSqlParameterSourceProvider">
<bean
class="batchjobreaddb.CustomBeanPropertyItemSqlParameterSourceProvider" />
</property>
If i change the query inside CDATA to :
insert into employeetwo values(:empId, :empName, :dept , :salary, :designation, :experienceInMonths, :promotionEligibility)
then it's getting me the desired results. (EmployeeTwo has same structure but is empty.)
Please help. Thanks :)

Answer 1

Your UPDATE query has no WHERE clause. How are you to know which record to update?
For proper update behavior, you must specify a WHERE clause that properly identifies the record(s) you wish to modify with the UPDATE query.
This is obviously not necessary with an INSERT query, because you are creating a brand new record and not modifying an existing one.
Assuming from your example INSERT query that the employee id field is empid, try modifying your JdbcBatchItemWriter to set the sql value to:
<property name="sql">
<value>
<![CDATA[
UPDATE employeethree
SET salary = :salary,
designation = :designation,
promotioneligibility = :promotionEligibility
WHERE empid = :empId
]]>
</value>
</property>