incorrect syntax near the keyword 'end'. sql [closed] - sql

Question

Closed. This question is not reproducible or was caused by typos. It is not currently accepting answers.
This question was caused by a typo or a problem that can no longer be reproduced. While similar questions may be on-topic here, this one was resolved in a way less likely to help future readers.
Closed 6 years ago.
Improve this question
ALTER procedure [dbo].[proc_PostVisitCountInsert](
#postCount bigint,
#postID bigint)
as
Begin
if not exists(select * from PostVisitCount where postID=#postID)
Begin
Insert into PostVisitCount(postcount,postID) values(#postCount, #postID)
end
else
Begin
--Query for Update PostVisitCount
Declare #count bigint
Set #count=(select postcount from PostVisitCount where postID=#postID)
Update PostVisitCount set postcount=(#count+1), postID=#postID
End
end --Error getting at this place
When I try to execute the query, I'm getting error with these query. I don't understand what is wrong with this query any one helps me to figure out what did I do wrong.

Answer 1

The Begin End for ELSE does not contain any statement (it is actually commented out). That is the reason for the error. The following will work
ALTER procedure [dbo].[proc_PostVisitCountInsert](
#postCount bigint,
#postID bigint)
as
Begin
if not exists(select * from PostVisitCount where postID=#postID)
Begin
Insert into PostVisitCount(postcount,postID) values(#postCount, #postID)
end
else
Begin
Query for Update PostVisitCount
End
end --Error getting at this place

Answer 2

#user6503334: I am not sure whether my post would fix your issue but you can change the "else" part like the below since I felt there is something logically missing in your update statement. I have done a couple of changes in the else part. You should add where clause otherwise all the rows would be updated.
ALTER PROCEDURE [dbo].[proc_PostVisitCountInsert] (
#postCount BIGINT
,#postID BIGINT
)
AS
BEGIN
IF NOT EXISTS (
SELECT 1
FROM PostVisitCount
WHERE postID = #postID
)
BEGIN
INSERT INTO PostVisitCount (
postcount
,postID
)
VALUES (
#postCount
,#postID
)
END
ELSE
BEGIN
--Query for Update PostVisitCount
DECLARE #count BIGINT
SET #count = (
SELECT sum(postcount) + 1
FROM PostVisitCount
WHERE postID = #postID
)
UPDATE PostVisitCount
SET postcount = #count
WHERE postID = #postID
END
END

Answer 3

Since the one valid answer was given in a comment and not everybody reads those, the script should look like this:
ALTER procedure [dbo].[proc_PostVisitCountInsert](
#postCount bigint,
#postID bigint
)
as
Begin
if not exists (select *
from PostVisitCount
where postId = #postId)
Begin
insert into PostVisitCount(postcount,postID) values(#postCount, #postID)
end
else
Begin
--Query for Update PostVisitCount
update PostVisitCount set postcount = postcount + 1 where postID = #postID
End
end

Answer 4

Probably this should work.
ALTER procedure [dbo].[proc_PostVisitCountInsert](
#postCount bigint,
#postID bigint)
as
Begin
if not exists(select * from PostVisitCount where postID=#postID)
Insert into PostVisitCount(postcount,postID) values(#postCount, #postID)
else
--Query for Update PostVisitCount
end --Error getting at this place