SQL - Split One Table to Two And Link - sql

Question

I am using SQL Server 2014. I looked up solution by Joel Coehoorn for this question but it did not work for me.
I have a table for clients which I renamed to Aac_Client which has both client information and address information as columns. I want to move Address to a new table Address to organise things and keep other remaining things at Ac_Client. I am trying to do the following:
Note the relationship between Address and Client is One to One.
BEGIN TRANSACTION
DECLARE #DataID int;
-- Insert Address
INSERT INTO Address ([StreetNumber],[StreetName] ,[StreetAddress2] ,[Unit] ,[City] ,[State] ,[Zip] ,[County])
SELECT [StreetNumber], [StreetName], [StreetAddress2], [Unit] ,[City] ,[State] ,[Zip] ,
NULL AS [County]
FROM Aac_Client
-- Get Address Id
SELECT #DataID = scope_identity();
-- Insert Client
INSERT INTO Ac_Client ( AddressId, Name, Phone, Contact )
SELECT #DataID AS AddressId, Name , Phone, Contact FROM Aac_Client
COMMIT
But the problem is INSERT is carried at once and I get the last ID of address in SELECT #DataID = scope_identity();

Answer 1

BEGIN TRANSACTION
IF OBJECT_ID('tempdb..#InsertedAddresses') IS NOT NULL
BEGIN
DROP TABLE #InsertedAddresses
END
CREATE TABLE #InsertedAddresses (
AddressId INT
,ClientId INT
)
DECLARE #DataID int;
-- add a unique client identifier
-- Insert Address
INSERT INTO Address ([StreetNumber],[StreetName] ,[StreetAddress2] ,[Unit] ,[City] ,[State] ,[Zip] ,[County], [ClientId])
OUTPUT INSERTED.AddressId, INSERTED.ClientId (AddressId, ClientId)
SELECT [StreetNumber], [StreetName], [StreetAddress2], [Unit] ,[City] ,[State] ,[Zip] ,
NULL AS [County]
FROM Aac_Client
-- Insert Client
INSERT INTO Ac_Client ( AddressId, Name, Phone, Contact, ClientId)
SELECT i.AddressId, Name , Phone, Contact, c.ClientId
FROM Aac_Client c
INNER JON #InsertedAddresses i
ON c.ClientId = i.ClientId
COMMIT
use the output clause of the first insert statement into a temp table. Also is it possible that clients will have more than one address? Or more then 1 client at the same address? If so you might want to consider putting the AC_Client ID in the address table instead of the address_id in the client table. Also if you are not worried about changing addresses independently in the case of multiple clients at same address you could consider a 3rd table to relate addresses and clients so you don't have to repeat addresses or clients to create a many to many relationship.
I guess to expand scope_identity is a scalar value meaning only 1 value is held and it is the identity of the last row altered in the scope. In your case you need all of the ids so you need to use the output clause.

Answer 2

--Add the following Columns that you can later Drop
ALTER TABLE [Address] ADD Col_GUID UNIQUEIDENTIFIER;
ALTER TABLE [Aac_Client] ADD Col_GUID UNIQUEIDENTIFIER;
GO
-- Give a Unique value to each row.
UPDATE [Aac_Client] SET Col_GUID = NEWID();
BEGIN TRANSACTION;
-- Table variable to capture newly generated Identity values
Declare #NewID TABLE (AddressId INT, Col_GUID UNIQUEIDENTIFIER)
-- Insert Address (with output clause to get the Identity values)
INSERT INTO [Address] ([StreetNumber],[StreetName] ,[StreetAddress2]
,[Unit] ,[City] ,[State] ,[Zip] ,[County], Col_GUID)
OUTPUT Inserted.AddressId , Inserted.Col_GUID INTO #NewID (AddressId , Col_GUID)
SELECT [StreetNumber], [StreetName], [StreetAddress2]
,[Unit] ,[City] ,[State] ,[Zip] , NULL AS [County] , Col_GUID
FROM Aac_Client
-- Insert Client joining with the Table variable on the guid column to
-- to get the new Identity values.
INSERT INTO Ac_Client ( AddressId, Name, Phone, Contact )
SELECT N.AddressId, a.Name , a.Phone, a.Contact
FROM Aac_Client a
INNER JOIN #NewID N ON n.Col_GUID = a.Col_GUID
COMMIT TRANSACTION;
Finally you can drop the Columns you added for this purpose.
ALTER TABLE [Address] DROP COLUMN Col_GUID;
ALTER TABLE [Aac_Client] DROP COLUMN Col_GUID;