I am having trouble Echoing variables-Batch - variables
So basically, all these variables are set to the PLUS symbol ( + )
Echo %1,10% %2,10% %3,10% %4,10% %5,10% %6,10% %7,10% %8,10% %9,10% %10,10%
Echo %1,9% %2,9% %3,9% %4,9% %5,9% %6,9% %7,9% %8,9% %9,9% %10,9%
Echo %1,8% %2,8% %3,8% %4,8% %5,8% %6,8% %7,8% %8,8% %9,8% %10,8%
Echo %1,7% %2,7% %3,7% %4,7% %5,7% %6,7% %7,7% %8,7% %9,7% %10,7%
Echo %1,6% %2,6% %3,6% %4,6% %5,6% %6,6% %7,6% %8,6% %9,6% %10,6%
Echo %1,5% %2,5% %3,5% %4,5% %5,5% %6,5% %7,5% %8,5% %9,5% %10,5%
Echo %1,4% %2,4% %3,4% %4,4% %5,4% %6,4% %7,4% %8,4% %9,4% %10,4%
Echo %1,3% %2,3% %3,3% %4,3% %5,3% %6,3% %7,3% %8,3% %9,3% %10,3%
Echo %1,2% %2,2% %3,2% %4,2% %5,2% %6,2% %7,2% %8,2% %9,2% %10,2%
Echo %1,1% %2,1% %3,1% %4,1% %5,1% %6,1% %7,1% %8,1% %9,1% %10,1%
but for some reason, this is the output:
,102,103,104,105,106,107,108,109,1010,10
,92,93,94,95,96,97,98,99,910,9
,82,83,84,85,86,87,88,89,810,8
,72,73,74,75,76,77,78,79,710,7
,62,63,64,65,66,67,68,69,610,6
,52,53,54,55,56,57,58,59,510,5
,42,43,44,45,46,47,48,49,410,4
,32,33,34,35,36,37,38,39,310,3
,22,23,24,25,26,27,28,29,210,2
,12,13,14,15,16,17,18,19,110,1
Could someone explain to me what's going on because I have no clue
(I did verify with the set command that the variables were set to the + symbol and they were)
Avoid starting variable names with a number, this will avoid the
variable being mis-interpreted as a parameter
Read Windows Environment Variables as well:
Variables have a percent sign on both sides: %ThisIsAVariable%
The variable name can include spaces, punctuation and mixed case:
%_Another Ex.ample% (This is unlike Parameter variables
which only have one % sign and are always one character long: %A,
%1 )
For instance, your first line:
Echo %1,10% %2,10% %3,10% %4,10% %5,10% %6,10% %7,10% %8,10% %9,10% %10,10%
rem ↑↑↑ ↑↑↑ ↑↑↑ ↑↑↑ ↑↑↑ ↑↑↑ ↑↑↑ ↑↑↑ ↑↑↑
rem % % = invalid variable name
rem nonexistent variables are evaluated to an empty string in batch script
rem ↑↑
rem %1 = the 1st command line parameter supplied to a batch script
rem evaluates to an empty string if no parameter is supplied
rem an isolated % percent sign is ignored ↑
evaluates to ,102,103,104,105,106,107,108,109,1010,10
Required reading (entire thread): How does the Windows Command Interpreter (CMD.EXE) parse scripts?
JosefZ did a good job explaining what is happening in his answer.
I have a couple more points just to further your understanding.
Batch parameters like %1 are only available within batch scripts. The command line has a slightly different parser that knows nothing about batch parameters. So your code will work as you intended if you enter the commands directly on the command line.
You can get your code to work as originally intended within a batch script if you enable delayed expansion:
#echo off
setlocal enableDelayedExpansion
Echo !1,10! !2,10! !3,10! !4,10! !5,10! !6,10! !7,10! !8,10! !9,10! !10,10!
Echo !1,9! !2,9! !3,9! !4,9! !5,9! !6,9! !7,9! !8,9! !9,9! !10,9!
Echo !1,8! !2,8! !3,8! !4,8! !5,8! !6,8! !7,8! !8,8! !9,8! !10,8!
Echo !1,7! !2,7! !3,7! !4,7! !5,7! !6,7! !7,7! !8,7! !9,7! !10,7!
Echo !1,6! !2,6! !3,6! !4,6! !5,6! !6,6! !7,6! !8,6! !9,6! !10,6!
Echo !1,5! !2,5! !3,5! !4,5! !5,5! !6,5! !7,5! !8,5! !9,5! !10,5!
Echo !1,4! !2,4! !3,4! !4,4! !5,4! !6,4! !7,4! !8,4! !9,4! !10,4!
Echo !1,3! !2,3! !3,3! !4,3! !5,3! !6,3! !7,3! !8,3! !9,3! !10,3!
Echo !1,2! !2,2! !3,2! !4,2! !5,2! !6,2! !7,2! !8,2! !9,2! !10,2!
Echo !1,1! !2,1! !3,1! !4,1! !5,1! !6,1! !7,1! !8,1! !9,1! !10,1!
But... even though you can technically use variable names that begin with a digit, I strongly advise that you should not do this.
Related
Variable set in batch file won't show
When I do this in Notepad, the command prompt doesn't show ping %ip% -t -l %package%, but it shows ping %ip% -t -l and doesn't show the package variable. #echo off set data=0 set package = -600 IF %data% == 0 ( set /a package= %package% + 1600 #echo ping %ip% -t -l %package% ) echo %package% pause What am I doing wrong?
Batch is sensitive to spaces in a SET statement. SET FLAG = N sets a variable named "FLAGSpace" to a value of "SpaceN" The set "var=value" syntax ensures that any trailing spaces on the batch line are not included in the value assigned to var. Within a block statement (a parenthesised series of statements), the entire block is parsed and then executed. Any %var% within the block will be replaced by that variable's value at the time the block is parsed - before the block is executed - the same thing applies to a FOR ... DO (block). Hence, IF (something) else (somethingelse) will be executed using the values of %variables% at the time the IF is encountered. Two common ways to overcome this are 1) to use setlocal enabledelayedexpansion and use !var! in place of %var% to access the changed value of var or 2) to call a subroutine to perform further processing using the changed values. Note therefore the use of CALL ECHO %%var%% which displays the changed value of var. So: #echo off SETLOCAL ENABLEDELAYEDEXPANSION set /A data=0 set /A package=-600 IF %data% == 0 ( set /a package=!package!+1600 echo ping %ip% -t -l !package! ) echo %package% pause Noting: The setlocal statement should normally be placed at the start of the code. Your posted code is evidently a snip, since you do not appear to be setting ip. Spaces are irrelevant in a set /a but even so, removing them fosters a habit Set /a uses the run-time value, not the parse-time value of var when the syntax set /a var=var+1 is used within a loop, so set /a var=var+1 and set /a var=!var!+1 are equivalent but set /a var=%var%+1 uses the value of var at the time the loop is parsed. Since echoing is set to off by the initial statement, the leading # on the second echo is redundant.
Create a database within a bat file
I am trying to create a bat file that is in essence a database. I want to be able to enter information that is tied to a single record. When I enter a record, I want to be able to look up the record by the card number assigned to it. The code I have now doesn't really work due to the fact that the variables are not being stored properly. This is my code: Color 5F #echo off :start cls echo ========================================== echo Gift Card echo ========================================== echo. echo What would you like to do? echo. echo 1 Add Card echo 2 Check Information echo 3 Edit Card Balance echo 4 Delete Card echo. set /p choice=Please enter choice: if /I %choice%==1 goto 1 if /I %choice%==2 goto 2 :1 echo. set /p var=Enter Card Number: set /p val=Enter Amount: set /p fname=Enter First Name: set /p lname=Enter Last Name: set /p cbal=Enter Current Balance: set /p diss=Enter Date issued: #echo set %var%=%val%=%fname%=%lname%=%cbal%=%diss% > %var%.bat echo. echo The data has been stored! pause goto start :2 echo. set /p var=Please enter card number: setlocal enabledelayedexpansion call %var%.bat echo !%fname%! !%lname%!'s !%var%! card has $!%cbal%! on it as of !%diss%!! pause > nul goto start I have tried to send the variables separately and altogether and none have worked. I am thinking it is because I do not have the delayed expansion sytax correct. Any help is very appreciated!
Your problem seems to lie where you generate the batch file to fill the variables... You generate only one line, which does not actually assign anything to any of the variables you need. Try changing #echo set %var%=%val%=%fname%=%lname%=%cbal%=%diss% > %var%.bat to be #echo set var=%var% > %var%.bat #echo set val=%val% >> %var%.bat #echo set fname=%fname% >> %var%.bat #echo set lname=%lname% >> %var%.bat #echo set cbal=%cbal% >> %var%.bat #echo set diss=%diss% >> %var%.bat This should allow your variables to be loaded back properly. Also, change echo !%fname%! !%lname%!'s !%var%! card has $!%cbal%! on it as of !%diss%!! to read echo %fname% %lname%'s %var% card has $%cbal% on it as of %diss%! You should never use both ! and % to surround variables in a batch file, only one or the other. % should be used in most cases; ! should be used when you need to read a variable inside a multi-line "code block" (for example, the result of an if statement or the body of a for loop) which is surrounded by parentheses. Some more advice: You can put setlocal delayedexpansion just once in the beginning of the file, right after #echo off. However, you are not doing anything in this program (yet, at least) to need delayed expansion. Delayed expansion is used to enable accessing variables with the ! symbol and is only useful inside multi-line statement bodies surrounded by parentheses. Because of that, you should get rid of it completely unless/until you actually need it, as it can cause other problems. There is no need for the "#" symbol in any command after you call #echo off (but it won't break anything). The # symbol simply suppresses echoing of the command which it precedes, but it is redundant because all commands are silenced by default after you call echo off. For this reason, it is important to only use it on the first line when calling #echo off, so that the user does not see that command echoed.
How to store variables within variables in Batch?
I am trying to store a concatenated set of variables into a newly SET variable. When I add a variable into another variable it doesn't seem to actually get set correctly. I'm curious if BATCH can store variables within variables, or if I have to do formatting beyond what I currently have: Example: The 'oldDirectory' variable should display the same thing as "%progdata%\%datetime%" #echo off For /f "tokens=2-4 delims=/ " %%a in ("%DATE%") do ( SET YYYY=%%c SET MM=%%a SET DD=%%b ) For /f "tokens=1-3 delims=/:." %%a in ("%TIME%") do ( SET HH24=%%a SET MI=%%b SET SS=%%c ) SET datetime=%YYYY%%MM%%DD%_%HH24%%MI%%SS% SET progdata=C:\ProgramData #echo on IF EXIST "%progdata%" ( echo Found %progdata% SET oldDirectory="%progdata%\%datetime%" echo %oldDirectory% ) pause
try with : CALL SET oldDirectory="%progdata%\%datetime%" CALL ECHO %oldDirectory%
First method: IF EXIST "%progdata%" ( echo Found %progdata% SET oldDirectory="%%progdata%%\%%datetime%%" call echo %oldDirectory% ) Second method: IF EXIST "%progdata%" ( echo Found %progdata% SET oldDirectory="!progdata!\!datetime!" setlocal EnableDelayedExpansion echo %oldDirectory% ) An interesting point is that echo %oldDirectory% command display the current value of progdata and datetime variables with the same value of oldDirectory! EDIT: Example added #echo off set progdata=C:\ProgramData echo First method: SET oldDirectory="%%progdata%%\%%date:/=%%_%%time::=%%" call echo %oldDirectory% echo Second method: SET oldDirectory="!progdata!\!date:/=!_!time::=!" setlocal EnableDelayedExpansion echo %oldDirectory% Output: First method: "C:\ProgramData\14082013_211303.20" Second method: "C:\ProgramData\14082013_211303.21"
You have a standard DELAYED EXPANSION problem, discussed endlessly on SO. When batch encounters a "Block statement" - that is typically a parenthesised statement spread over many lines such as your IF EXIST then the entire statement is parsed through to the closing parenthesis AND at this time, ANY %var% is replaced by the value of that variable as it stands WHEN THE STATEMENT IS PARSED Consequently, your ECHO %olddirectory% is replaced by ECHO since olddirectory has no value AT PARSE TIME and executing ECHO will report ECHO is On/Off progdata on the other hand IS set at parse-time and hence echo Found %progdata% is replaced by echo Found C:\ProgramData The very simplest cure is to move the ECHO statement outside of the block IF EXIST "%progdata%" ( echo Found %progdata% SET oldDirectory="%progdata%\%datetime%" ) echo Olddirectory=%oldDirectory% (I added the olddirectory= so that the echo statement finds something to echo if olddirectory is not set) The second easiest way to display the value is IF EXIST "%progdata%" ( echo Found %progdata% SET oldDirectory="%progdata%\%datetime%" CALL echo %%oldDirectory%% ) Here, the ECHO command is not expanded in the context of the IF, but in the context of the CALL which acquires its environment from the run-time value of the IF context. The third easiest way to display the value is by using the delayedexpansion option of a setlocal command. An NT batch command traditionally starts #echo off setlocal which suppresses echoing and establishes a local environment. Any changes to the local environment are backed out when an endlocal or end-of-file is reached in the setlocal's context. If this mantra is consistently followed, we don't get the situation where a variable is established by one batch and the environment is 'dirty' for the next. Consider running your original twice within the same cmd session. progdata, and all of the other variables you are establishing would remain set for the second coming - and hence olddirectory may be set by your first invocation, and retain that stale data if for some reason it's not EXPLICITLY set in the second. setlocal backs all those changes out for you. setlocal enabledelayedexpansion adds an extra facility to the mix. Whereas %var% is resolved to the PARSE-TIME value of var, if delayedexpansion has been invoked then !var! is resolved to the RUN-TIME value - as it changes in a FOR loop... Hence, adding SETLOCAL ENABLEDELAYEDEXPANSION at a strategic point (after the #echo off until you're off your training wheels...) would allow you to make a simple change to the display of olddirectory IF EXIST "%progdata%" ( echo Found %progdata% SET oldDirectory="%progdata%\%datetime%" echo !oldDirectory! )
capturing CMD batch file parameter list; write to file for later processing
I have written a batch file that is launched as a post processing utility by a program. The batch file reads ~24 parameters supplied by the calling program, stores them into variables, and then writes them to various text files. Since the max input variable in CMD is %9, it's necessary to use the 'shift' command to repeatedly read and store these individually to named variables. Because the program outputs several similar batch files, the result is opening several CMD windows sequentially, assigning variables and writing data files. This ties up the calling program for too long. It occurs to me that I could free up the calling program much faster if maybe there's a way to write a very simple batch file that can write all the command parameters to a text file, where I can process them later. Basically, just grab the parameter list, write it and done. Q: Is there some way to treat an entire series of parameter data as one big text string and write it to one big variable... and then echo the whole big thing to one text file? Then later read the string into %n variables when there's no program waiting to resume? Parameter list is something like 25 - 30 words, less than 200 characters. Sample parameter list: "First Name" "Lastname" "123 Steet Name Way" "Cityname" ST 12345 1004968 06/01/2010 "Firstname+Lastname" 101738 "On Account" 20.67 xy-1z 1 8.95 3.00 1.39 0 0 239 8.95 Items in quotes are processed as string variables. List is space delimited. Any suggestions?
echo %* 1>args.txt %* references all arguments: %1 %2 %3... It also works with subroutines. call :test 1 2 3 goto :eof :test echo 1: %1 echo 2: %2 echo 3: %3 echo *: %* exit /b output: 1: 1 2: 2 3: 3 *: 1 2 3 See the following website for more information: http://ss64.com/nt/syntax-args.html
Interesting Post. It sparked my interest. I too am needing something that could accept parameters and although this probably isn't useful to you now I thought it might be useful at some later date. My solution is less simple - because there just isn't an elegant way to do it. Basically, in this example the "-" can be used to identify a parameter, and the next space is assumed to be set to a value. Legal Stuff: So this is all my code and I don't really care how or where you choose to use it. No need to cite me it's just an example anyway. Like this: Microsoft Batch:Begin Copy below and save as filename.bat #ECHO OFF REM USAGE: this-batch-name.bat -BUILD "1.2.3 build 405" -JOB "Running This Job" -run RUN_FUNCTION SET __CURRENT_WORKING_DIRECTORY__=%~dp1 ECHO.__CURRENT_WORKING_DIRECTORY__=%__CURRENT_WORKING_DIRECTORY__% REM # Clear Previous Variables SET PACKAGING_BUILD_NUMBER= SET PACKAGING_JOB_NAME= SET GO_DEEPER= SET RUN_COMMAND= REM ## In order to read variables set while in a "FOR" loop REM ## you have to set the 'ENABLEDELAYEDEXPANSION' with 'SETLOCAL'. SETLOCAL ENABLEEXTENSIONS SETLOCAL ENABLEDELAYEDEXPANSION REM ## Capture Command line parameters here with a %* FOR %%A IN (%*) DO ( REM ## If we found something with a '-' in previous pass run GO_DEEPER will be defined and thus set to the command line argument. IF DEFINED GO_DEEPER ( REM ## When ENABLEDELAYEDEXPANSION is Set with setlocal command you have to use exclamation: i.e. '^!' IF /I "-BUILD"=="!GO_DEEPER!" SET PACKAGING_BUILD_NUMBER=%%A IF /I "-JOB"=="!GO_DEEPER!" SET PACKAGING_JOB_NAME=%%A IF /I "-RUN"=="!GO_DEEPER!" SET RUN_COMMAND=%%A SET SET GO_DEEPER= ) IF /I "%%A" GEQ "-" ( REM ## Wow we found your command line argument that started with a '-' so set the GO_DEEPER Var SET GO_DEEPER=%%A ) ELSE ( SET SET GO_DEEPER= ) ) REM ## Time to grab the variables set while in delayed expansion mode ENDLOCAL && SET PACKAGING_BUILD_NUMBER=%PACKAGING_BUILD_NUMBER% && SET PACKAGING_JOB_NAME=%PACKAGING_JOB_NAME% && SET RUN_COMMAND=%RUN_COMMAND% REM ## Sucks, but you have to clear the '"' and "'" if it exists. IF DEFINED RUN_COMMAND ( SET RUN_COMMAND=%RUN_COMMAND:"=% SET RUN_COMMAND=%RUN_COMMAND:'=% ) IF DEFINED PACKAGING_JOB_NAME ( SET PACKAGING_JOB_NAME=%PACKAGING_JOB_NAME:"=% SET PACKAGING_JOB_NAME=%PACKAGING_JOB_NAME:'=% ) IF DEFINED PACKAGING_BUILD_NUMBER ( SET PACKAGING_BUILD_NUMBER=%PACKAGING_BUILD_NUMBER:"=% SET PACKAGING_BUILD_NUMBER=%PACKAGING_BUILD_NUMBER:'=% ) REM ## Now we can try to run the command function if the -run was used... IF DEFINED RUN_COMMAND ( CALL:--%RUN_COMMAND% "'%PACKAGING_JOB_NAME%'","'%PACKAGING_BUILD_NUMBER%'" ) ELSE ( ECHO Try running: ECHO %0 -BUILD "1.2.3 build 405" -JOB "Running This Job" -run RUN_FUNCTION ) GOTO DONE :--RUN_FUNCTION ECHO running... %~0 SET VARPASSED1=%~1 SET VARPASSED2=%~2 IF DEFINED VARPASSED1 ECHO VARPASSED1 was %VARPASSED1% IF DEFINED VARPASSED2 ECHO VARPASSED2 was %VARPASSED2% ECHO Add your code to process here... GOTO:EOF :DONE ECHO We got the following results... IF DEFINED PACKAGING_JOB_NAME ECHO PACKAGING_JOB_NAME=%PACKAGING_JOB_NAME% IF DEFINED PACKAGING_BUILD_NUMBER ECHO PACKAGING_BUILD_NUMBER=%PACKAGING_BUILD_NUMBER% IF DEFINED RUN_COMMAND ECHO RUN_COMMAND=%RUN_COMMAND% </pre> </code> Microsoft Batch END Copy RESULTS: __CURRENT_WORKING_DIRECTORY__=C:\dev\a\win\sysprep\ running... :--RUN_FUNCTION VARPASSED1 was "'Running...'" VARPASSED2 was "'This...'" We got the following results... PACKAGING_JOB_NAME="Running This Job" PACKAGING_BUILD_NUMBER="1.2.3 build 405" RUN_COMMAND=RUN_FUNCTION
Removing double quotes from variables in batch file creates problems with CMD environment
Can anybody help with effective and safe way of removing quotes from batch variables? I have written a batch file which successfully imports a list of parameters %1, %2, %3 etc. and places them into named variables. Some of these parameters contain multiple words, and therefor are enclosed in double quotes. > "Susie Jo" (%1) > "Smith Barnes" (%2) > "123 E. Main St." (%3) These %variables are next placed in named variables: > set FirstName=%1 > set LastName=%2 > set ShipAddr=%3 verification of variables is done by echo. > echo.%FirstName% > echo.%LastName% > echo.%ShipAddr% results display as "Susie Jo" "Smith Barnes" "123 E. Main St." I need to eliminate the included quotes on selected variables. For instance, FirstName and LastName are used elsewhere and must not include quotes. In a test batch file I was successful at eliminating quotes using the ~tilde character in variables. > set FirstName=%~1 > set LastName=%~2 I thought I had the solution, but I soon experienced unusual behavior with execution of batch files. Suddenly CMD is no recognizing long path statments. Normal execution of batch file from full path > C:\Documents and Settings\Administrator\My Documents\Txt\batchtest\dataout.bat returns > 'C:\Documents' is not recognized as an internal or external command.... So it would appear that the addition of the ~tilde character to the in-coming %1 %2...%n variables has caused some change. Possibly some environment variables have been altered? I also tried clearing quotes from within variable with various attempts using the FOR command. That seems awkward and I have been unable to learn how to accomplish this by creating a list of variable to perform the task: something like this: for %%g in (%FirstName% %LastName%) do ( set %%g=%%~g set %%h=%%~h set FirstName=%%~g set LastName=%%h echo.%FirstName% %LastName% ) I think I have two issues. My 'short and sweet' idea of inserting ~tilde in the incoming %1 %2 variables (%~1, etc) seems to have affected some settings and altered how CMD navigates long pathnames. I'm still in search of a clean and easy way to eliminate quotes from selected named variables. Any help for those more experienced would be most appreciated. I'm at the end of my skills here... need some guidance please! edit 12/26/2009 13:36 PST entire batch file: :: dataout.bat :: revision 12/25/2009 add ~tilde to incoming %variables to eliminate embedded "quotation marks. :: writes address list using command line parameters :: writes data output list for QBooks IIF import :: writes Merchant Order data for RUI :: sample command line string for testing :: listmail[firstname][lastname]["address string"]["city string"][state][zip][Order#][PurchDate][Regname]["FirstName LastName"][TransactionID][PaymentMethod][Total][ProductID][Qty][Price_Each][PackPrep] [Shipping] [CommissionPmt] [Invoice#] :: example: dataout Bellewinkle Moose "123 Green Forest Way" "Vancouver" WA 98664 1004968 05/25/2009 "Bellewinkle Moose" "Olive Oyl" 101738 "On Account" 20.67 FK-1P 1 8.95 3.00 1.39 239 #echo off cls c: cd\ cd documents and settings\administrator\my documents\txt\batchtest echo processing %1 %2 :VARISET :: Convert %n command line parameters to string variables set ($FirstName)=%~1 set ($LastName)=%~2 set ($BillingAddress1)=%~3 set ($BillingCity)=%~4 set ($BillingState)=%~5 set ($BillingPostal)=%~6 set ($OrderNumber)=%~7 set ($Purch_Date)=%~8 set ($RegistrationName)=%~9 shift set ($TransactionID)=%~9 shift set ($PaymentMethod)=%~9 shift set ($Total)=%~9 shift set ($ProductIdentifier)=%~9 shift set ($Quantity)=%~9 shift set ($Price_Each)=%~9 shift set ($Pack_Prep)=%~9 shift set ($Shipping)=%~9 shift set ($ServiceFee)=%~9 shift set ($Discount)=%~9 shift set ($Invoice)=%~9 shift set ($UnitPrice)=%~9 set _ShipCombName=%($FirstName)% %($LastName)% echo ship combo name is %_ShipCombName% pause :: write string varibables to logfile echo FN %($FirstName)% LN %($LastName)% BA %($BillingAddress1)% %($BillingCity)% %($BillingState)% %($BillingPostal)% %($OrderNumber)% %($Purch_Date)% %($RegistrationName)% %($TransactionID)% %($PaymentMethod)% %($Total)% %($ProductIdentifier)% %($Quantity)% %($Price_Each)% %($Pack_Prep)% %($Shipping)% %($ServiceFee)% %($Discount)% %($Invoice)% %($UnitPrice)% %_ShipCombName% >> d_out_log.txt :: Assign Account by Service Provider IF /i %($PaymentMethod)%==Amazon Receivables SET _QBAcct=Amazon.com :: 12-25-2009 added second Amazon pm't method for versatility IF /i %($PaymentMethod)%==Amazon SET _QBAcct=Amazon.com IF /i %($PaymentMethod)%==MAST SET _QBAcct=Auth/Net IF /i %($PaymentMethod)%==MasterCard SET _QBAcct=Auth/Net IF /i %($PaymentMethod)%==Visa SET _QBAcct=Auth/Net IF /i %($PaymentMethod)%==PayPal SET _QBAcct=PayPalPmts IF /i %($PaymentMethod)%==On Account SET _QBAcct=%($RegistrationName)% IF /i %($PaymentMethod)%==Mail SET _QBAcct=%($RegistrationName)% IF /i %($PaymentMethod)%==AMER SET _QBAcct=Auth/Net IF /i %($PaymentMethod)%==DISC SET _QBAcct=Auth/Net :: Assign Rep designator based on QBAccount IF /i %($PaymentMethod)%==Amazon Receivables SET _Rep=Amazon :: 12-25-2009 added second Amazon pm't method for versatility IF /i %($PaymentMethod)%==Amazon SET _Rep=Amazon IF /i %($PaymentMethod)%==MAST SET _Rep=BlueZap IF /i %($PaymentMethod)%==MasterCard SET _Rep=BlueZap IF /i %($PaymentMethod)%==Visa SET _Rep=BlueZap IF /i %($PaymentMethod)%==PayPal SET _Rep=BlueZap IF /i %($PaymentMethod)%==On Account SET _Rep=R B IF /i %($PaymentMethod)%==Mail SET _Rep=R B IF /i %($PaymentMethod)%==AMER SET _Rep=BlueZap IF /i %($PaymentMethod)%==DISC SET _Rep=BlueZap :: check for duplicate address data findstr /i /s "%_ShipCombName%" addrlist.txt echo errorlevel: %errorlevel% if errorlevel 1 goto :ADDRWRITE if errorlevel 0 goto :ADDRFOUND :ADDRWRITE echo %_ShipCombName% >> addrlist.txt echo %($BillingAddress1)% >> addrlist.txt echo %($BillingCity)% %($BillingState)% %($BillingPostal)% >> addrlist.txt echo. >> addrlist.txt echo Address File Written :ADDRFOUND echo selected rep is %_Rep% echo selected account is: %_QBAcct% pause :: RUI OUT :: write Merchant Order ID & RUI Order ID to RUI :: check for duplicate RUI data in writeRUI.txt cd.. cd RegKOut find /i "%($OrderNumber)%" writeRUI.txt echo errorlevel: %errorlevel% if errorlevel 1 goto :RUIWRITE if errorlevel 0 goto :IIFWRITE :RUIWRITE echo %($Invoice)% %($OrderNumber)% >> writeRUI.txt :: end write RUI :: IIF OUT :IIFWRITE :: Check for duplicate invoice data in writeIIF.txt find /i "%($OrderNumber)%" writeIIF.txt echo errorlevel: %errorlevel% if errorlevel 1 goto :HEADWRITE if errorlevel 0 goto :LINEWRITE :HEADWRITE :: write Header, Ship/Handling, discount, Rep & commission data to QB IIF import file echo %($OrderNumber)% %($Purch_Date)% Invoice %($TransactionID)% %_QBAcct% Accounts Receivable %($Total)% %_Rep% >> writeIIF.txt echo H/P %($Pack_Prep)% 1 ? >> writeIIF.txt echo SHP %($Shipping)% 1 ? >> writeIIF.txt echo DISC %($Discount)% 1 ? >> writeIIF.txt echo Comm %($ServiceFee)% 1 ? >> writeIIF.txt :LINEWRITE IF /i %($ProductIdentifier)% equ PH-1 goto WRITE_DEFA ELSE goto WRITE_DISC echo %($ProductIdentifier)% :WRITE_DISC ::writes discounted prices parsed from custom variable: echo %($ProductIdentifier)% %($Price_Each)% %($Quantity)% ? >> writeIIF.txt goto :EOF :WRITE_DEFA :writes default prices parsed from Product data echo %($ProductIdentifier)% %($UnitPrice)% %($Quantity)% ? >> writeIIF.txt goto :EOF :: 3-second delay :: TYPE NUL | CHOICE.COM /N /CY /TY,3 >NUL :EOF
You have an extra double quote at the end, which is adding it back to the end of the string (after removing both quotes from the string). Input: set widget="a very useful item" set widget set widget=%widget:"=% set widget Output: widget="a very useful item" widget=a very useful item Note: To replace Double Quotes " with Single Quotes ' do the following: set widget=%widget:"='% Note: To replace the word "World" (not case sensitive) with BobB do the following: set widget="Hello World!" set widget=%widget:world=BobB% set widget Output: widget="Hello BobB!" As far as your initial question goes (save the following code to a batch file .cmd or .bat and run): #ECHO OFF ECHO %0 SET BathFileAndPath=%~0 ECHO %BathFileAndPath% ECHO "%BathFileAndPath%" ECHO %~0 ECHO %0 PAUSE Output: "C:\Users\Test\Documents\Batch Files\Remove Quotes.cmd" C:\Users\Test\Documents\Batch Files\Remove Quotes.cmd "C:\Users\Test\Documents\Batch Files\Remove Quotes.cmd" C:\Users\Test\Documents\Batch Files\Remove Quotes.cmd "C:\Users\Test\Documents\Batch Files\Remove Quotes.cmd" Press any key to continue . . . %0 is the Script Name and Path. %1 is the first command line argument, and so on.
Your conclusion (1) sounds wrong. There must be some other factor at play. The problem of quotes in batch file parameters is normally solved by removing the quotes with %~ and then putting them back manually where appropriate. E.g.: set cmd=%~1 set params=%~2 %~3 "%cmd%" %params% Note the quotes around %cmd%. Without them, path with spaces won't work. If you could post your entire batch code, maybe more specific answer could be made.
I usually just remove all quotes from my variables with: set var=%var:"=% And then apply them again wherever I need them e.g.: echo "%var%"
Spent a lot of time trying to do this in a simple way. After looking at FOR loop carefully, I realized I can do this with just one line of code: FOR /F "delims=" %%I IN (%Quoted%) DO SET Unquoted=%%I Example: #ECHO OFF SET Quoted="Test string" FOR /F "delims=" %%I IN (%Quoted%) DO SET Unquoted=%%I ECHO %Quoted% ECHO %Unquoted% Output: "Test string" Test string
The simple tilde syntax works only for removing quotation marks around the command line parameters being passed into the batch files SET xyz=%~1 Above batch file code will set xyz to whatever value is being passed as first paramter stripping away the leading and trailing quotations (if present). But, This simple tilde syntax will not work for other variables that were not passed in as parameters For all other variable, you need to use expanded substitution syntax that requires you to specify leading and lagging characters to be removed. Effectively we are instructing to remove strip away the first and the last character without looking at what it actually is. #SET SomeFileName="Some Quoted file name" #echo %SomeFileName% %SomeFileName:~1,-1% If we wanted to check what the first and last character was actually quotation before removing it, we will need some extra code as follows #SET VAR="Some Very Long Quoted String" If aa%VAR:~0,1%%VAR:~-1%aa == aa""aa SET UNQUOTEDVAR=%VAR:~1,-1%
I learned from this link, if you are using XP or greater that this will simply work by itself: SET params = %~1 I could not get any of the other solutions here to work on Windows 7. To iterate over them, I did this: FOR %%A IN (%params%) DO ( ECHO %%A ) Note: You will only get double quotes if you pass in arguments separated by a space typically.
This sounds like a simple bug where you are using %~ somewhere where you shouldn't be. The use if %~ doesn't fundamentally change the way batch files work, it just removes quotes from the string in that single situation.
All the answers are complete. But Wanted to add one thing, set FirstName=%~1 set LastName=%~2 This line should have worked, you needed a small change. set "FirstName=%~1" set "LastName=%~2" Include the complete assignment within quotes. It will remove quotes without an issue. This is a prefered way of assignment which fixes unwanted issues with quotes in arguments.
set widget="a very useful item" set widget widget="a very useful item" set widget=%widget:"=%" set widget set widget=a very useful item" The trailing quote " in line 4 is adding a quote " to the string. It should be removed. The syntax for line 4 ends with %
I thought I had the solution, but I soon experienced unusual behavior with execution of batch files. Suddenly CMD is no recognizing long path statments. Normal execution of batch file from full path C:\Documents and Settings\Administrator\My Documents\Txt\batchtest\dataout.bat returns 'C:\Documents' is not recognized as an internal or external command.... There's your whole problem. CMD doesn't understand spaces inside of filenames from the command line, so it thinks you're trying to pass and Settings\Administrator\My Documents\Txt\batchtest\dataout.bat as parameters to the "C:\Documents" program. You need to quote it to run a batch file with spaces in the path: > "C:\Documents and Settings\Administrator\My Documents\Txt\batchtest\dataout.bat" would have worked.
#echo off Setlocal enabledelayedexpansion Set 1=%1 Set 1=!1:"=! Echo !1! Echo "!1!" Set 1= Demonstrates with or without quotes reguardless of whether original parameter has quotes or not. And if you want to test the existence of a parameter which may or may not be in quotes, put this line before the echos above: If '%1'=='' goto yoursub But if checking for existence of a file that may or may not have quotes then it's: If EXIST "!1!" goto othersub Note the use of single quotes and double quotes are different.
Azure devops sometimes uses double quoting character (") to specify string. Powershell can use single quote character (') to specify string. Naturally I wanted to have a flexibility to be able to specify parameters however I wish, so same parameter can be used from both - command line - via batch file, and as a powershell script, as any parameter, including empty value. Quote natural thinking is to write something like this: build.bat: #echo off setlocal enabledelayedexpansion set args=%* set args=%args:"='% echo powershell -executionpolicy bypass "%~dpn0.ps1" %args% endlocal But like you can guess - this does not work out of box - if no arguments are provided to batch file so %* == empty string. args expands as no string, and next replacement notices that args is not set - and instead of replacing string - it would append extra "=' garbage to args parameter. Solution to this was just to add extra space in first assignment. build.bat: #echo off setlocal enabledelayedexpansion set args=%* set args=%args:"='% echo powershell -executionpolicy bypass "%~dpn0.ps1" %args% endlocal After this character translation should be correct: C:\test>build powershell -executionpolicy bypass "C:\test.ps1" C:\test>build aa powershell -executionpolicy bypass "C:\test\build.ps1" aa C:\test>build "aa" powershell -executionpolicy bypass "C:\test\build.ps1" 'aa' C:\test>build 'aa' powershell -executionpolicy bypass "C:\test\build.ps1" 'aa'