Loop with condition at the beginning in protractor - while-loop

Question

I need a repetitive block like while() that verifies a condition before being executed. My code is below, but the while doesn't work...
var foundPersonen = true;
while (foundPersonen) {
detailPage.getAllPersonen().then(function(value) {
if (value.length == 0) {
foundPersonen = true;
remoteControl(Keys.HK_BACK);
remoteControl(Keys.HK_P_up);
remoteControl(Keys.HK_INFO, 1, 3000);
}
else {
foundPersonen = false;
}
});
}
How can I replace the while but still have the same result I need?

Answer 1

I agree at least partially with alecxe. Some "wait" order should fix that. I just would like to explain my thought, hoping that it will be useful for you... Because I have spent a lot of time on this kind of problem^^.
The big point to me is that Protractor runs everything asynchronously.
When you run your test, Protractor basically runs every part of your code it can, i.e. until it encounters a promise. When it encounters a promise, Protractor could do two things, depending whether you have set browser.ignoreSynchronization = true; (this is my case)
If it's true, Protractor creates a new thread and wait for the promise to be resolved, but in the "main thread" Protractor continues to execute your code. If you want Protractor to wait for something, you will have to write it explicitly.
If it's false (this is the case by default), Protractor will add a browser.waitForAngular before continuing. But of course you can always add explicit waiting orders in your code, and you might want to do it in some cases to get a more stable code.
If you want more information about this, read this post
var foundPersonen = true;
while (foundPersonen){
detailPage.getAllPersonen().then(function(value) {
if (value.length == 0) {
foundPersonen = true;
remoteControl(Keys.HK_BACK);
remoteControl(Keys.HK_P_up);
remoteControl(Keys.HK_INFO, 1, 3000);
}
else {
foundPersonen = false;
}
}
In my case (browser.ignoreSynchronization = true;), this is what happens :
allocate one bit of memory for a boolean and set the value to 1;
evaluate the bit
If it is 1
Create a thread. In this thread, create a promise and wait for it to be resolved, then do something with the value of the promise
In the main thread, return to step 2
if it is 0, continue
This interpretation leads to a simple prediction. As the code that sets the value of the boolean to 0 is treated after the promise is resolved, this piece of code will create promises as fast as it can until one of these promises will be resolved and set the boolean to false.
The result of this ? Your code will reach the maximum of memory before the first promise will be resolved. --> You will receive some exception related to the allocation of memory.
I tested that with this code:
return scenariiSteps.AtlasLogin("my", "credentials")
.then(function () {
var foundDialogs = element.all(by.xpath("//div[#dialog-id]"));
var foundDialogsZero = true;
while (foundDialogs) {
foundDialogs.count().then(function (value) {
if (value == 0) {
foundDialogsZero = true;
console.log("0, man")
}
else {
console.log("Found something!")
foundDialogsZero = false;
}
});
}
});
What this code do is
Login
Allocate memory for some object (it will stock the list of the dialogs in the page of my app)
Allocate one bit of memory for a boolean and set it to false.
Evaluate the bit
if it is 1
create a promise and wait for it to be resolved, then do something with the value of the promise
return to step 4
And, to be sure of my interpretation, please note that my app contains 2 dialogs as soon as the user is logged in.
As I thought, I received FATAL ERROR: CALL_AND_RETRY_LAST Allocation failed - process out of memory
"Ok, thank you for that long explanation, but... What should I do now ?"
Well basically you have to tell to Protractor to wait for some condition before performing the action you want. The best way to do it depends on your requirements and your environment. For instance, I don't think the solution of alecxe would fix the problem in my environment.
It would be useful to know a bit more about what you want to do if you want more help.

Answer 2

Yeah, since protractor keep adding everything on to controlflow, blocks like while do not work as expected. Try calling it recursively in a function.
function keepChecking(){
while (foundPersonen) {
detailPage.getAllPersonen().then(function(value) {
if (value.length == 0) {
foundPersonen = true;
remoteControl(Keys.HK_BACK);
remoteControl(Keys.HK_P_up);
remoteControl(Keys.HK_INFO, 1, 3000);
keepchecking();
}
else {
foundPersonen = false;
}
});
}
}
keepchecking();

Answer 3

I think you can solve it with browser.wait():
browser.wait(function () {
return detailPage.getAllPersonen().count().then(function (count) {
if (count == 0) {
remoteControl(Keys.HK_BACK);
remoteControl(Keys.HK_P_up);
remoteControl(Keys.HK_INFO, 1, 3000);
return false;
}
else {
return true;
}
}
}, 10000);
This would execute the condition function up to 10 seconds while the count is 0. If it is 0, it executes your remote control functions. Please test.