Sort the information in a different file excel - vba

Question

I have got a problem with my macro and I would like to know if someone could help me.
I am doing a macro in a file, and that macro will go accessing other file and sort the information existing there. Until now I have the following code:
Sub Macro()
Dim xl As New Application
Dim xlw As Workbook
Dim xls As Worksheet
a = ThisWorkbook.Path & "\A.csv"
On Error GoTo bm:
Set xlw = xl.Workbooks.Open(a)
Set xls = xlw.Sheets(1)
' Windows(a).Activate
a = xls.Name
Columns("C:C").Select
xlw.Worksheets(a).Sort.SortFields.Clear
xlw.Worksheets(a).Sort.SortFields.Add Key:=Range("C2"), SortOn _
:=xlSortOnValues, Order:=xlDescending, DataOption:=xlSortNormal
With xlw.Worksheets(a).Sort
.SetRange Range("A2:K297594")
.Header = xlNo
.MatchCase = False
.Orientation = xlTopToBottom
.SortMethod = xlPinYin
.Apply
End With
bm:
xlw.Saved = True
xlw.Close True
xl.Quit
Set xls = Nothing
Set xlw = Nothing
Set xl = Nothing
End Sub
When put it running , when it reaches the instruction ".SetRange Range("A2:K297594")" it gives "Run-time error 5" and I don't understand why. So could anyone explain me how resolve this or why is giving this error?
Thanks :)

Answer 1

Your range is not referenced and Excel doesNOT know of which sheet you are talking about, it should be .SetRange xlw.Worksheets(a).Range("A2:K297594") :
Sub Macro()
Dim xl As New Application
Dim xlw As Workbook
Dim xls As Worksheet
a = ThisWorkbook.Path & "\A.csv"
On Error GoTo bm:
Set xlw = xl.Workbooks.Open(a, Local:=True)
Set xls = xlw.Sheets(1)
' Windows(a).Activate
a = xls.Name
Columns("C:C").Select
xlw.Worksheets(a).Sort.SortFields.Clear
xlw.Worksheets(a).Sort.SortFields.Add Key:=xlw.Worksheets(a).Range("C2"), SortOn _
:=xlSortOnValues, Order:=xlDescending, DataOption:=xlSortNormal
With xlw.Worksheets(a).Sort
.SetRange xlw.Worksheets(a).Range("A2:K297594")
.Header = xlNo
.MatchCase = False
.Orientation = xlTopToBottom
.SortMethod = xlPinYin
.Apply
End With
bm:
xlw.Save
xlw.Close True
xl.Quit
Set xls = Nothing
Set xlw = Nothing
Set xl = Nothing
End Sub

Answer 2

You need to qualify all your workbook, worksheet and range references, especially since you are running a macro against another workbook from where the macro runs.
You were really almost there (99%). This will clean it up for you:
Dim wName as String 'since you already use a to get the file name
wName = xls.Name
With xlw.Worksheets(wName).Sort
With .SortFields
.Clear
'note . (period) in front of range and I am pretty sure you need to set the
'whole range reference ... hence the C297597 ... but maybe just C2 is enough
.Add Key:=.Range("C2:C297594"), SortOn:=xlSortOnValues, Order:=xlDescending, DataOption:=xlSortNormal
End With
'note . (period) in front of range
.SetRange .Range("A2:K297594")
.Header = xlNo
.MatchCase = False
.Orientation = xlTopToBottom
.SortMethod = xlPinYin
.Apply
End With