Can't Insert Data into DataBase(SQL) using MVC - sql

Question

This is my controller class
[HttpPost]
public ActionResult SignUp(SignupModel model)
{
User u = new User();
u.LoginId = model.LoginId;
u.Password = model.Password;
u.FullName = model.FullName;
new UsersHandler().AddUser(u);}
UserHandler class contains
public void AddUser(User user)
{
new DAC().Insert(user);
}
DAC class contains the connections and UsersDAC contains the queries
Insert Query
internal void Insert(User user)
{
List<SqlParameter> temp = new List<SqlParameter>
{
new SqlParameter("#FullName", user.FullName),
new SqlParameter("#LoginId", user.LoginId),
new SqlParameter("#Password", user.Password)
};
SqlConnection con = DACHelper.GetConnection();
using (con)
{
con.Open();
SqlTransaction t = con.BeginTransaction();
try
{
user.Id = (int)DACHelper.ExecuteScalar(INSERT, temp, t);
DACHelper.Execute(INSERT, temp);
t.Commit();
}
catch (Exception)
{
t.Rollback();
}
}
}
DACHelper.Execute(INSERT, temp);
It Executes but doesn't Insert any thing in table.
Stored Procedure
ALTER PROCEDURE [dbo].[Users_Insert]
#FullName varchar(50),
#LoginId varchar(50),
#Password varchar(50)
AS
Insert into [Users]
([FullName],[LoginId],[Password])
Values (#FullName,#LoginId,#Password)
Select ##IDENTITY from [Users]

Answer 1

My suggestions:
Test the stored procedure outside of your program using the same SQL credentials used by the program. If this works, the problem is your code.
Try calling the stored procedure by building the code without the use of your classes that hide some of what is being done.
Make sure that the SqlCommand object knows that it should be using a CommandType of CommandType.StoredProcedure.
Do not use SCOPE_IDENTITY or ##IDENTITY. The safest way to get the identity field is as follows (assume the field name is ID):
INSERT into [Users] ([FullName],[LoginID],[Password])
OUTPUT INSERTED.ID
VALUES (#FullName, #LoginID, #Password)
This will always be the correct value.

Answer 2

What about the commit mode? Is it in auto-commit mode. If not try to execute commit manually using the script. This should display message as transaction is committed.

Answer 3

You do not have used sqlparamater.appwithvalue may be this cause this issue..
internal void Insert(User user)
{
List<SqlParameter> temp = new List<SqlParameter>
{
new SqlParameter().AddWithvalue("#FullName", user.FullName),
new SqlParameter().AddWithvalue("#LoginId", user.LoginId),
new SqlParameter().AddWithvalue("#Password", user.Password)
};
SqlConnection con = DACHelper.GetConnection();
using (con)
{
con.Open();
SqlTransaction t = con.BeginTransaction();
try
{
user.Id = (int)DACHelper.ExecuteScalar(INSERT, temp, t);
DACHelper.Execute(INSERT, temp);
t.Commit();
}
catch (Exception)
{
t.Rollback();
}
}
}

Answer 4

internal void Insert(User user)
{
List<SqlParameter> temp = new List<SqlParameter>
{
new SqlParameter("#LoginId", user.LoginId),
new SqlParameter("#Password", user.Password),
new SqlParameter("#FullName", user.FullName),
};
SqlConnection con = DACHelper.GetConnection();
using (con)
{
con.Open();
SqlTransaction t = con.BeginTransaction();
user.Id = (Int32)DACHelper.ExecuteScalar(INSERT, temp, t);
t.Commit();
}
}
This will work by removing try/catch.