SQL While Loop to retry Transaction until success - sql

Question

I need to have a transaction, which when it fails, rolls back, and retries.
Where's what I have so far:
CREATE PROCEDURE [dbo].[Save]
#MasterID as bigint
AS
BEGIN
SET NOCOUNT ON;
SET XACT_ABORT ON;
Declare #successtrans bit = 0
While #successtrans = 0
Begin -- while
BEGIN TRY
BEGIN TRANSACTION
DELETE SomeRecords WHERE ParentRecordID = #MasterID
INSERT INTO SomeRecords
Select FieldOne, FieldTwo, FieldThree, ParentRecordID
FROM OtherRecords
WHERE ParentRecordID = #MasterID
INSERT INTO AnotherTable
SELECT FieldA, FieldB, FieldC, FieldD
FROM MoreRecords
WHERE FieldD = #MasterID
COMMIT TRANSACTION
set #successtrans = 1
END TRY
BEGIN CATCH
IF(XACT_STATE()) = -1 -- Determine the state of the current transction (1 = committable, 0 = no active transaction (same as ##Trancount check), -1 = active, but uncommittable) only on severity 17 or higher
BEGIN
DECLARE #ErrorNumber bigint = ERROR_Number(),
#ErrorSeverity int = ERROR_SEVERITY(),
#ErrorState int = ERROR_STATE(),
#ErrorProcedure varchar(100) = ERROR_PROCEDURE(),
#ErrorLine int = ERROR_LINE(),
#ErrorMessage varchar(Max) = ERROR_MESSAGE()
IF ##TRANCOUNT > 0
ROLLBACK TRANSACTION
INSERT INTO ErrorLog(ErrorNumber, ErrorSeverity, ErrorState, ErrorProcedure, ErrorLine, ErrorMessage, ErrorDate)
VALUES(#ErrorNumber, #ErrorSeverity, #ErrorState, #ErrorProcedure, #ErrorLine, #ErrorMessage, GETDATE())
END -- if
END CATCH
End -- while
END -- proc
GO
The question is, will this work for what I'm doing? Logic says yes. But this is a methodology I need to implement across 10 or more stored procs, and I'm having trouble making it fail and repeat.

Answer 1

You should check in the catch why it's failing or you could generate an infinite loop (Like already existing primary-keys).
As I don't know why you want to do this I won't say it's a bad design, but it's really suspicious. If it's failing is for some reason and exception message will say you why, instead of "brute forcing" your database until it does what you're expecting you should attack the cause of the problem (Bad data? Concurrency? Lot of causes could be causing the exception)
Edit: You should take care of your log too, on an infinite loop it will fill you hdd eventually