Add line from excel VBA without the running file - vba

Question

I just need the IF line that says that if he tries to open the file that runs the code(Trying to open himself) then skip it.
Here is the code I have so far.
Sub Auto_Open()
Dim SrcBook As Workbook
Dim fso As Object, f As Object, ff As Object, f1 As Object
Application.ScreenUpdating = False
Set fso = CreateObject("Scripting.FileSystemObject")
Set f = fso.Getfolder("C:\test\new")
Set ff = f.Files
For Each f1 In ff
Set SrcBook = Workbooks.Open(f1)
Range("A2:IV" & Range("A20").End(xlUp).Row).Copy
ThisWorkbook.Worksheets(1).Activate
Range("A20").End(xlUp).Offset(1, 0).PasteSpecial
Application.CutCopyMode = False
SrcBook.Close
Next
End Sub

Answer 1

If Not ThisWorkbook.FullName = f1.Path Then
Set SrcBook = Workbooks.Open(f1)
Range("A2:IV" & Range("A20").End(xlUp).Row).Copy
ThisWorkbook.Worksheets(1).Activate
Range("A20").End(xlUp).Offset(1, 0).PasteSpecial
Application.CutCopyMode = False
SrcBook.Close
End If

Answer 2

Taking your code as is, you could add the following If-statement to the For Each-loop:
For Each f1 In ff
If StrComp(f1.Name, ActiveWorkbook.Name, vbTextCompare) <> 0 And _
InStr(1, f1.Name, "~") = 0 Then
Set SrcBook = Workbooks.Open(f1)
Range("A2:IV" & Range("A20").End(xlUp).Row).Copy
ThisWorkbook.Worksheets(1).Activate
Range("A20").End(xlUp).Offset(1, 0).PasteSpecial
Application.CutCopyMode = False
SrcBook.Close
End If
Next
The first condition prevents opening the current file itself, the second condition also skips the temporary file that Excel creates on opening a file.
Reworked Code
Just as an aside, I would refactor and expand the code as follows:
Sub Auto_Open()
On Error GoTo Err_
Dim fso As Object
Dim Folder As Object
Dim Files As Object
Dim File As Object
Application.ScreenUpdating = False
Set fso = CreateObject("Scripting.FileSystemObject")
Set Folder = fso.Getfolder("C:\Temp\Excel")
Set Files = Folder.Files
For Each File In Files
If StrComp(File.Name, ActiveWorkbook.Name, vbTextCompare) <> 0 And _
InStr(1, File.Name, "~") = 0 Then
With Workbooks.Open(File.Path)
Range("A2:IV" & Range("A20").End(xlUp).Row).Copy
ThisWorkbook.Worksheets(1).Activate
Range("A20").End(xlUp).Offset(1, 0).PasteSpecial
Application.CutCopyMode = False
.Close
End With
End If
Next
Exit_:
Application.ScreenUpdating = True
Set Files = Nothing
Set Folder = Nothing
Set fso = Nothing
Exit Sub
Err_:
Resume Exit_
End Sub
A few remarks:
Error handling to ensure that even in the case of an error ScreenUpdating is switched back on again. Otherwise you could leave your application not refreshing to the user in case of an error.
Separate line for each variable - easier to grasp
More explicit variable names. First and foremost, code should be easy to read, not easy to type.
With-block for the local variable to make it's scope explicit. Saves the local variable SrcBook as well.
Here it might be argued that the name of that variable helped understanding the problem and should better be kept.
Explicit setting the object variables to Nothing. Might be paranoid, but as a SOP it can help to avoid all kind of weird issues in some cases.
Since it might be challenging to get the intent of the code in the With-block is, I would even go further and extract that block into a new method with a intent-revealing name to make things clearer. The name could be along the lines of CopyProductListFromFile.