SQL Server Trigger containing one or two cursors - sql

Question

I am trying to create a cursor, or cursors, inside of a trigger. What I need to do is when one field in a table is updated, I have to have one cursor or two cursors iterate through and record all of the fields in a table and insert the old and new values into a table.
Here is the code I currently have. This code iterates through the new values in the inserted table correctly, but does not iterate through the old values, in the deleted table.
ALTER TRIGGER [dbo].[Audit_Emp_Trigger]
ON [dbo].[EMPLOYEE]
AFTER UPDATE, DELETE
AS
BEGIN
--Set the fields that we will need in this trigger
DECLARE #OldLName NVARCHAR(50);
DECLARE #NewLName NVARCHAR(50);
DECLARE #OldSSN INT;
DECLARE #NewSSN INT;
DECLARE #OldDno INT;
DECLARE #NewDno INT;
DECLARE #Fname NVARCHAR(50);
DECLARE #Mname NVARCHAR(50);
DECLARE #BDate DATE;
DECLARE #Address NVARCHAR(100);
DECLARE #Sex CHAR(1);
DECLARE #Salary INT;
DECLARE #SuperSSN INT;
--Only execute the trigger if the Dno field was updated or deleted
IF UPDATE(Dno)
BEGIN
--If this is an insert operation, we will be inserting a new Dno value
SELECT #OldLName = D.LName FROM deleted D
SELECT #OldSSN = D.Ssn FROM deleted D
SELECT #OldDno = D.Dno FROM deleted D
DECLARE InsertCursor CURSOR FOR SELECT Fname, Minit, Lname, Ssn, Bdate, Address, Sex, Salary, Super_ssn, Dno FROM inserted
OPEN InsertCursor
FETCH NEXT FROM InsertCursor INTO #Fname, #Mname, #NewLName, #NewSSN, #BDate, #Address, #Sex, #Salary, #SuperSSN, #NewDno
WHILE ##FETCH_STATUS = 0
BEGIN
--If the Audit_Emp_Record table does not exist already, we need to create it
IF OBJECT_ID('dbo.Audit_Emp_Record') IS NULL
BEGIN
--Table does not exist in database, so create table
CREATE TABLE Audit_Emp_Record
(
date_of_change smalldatetime,
old_Lname varchar (50),
new_Lname varchar (50),
old_ssn int,
new_ssn int,
old_dno int,
new_dno int
);
--Once table is created, insert the values of the update operation into the table
INSERT INTO Audit_Emp_Record(date_of_change, old_Lname, new_Lname, old_ssn, new_ssn, old_dno, new_dno) VALUES(GETDATE(), #OldLName, #NewLName, #OldSSN, #NewSSN, #OldDno, #NewDno)
END
ELSE
BEGIN
--The table already exists, so simply insert the new values of the update operation into the table
INSERT INTO Audit_Emp_Record(date_of_change, old_Lname, new_Lname, old_ssn, new_ssn, old_dno, new_dno) VALUES(GETDATE(), #OldLName, #NewLName, #OldSSN, #NewSSN, #OldDno, #NewDno)
END
FETCH NEXT FROM InsertCursor INTO #Fname, #Mname, #NewLName, #NewSSN, #BDate, #Address, #Sex, #Salary, #SuperSSN, #NewDno
END
END
END