Shape Name by Reference and Looping doesnt work - vba

Question

Im Creating a subroutine as below to Refer a Cell and coulor the shape.
In my Code the H value (Name) is not working. Please help.
Sub Erectioncolour()
J = 9
H = 1
Do
If Worksheets("Vertical Chart").Cells(J, 25).Value <> "" Then
Worksheets("Visual Chart").Shapes(H).Fill.ForeColor.RGB = RGB(5, 0, 0)
Else
Worksheets("Visual Chart").Shapes(H).Fill.ForeColor.RGB = RGB(255, 255, 255)
End If
J = J + 1 And H = H + 1
Loop While J = 268
End Sub

Answer 1

In my Code the H value (Name) is not working.
Yes, it is actually working.
Your problem is with the conditional If Worksheets("Vertical Chart").Cells(J, 25) <> "". Row 25 in that worksheet is empty, after column K. So for every value of J greater than 10, it will not apply the RGB(5, 0, 0), but instead applies the RGB(255, 255, 255) as the False part of the test.
So the True part of your If/Else statement is only being executed once. After that, they all evaluate to False, so the shapes are being correctly (according to the code) applied with the following from your Else statement:
Worksheets("Visual Chart").Shapes(H).Fill.ForeColor.RGB = RGB(255, 255, 255)
Solution:
You need to change your logic in the If statement, or, specify a non-white RGB value.
Updated to explain how IF statements work...
THere are two parts to your If statement, a True part which colors the shapes with RGB(5, 0, 0) and a False part which colors the shapes with RGB(255, 255, 255) (white). As your file is currently configured, the statement evaluates False for every value of J in {9,11,12,..., 268}. This is conditional based on the logic AND the data (or lack thereof) in the worksheet.
If you don't want these shapes to be white, then you need to assign a different RGB value. Which one you choose is up to you, for example .RGB(6, 255, 255) looks turquoise.
Or the other possibility is that your If statement's test is incorrect. If that is not correct, then I cannot help you until you describe how the test should be working, because the current test will always do what it is doing right now, until the cells in Row 25 are non-blank.