how to use triggers when comparing two data from different tables? [closed] - sql

Closed. This question needs to be more focused. It is not currently accepting answers.
Want to improve this question? Update the question so it focuses on one problem only by editing this post.
Closed 8 years ago.
Improve this question
CONSTRAINT (Movie.Date – person.DateOfBirth >= Movie.MinAge)
I am trying to use triggers for this constraint, I am not sure how to use triggers when you are comparing different data from different tables.

Something like this.. I didn't test it!!
CREATE OR REPLACE TRIGGER check_movie_parent_rating
BEFORE INSERT OR UPDATE OF DateOfBirth ON Person
REFERENCING NEW AS n
FOR EACH ROW
DECLARE
v_allowed VARCHAR2(1);
BEGIN
BEGIN
SELECT CASE WHEN (Movie.Date - person.DateOfBirth >= Movie.MinAge)
THEN 'Y'
ELSE 'N'
END As Allowed
INTO v_allowed
FROM Movie , Person
WHERE Movie.id = :n.movieId
AND Person.movieId = Movie.id
AND Person.id = :n.id;
EXCEPTION
WHEN NO_DATA_FOUND THEN
v_allowed := NULL;
END;
IF v_allowed IS NULL THEN
Raise_application_error(-20202, 'Movie Detail not available in parent');
ELSIF v_allowed = 'N' THEN
Raise_application_error(-20201, 'Movie Restricted for User');
END IF;
END;
/

Here is a solution that will avoid the mutating table error that arises when you select from a table within a row level trigger defined against the same table.
You should check the constraint whenever any involved table is changed.
Ideally, there should also be serialisation locks at within the trigger to ensure transactions executing concurrently do not alter the data in such a way as to break the constraint. This can be achieved by using modules within the supplied DBMS_LOCK package.
CREATE OR REPLACE TRIGGER Movie_Check_Age
AFTER INSERT OR UPDATE OF <Join_Columns>, Date, MinAge ON Movie
FOR EACH ROW
DECLARE
CURSOR csrPersons
IS
SELECT NULL
FROM Person p
WHERE p.<Join_Columns> = :new.<Join_Columns>
AND (Months_Between(:new.Date, p.DateOfBirth) / 12) < :new.MinAge;
rPerson csrPersons%ROWTYPE;
BEGIN
OPEN csrPersons;
FETCH csrPersons INTO rPerson;
IF csrPersons%FOUND THEN
CLOSE csrPersons;
Raise_Application_Error(-20001, 'Person too young to see movie');
ELSE
CLOSE csrPersons;
END IF;
END;
/
CREATE OR REPLACE TRIGGER Person_Check_Age
AFTER INSERT OR UPDATE OF <Join_Columns>, DateOfBirth ON Person
FOR EACH ROW
DECLARE
CURSOR csrMovies
IS
SELECT NULL
FROM Movie m
WHERE m.<Join_Columns> = :new.<Join_Columns>
WHERE (Months_Between(m.Date, :new.DateOfBirth) / 12) < m.MinAge;
rMovie csrMovies%ROWTYPE;
BEGIN
OPEN csrMovies;
FETCH csrMovies INTO rMovie;
IF csrMovies%FOUND THEN
CLOSE csrMovies;
Raise_Application_Error(-20001, 'Person too young to see movie');
ELSE
CLOSE csrMovies;
END IF;
END;
/

Related

Transaction procedure [closed]

Closed. This question needs details or clarity. It is not currently accepting answers.
Want to improve this question? Add details and clarify the problem by editing this post.
Closed 1 year ago.
Improve this question
It should make a bank transaction. So i have a table called "transaction" and also an "account" table and a "withdraw" and "deposit". The procedure should create a row in the transaction table. It should call my function which looks if the person is certified. If the user isnt error should show of course. If the transaction has been made the new "saldo" (which is in the account table) of both accounts should be printed. This is what i have so far:
create or replace procedure do_transaction(
p_rownr in transaction.rownr%type,
p_pnr in transaction.pnr%type,
p_knr in transaction.knr%type,
p_date in transaction."date"%type)
as
not_certified exception;
begin
insert into transaction(rownr,pnr,knr,"date")
values(p_rownr,p_pnr,p_knr,p_date);
if user <> get_certification(p_pnr,p_knr) then
raise not_certified;
end if;
dbms_output.put_line('Pnr: '||''||p_pnr||''||'Current saldo: '||''||get_saldo(p_knr)); /*I also have a function which gets the saldo from the matching knr*/
commit;
exception
when not_certified then
raise_application_error(-20007,'Not certified!');
end;
The get certification function:
create or replace function get_certification(
p_pnr in bankcust.pnr%type,
p_knr in account.knr%type)
return varchar2
as
v_certification bankcust.pnr%type;
begin
select count(*)
into v_certification
from bankcust,account
where pnr = p_pnr
and knr = p_knr;
return v_certification;
exception
when no_data_found then
return -1;
end;
Any suggestions?
I am going to take a guess here as you did not actually state your problem. But that issue is your do_transaction procedure always results in the not certified exception. This is the result of the statement
if user <> get_certification(p_pnr,p_knr) then
This will always evaluate true. It compares the character representation of the result count function from get_certification to the current user (unless the user is presumably '1') thus always resulting in "raise not_certified;" being executed. Additionally, while not actually an exception but falls into the category of not doing unnecessary work; validate certification before inserting into transaction. So:
create or replace procedure do_transaction(
p_rownr in transaction.rownr%type,
p_pnr in transaction.pnr%type,
p_knr in transaction.knr%type,
p_date in transaction."date"%type)
as
not_certified exception;
begin
if get_certification(p_pnr,p_knr) = 0 then
raise not_certified;
end if;
insert into transaction(rownr,pnr,knr,"date")
values(p_rownr,p_pnr,p_knr,p_date);
dbms_output.put_line('Pnr: '||''||p_pnr||''||'Current saldo: '||''||get_saldo(p_knr)); /*I also have a function which gets the saldo from the matching knr*/
commit;
exception
when not_certified then
raise_application_error(-20007,'Not certified!');
end do_transaction;

sql project aid required [closed]

Closed. This question is not reproducible or was caused by typos. It is not currently accepting answers.
This question was caused by a typo or a problem that can no longer be reproduced. While similar questions may be on-topic here, this one was resolved in a way less likely to help future readers.
Closed 6 years ago.
Improve this question
I'm trying to generate a trigger that if a column within a table is filled in with a specific set value e.g. i have a column named 'Volunteertype' which can only be assigned either 'staff' of 'student', if student is entered the trigger must nullify all columns relating to staff details within the volunteer table such as 'area of work', 'staffmanager' etc below is code i have tried to put together utilising the resources on the website however i'm having no luck.
CREATE TRIGGER trg_voltype
ON Volunteer
AFTER INSERT
AS
IF EXISTS (SELECT NULL FROM inserted i WHERE VolunteerType = 'student')
FOR EACH ROW BEGIN;
UPDATE v
SET Area_of_work = NULL
SET StaffManagerName = NULL
SET StaffManagerEmail = NULL
SET StaffManagerPhone = NULL
FROM Volunteer v
JOIN inserted i ON v.Volunteer_id = i.Volunteer_id
WHERE v.VolunteerType = 'student';
END;
However when this is run within the Oracle environment an error is produced ORA-04071: missing BEFORE, AFTER or INSTEAD OF keyword. when i attempt to shift the 'AFTER INSERT' to before the keyword i get an 'invalid trigger' error
Is anyone able to assist and inform me if the code itself is correct/ incorrect and how i should go about amending the code, thanks in advance and have a wonderful end to the year thanks!
Your trigger should be like :
CREATE OR REPLACE TRIGGER trg_voltype
BEFORE INSERT ON volunteer
FOR EACH ROW
BEGIN
if :new.Volunteertype = 'STUDENT'
then
:new.Area_of_work := NULL;
:new.StaffManagerName := NULL;
:new.StaffManagerEmail := NULL;
:new.StaffManagerPhone := NULL ;
end if;
END;

Limit data input based on count of instances in table

Oracle 12c.
I currently have a table to hold patient visits containing a physician id, patient id, and data/time of visit.
I would like to create a constraint that, upon data entry, checks whether a specific physician has 5 appointments in that given day. If the physician does have 5 appointments, no additional appointment can be added.
Is there any way to do this other than using a stored procedure for entry?
If I were to use a stored procedure (as opposed to a trigger due issues declaring a variable) I receive the following error: Error(4,8): PLS-00103: Encountered the symbol "UPDATE" when expecting one of the following: := . ( # % ; not null range default character
I am unsure if this is because I can't use a BEFORE UPDATE on a procedure. Any thoughts?
CREATE OR REPLACE PROCEDURE doc_apt_limit_5
IS
v_visit_count
BEFORE UPDATE OR INSERT ON aa_patient_visit
FOR EACH ROW
BEGIN
SELECT (COUNT(*)) INTO v_visit_count
FROM aa_patient_visit
WHERE physid = :NEW.physid
GROUP BY physid, visittime;
IF v_visit_count > 4 THEN
RAISE_APPLICATION_ERROR(-20001, 'physician is fully booked on this date');
END IF;
END;
Go with trigger. Probably the best solution in this scenario.
CREATE OR REPLACE TRIGGER doc_apt_limit_5 BEFORE
UPDATE OR
INSERT ON aa_patient_visit FOR EACH ROW
DECLARE v_visit_count PLS_INTEGER;
BEGIN
SELECT COUNT(*)
INTO v_visit_count
FROM aa_patient_visit
WHERE physid = :NEW.physid
GROUP BY physid,
visittime;
IF v_visit_count > 4 THEN
RAISE_APPLICATION_ERROR(-20001, 'physician is fully booked on this date');
END IF;
END;

Trigger set insert row values to null [closed]

Closed. This question needs debugging details. It is not currently accepting answers.
Edit the question to include desired behavior, a specific problem or error, and the shortest code necessary to reproduce the problem. This will help others answer the question.
Closed 7 years ago.
Improve this question
So I'm trying to write a trigger that when something is inserted into the database if it is over a specific time set the row values to null
CREATE OR REPLACE TRIGGER hi
AFTER INSERT OR UPDATE OF CLASS_TIME ON class
FOR EACH ROW
BEGIN
IF (:NEW.CLASS_TIME < '09:00' )
OR (:NEW.CLASS_TIME > '18:00' )
THEN
RAISE_APPLICATION_ERROR(-20000, 'Due to low attendance no class cannot be scheduled at that time');
SET NEW.STAFFNO = NULL;
SET NEW.CLASS_DAY = NULL;
SET NEW.CLASS_TYPE = NULL;
SET NEW.ROOMNUM = NULL;
END IF;
END;
All that I have found online shows that what Ive got is correct but I get the error on the STAFFNO. Thanks in advance for any input.
First of all you have to decide:
either you want the insert or update to fail when it's being done at undesired time
or you want the insert or update to be processed, but with the columns set to null then.
You cannot have both.
In case you want to set the columns to NULL, this should be a BEFORE INSERT/UPDATE trigger, so the changed columns get written to the table. (In an AFTER INSERT/UPDATE trigger setting the fields to some value would not have any effect, becase they are not written.)
Then SET NEW.STAFFNO = NULL; is no valid PL/SQL, that would have to be :NEW.STAFFNO := NULL; instead.
CREATE OR REPLACE TRIGGER hi
BEFORE INSERT OR UPDATE OF class_time ON class
FOR EACH ROW
WHEN (new.class_time NOT BETWEEN '09:00' AND '18:00')
BEGIN
:new.staffno := null;
:new.class_day := null;
:new.class_type := null;
:new.roomnum := null;
END;

Creating trigger which throws an exception on insert

Hello fellow programmers and happy new year to you all!
I have few university tasks for winter break and one of them is to create trigger on table:
PERSON(ID, Name, Surname, Age);
Trigger is supposed to inform user when they have inserted row with invalid ID. Vadility criteria is that ID is 11 digits long.
I tried to write solution like this:
CREATE OR REPLACE TRIGGER person_id_trigg
AFTER INSERT
ON person
DECLARE
idNew VARCHAR(50);
lengthException EXCEPTION;
BEGIN
SELECT id INTO idNew FROM INSERTED;
IF LENGTH(idNew) <> 11 THEN
RAISE lengthException;
END IF;
EXCEPTION
WHEN lengthException THEN
dbms_output.put_line('ID for new person is INVALID. It must be 11 digits long!');
END;
Then I realized that INSERTED exists only in sqlserver and not in oracle.
What would you suggest I could do to fix that?
Thanks in advance!
Do you want to raise an exception (which would prevent the insert from succeeding)? Or do you want to allow the insert to succeed and write a string to the dbms_output buffer that may or may not exist and may or may not be shown to a human running the insert?
In either case, you'll want this to be a row-level trigger, not a statement-level trigger, so you'll need to add the for each row clause.
CREATE OR REPLACE TRIGGER person_id_trigg
AFTER INSERT
ON person
FOR EACH ROW
If you want to raise an exception
BEGIN
IF( length( :new.id ) <> 11 )
THEN
RAISE_APPLICATION_ERROR( -20001,
'The new ID value must have a length of 11' );
END IF;
END;
If you want to potentially print output but allow the insert to succeed
BEGIN
IF( length( :new.id ) <> 11 )
THEN
dbms_output.put_line( 'The new ID value must have a length of 11' );
END IF;
END;
Of course, in reality, you would never use a trigger for this sort of thing. In the real world, you would use a constraint.