Delphi, error :"Access violation at address xxxxxxxx. Read of address yyyyyyyy", at AdoQuery.SQL.Text:=''' - sql

Question

"Access violation at address xxxxxxxx. Read of address yyyyyyyy"
On this project i have more than 200 procedures like that, but only this procedure gets error (only windows xp)..
Procedure than have error :
Procedure TfMain.CreateNewDocument(p_money_direction,p_status,p_base:integer);
begin
With fMain.ADOTemp do
Begin
SQL.Clear;
SQL.Text:='INSERT INTO documents '+
'(document_date,fk_id_status,money_direction,'+
'paid,addition,saving,fk_id_base,fk_id_user)'+
'VALUES '+
'(CONVERT(DATE,:pdocument_date,103),:pfk_id_status,'+
':pmoney_direction,0,0,0,:pfk_id_base,:pfk_id_user)';
Parameters.ParamByName('pdocument_date').Value:=Date;
Parameters.ParamByName('pfk_id_status').Value:=p_status;
Parameters.ParamByName('pmoney_direction').Value:=p_money_direction;
Parameters.ParamByName('pfk_id_base').Value:=p_base;
Parameters.ParamByName('pfk_id_user').Value:=fMain.ApplicationVariablers.user_id;
ExecSQL;
End;
end;
Error at :
SQL.Text:='INSERT INTO documents '+
'(document_date,fk_id_status,money_direction,'+
'paid,addition,saving,fk_id_base,fk_id_user)'+
'VALUES '+
'(CONVERT(DATE,:pdocument_date,103),:pfk_id_status,'+
':pmoney_direction,0,0,0,:pfk_id_base,:pfk_id_user)';
Debuingging process, error at line 1907 :

Answer 1

I fix the problem like that
Procedure TfMain.CreateNewDocument(p_money_direction,p_id_status,p_id_base:integer);
Var
ADOTemp:TAdoQuery;
begin
ADOTemp:=TADOQuery.Create(nil);
ADOTemp.Connection:=fMain.ADOConnection;
With ADOTemp do
Begin
SQL.Clear;
SQL.Add('INSERT INTO documents');
SQL.Add('(document_date,fk_id_status,money_direction,');
SQL.Add('paid,addition,saving,fk_id_base,fk_id_user)');
SQL.Add('VALUES ');
SQL.Add('(CONVERT(DATE,GETDATE(),103),:pfk_id_status,:pmoney_direction,');
SQL.Add('0,0,0,'+IntToStr(p_id_base)+',:pfk_id_user)');
Parameters.ParamByName('pfk_id_status').Value:=p_id_status;
Parameters.ParamByName('pmoney_direction').Value:=p_money_direction;
//Parameters.ParamByName('p').Value:=p_id_base;
Parameters.ParamByName('pfk_id_user').Value:=fMain.ApplicationVariablers.user_id;
ExecSQL;
End;
end;
I removed Parameters.ParamByName('p').Value:=p_id_base; and it worked
http://oi43.tinypic.com/dvotxx.jpg
But it is not good solition

Answer 2

As first, change assigment for text property using "add" insthead .text.
Using text is not good. some year ago I've issue uisng text property for a complex sql statement.
Also, I suggest you:
FORGET WITH STATEMENT.
Each time I works on code using "with" I spend (waste) more more time to understand code.
With fMain.ADOTemp do
Begin
AdoTemp.SQL.Clear;
AdoTemp.SQL.Add( ' INSERT INTO documents ');
AdoTemp.SQL.Add( ' (document_date,fk_id_status,money_direction, ');
....