Stored procedure in oracle sql - sql

Question

I'm trying to do a very simple stored procedure for a class project. I just want to use it to execute a simple insert statement.
What I have is:
CREATE OR REPLACE PROCEDURE insertSpa (p_spaID IN INTEGER, s_sdate IN VARCHAR2, p_address IN VARCHAR2)
AS
BEGIN
INSERT INTO spa( spaID,sdate,address)
VALUES (p_spaid, p_sdate, p_address);
END;
/
And then to call it, I've been using:
exec insertSpa( p_spaID => 9999, p_sDate => '12122012', p_address => '1234 Main St. 12345' );
When I try and run the first portion, I get an error that says "Procedure created with compilation errors." Here is what the spa relation is:
SPAID : NOT NULL NUMBER(38)
SDATE : VARCHAR2(8)
ADDRESS : VARCHAR2(100)

Answer 1

It appears that, among other things, you are trying to use SQL Server's T-SQL syntax in Oracle rather than PL/SQL. I'm guessing that spaid is intended to be an integer, sdate is intended to be an integer (though since it appears to represent a date, it really ought to be defined as a date), and address is intended to be a string. I'm also guessing that the spa table has three columns spaID, sDate, and address. If those guesses are accurate, something like
CREATE OR REPLACE PROCEDURE insertSpa( p_spaID IN INTEGER,
p_sdate IN INTEGER,
p_address IN VARCHAR2 )
AS
BEGIN
INSERT INTO spa( spaID, sDate, address )
VALUES( p_spaID, p_sdate, p_address );
END;
should compile. You would then call it
SQL> exec insertSpa( p_spaID => 9999, -
p_sDate => 12122012, -
p_address => '1234 Main St. 12345' );
The error that you are getting seems to imply that you never created the stored procedure. Did you actually run the CREATE PROCEDURE statement? It sounds like maybe you just created the script on your local client machine but then never executed it to create the procedure. You can run the CREATE PROCEDURE statement directly in SQL*Plus. Or you can save it to a file and execute the script in SQL*Plus
SQL> #<<name of .sql script>>

Answer 2

Presumably, from what you've shown, the procedure compiles OK, and it's the exec - which is just shorthand for an anonymous block - that says there is an error. It would have been helpful if you'd shown the error stack. (If the procedure, or any named blocked, said it had a compilation error, you could get the details with show errors, or by selecting from the user_errors view).
You created your procedure with the second parameter named s_sdate:
CREATE OR REPLACE PROCEDURE insertSpa (p_spaID IN INTEGER,
s_sdate IN VARCHAR2, p_address IN VARCHAR2)
... but when you call it you're saying the name is p_sDate:
exec insertSpa( p_spaID => 9999, p_sDate => '12122012', ...
The names have to match. Given the other names, presumably the procedure declaration should change to p_sDate. Actually, you have a mismatch between the procedure declaration and where you're using it in the procedure, so you'd get both errors - on compile and on exec - so you should definitely change it in the declaration. I missed that you'd said you had a procedure compilation, somehow.