I am trying to create a stored procedure but it is giving me an error while executing it.
Msg 156, Level 15, State 1, Procedure SignupUser, Line 13
Incorrect syntax near the keyword 'User'.
My stored procedure is:
CREATE PROCEDURE SignupUser
(
#FirstName nvarchar(25),
#LastName nvarchar(25),
#Email nvarchar(50),
#Password nvarchar(25),
#Mobile nvarchar(20),
#City nvarchar(25),
#StateProvince nvarchar(25),
#Country nvarchar(25),
#Type nvarchar(1),
#DateOfJoining Datetime
)
AS
INSERT INTO User
(
FirstName,LastName,Email,Password,
Mobile,City,StateProvince,Country,Type,DateOfJoining
)
VALUES
(
#FirstName,#LastName,#Email,#Password,
#Mobile,#City,#StateProvince,#Country,#Type,#DateOfJoining
)
USER is a reserved keyword in SQL Server. Use square brackets around it:
CREATE PROCEDURE SignupUser
(
#FirstName nvarchar(25),
#LastName nvarchar(25),
#Email nvarchar(50),
#Password nvarchar(25),
#Mobile nvarchar(20),
#City nvarchar(25),
#StateProvince nvarchar(25),
#Country nvarchar(25),
#Type nvarchar(1),
#DateOfJoining Datetime
)
AS
INSERT INTO [User]
(
FirstName,LastName,Email,Password,
Mobile,City,StateProvince,Country,Type,DateOfJoining
)
VALUES
(
#FirstName,#LastName,#Email,#Password,
#Mobile,#City,#StateProvince,#Country,#Type,#DateOfJoining
)
end
USER is a keyword in SQL you need to put brackets around table or column names are are keywords in SQL. Like this:
[USER] or [GRANT]
Related
I learned about storing password in SQL server database with HASHING and Salt. This code was online and had no really useful comment section for it so I want to ask here.
Why is #salt cast as NVARCHAR(36) here?
I tried different lengths like NVARCHAR(50) and in the database, Salt is still saved as a string of length 36.
For example:
B25243D7-A126-48A8-90F2-5898572F54D2
E29E1CEF-DBE1-4373-9510-A911BA0C8672
CREATE TABLE dbo.[User1]
(
UserID INT IDENTITY(1,1) NOT NULL,
LoginName NVARCHAR(40) NOT NULL,
PasswordHash BINARY(64) NOT NULL,
Salt UNIQUEIDENTIFIER,
FirstName NVARCHAR(40) NULL,
LastName NVARCHAR(40) NULL,
CONSTRAINT [PK1_User_UserID] PRIMARY KEY CLUSTERED (UserID ASC)
)
CREATE PROCEDURE dbo.uspAddUser1
#pLogin NVARCHAR(50),
#pPassword NVARCHAR(50),
#pFirstName NVARCHAR(40) = NULL,
#pLastName NVARCHAR(40) = NULL,
#responseMessage NVARCHAR(250) OUTPUT
AS
BEGIN
SET NOCOUNT ON
DECLARE #salt UNIQUEIDENTIFIER=NEWID()
BEGIN TRY
INSERT INTO dbo.[User1] (LoginName, PasswordHash, Salt, FirstName, LastName)
VALUES(#pLogin, HASHBYTES('SHA2_512', #pPassword+CAST(#salt AS NVARCHAR(36))), #salt, #pFirstName, #pLastName)
SET #responseMessage = 'Success'
END TRY
BEGIN CATCH
SET #responseMessage = ERROR_MESSAGE()
END CATCH
END
DECLARE #responseMessage NVARCHAR(250)
EXEC [dbo].[uspAddUser1]
#pLogin = 'admin2',
#pPassword = '123456',
#pFirstName = 'John',
#pLastName = 'Smith',
#responseMessage = #responseMessage OUTPUT
SELECT * FROM [dbo].[User1]
It is because of DECLARE #salt UNIQUEIDENTIFIER=NEWID(). in sql server NEWID() function returns a UNIQUEIDENTIFIER of character length 36
My table is below
CREATE TABLE Customers
(
CustomerID int identity(1,1) not null primary key,
Name varchar(50) not null,
PhoneNumber varchar(20) not null
constraint chk_PhoneNumber check(PhoneNumber not like '%[^0-9]%'),
DoorNo varchar(50) not null,
StreetName varchar(50) not null,
City varchar(50) not null,
Statee varchar(50) not null,
Zipcode int not null
)
My stored procedure:
ALTER PROCEDURE stp_customers_insert
(#customerid int,
#name varchar(50),
#phone varchar(50),
#doorno varchar(50),
#streetname varchar(50),
#city varchar(50),
#state varchar(50),
#zip int)
AS
BEGIN
IF EXISTS (SELECT CustomerID FROM Customers WHERE CustomerID = #customerid)
BEGIN
RAISERROR ('employee id already exists', 1, 1)
END
ELSE
BEGIN
INSERT INTO Customers (Name, PhoneNumber, DoorNo, StreetName, City, Statee, Zipcode)
VALUES (#name, #phone, #doorno, #streetname, #city, #state, #zip)
END
END
Sample call:
exec stp_customers_insert 'ram', '674673932', '122', '5th cross', 'trichy', 'tamilnadu', 620001
I get this error:
Msg 8114, Level 16, State 5, Procedure stp_customers_insert, Line 23
Error converting data type varchar to int.
The problem appears to be that your stored procedure expects 8 parameters:
stp_customers_insert(#customerid int, #name varchar(50), #phone varchar(50),
#doorno varchar(50), #streetname varchar(50), #city varchar(50),
#state varchar(50), #zip int)
but you are only passing 7 parameters when you actually call the proc:
exec stp_customers_insert 'ram','674673932','122','5th cross','trichy','tamilnadu',620001
If you don't know or don't want to perform the duplicate check on the CustomerID, then you could slightly modify your call to just pass NULL:
exec stp_customers_insert NULL, 'ram','674673932','122','5th cross','trichy','tamilnadu',620001
As an aside, if the proc is not even inserting the CustomerID, and this field is auto increment, then I don't see the point of passing it. Instead, you might want to consider using a unique constraint to achieve the same.
exec stp_customers_insert 1,'ram','674673932','122','5thcross','trichy','tamilnadu',620001
You have to pass #customerid value in procedure parameters - then it will execute without error.
In your table structure CustomerID is defined as INT. But as your stored procedure is defined in this format:
stp_customers_insert(#customerid int,#name ....
You are sending ram as value for customerid in
exec stp_customers_insert 'ram','674673932'....
Correct this to:
exec stp_customers_insert '*enter the CustId value here*','ram','674673932'....
Replace *enter the CustId value here* with the CustomerID
Also change:
insert into Customers(Name,PhoneNumber,DoorNo,StreetName,City,Statee,Zipcode) values(#name,#phone,#doorno,#streetname,#city,#state,#zip)
To include CustomerID as:
insert into Customers(CustomerID,Name,PhoneNumber,DoorNo,StreetName,City,Statee,Zipcode) values(#customerid,#name,#phone,#doorno,#streetname,#city,#state,#zip)
I suggest remove #customerid from sp CustomerID is auto increment field so no need to pass any value for CustomerID. It should be like this:
alter procedure stp_customers_insert(#name varchar(50),#phone varchar(50),#doorno varchar(50),#streetname varchar(50),#city varchar(50),#state varchar(50),#zip int)
as
begin
if exists(select CustomerID from Customers where Name = #name ,phone = #phone ,doorno = #doorno ,streetname = #streetname ,city= #city,state= #state , zip = #zip )
begin
raiserror('employee id already exists',1,1)
end
else
begin
insert into Customers(Name,PhoneNumber,DoorNo,StreetName,City,Statee,Zipcode) values(#name,#phone,#doorno,#streetname,#city,#state,#zip)
end
end
exec stp_customers_insert 'ram','674673932','122','5th cross','trichy','tamilnadu',620001
My stored procedure is
SET ANSI_NULLS ON
GO
SET QUOTED_IDENTIFIER ON
GO
ALTER PROCEDURE [dbo].[Customer_Registrations]
#type varchar(50) = null,
#Customer_ID int = null,
#Customer_Name varchar(50) = null,
#Email varchar(50) = null,
#Password varchar(50) = null,
#Mobile varchar(50) = null
AS
BEGIN
SET NOCOUNT ON;
IF #type = 'select'
BEGIN
SELECT *
FROM ssshub..Customer_Master
END
IF #type = 'specific'
BEGIN
SELECT *
FROM ssshub..Customer_Master
WHERE Customer_ID = #Customer_ID
END
IF #type = 'insert'
BEGIN
INSERT INTO [dbo].[Customer_Master]([Customer_Name], [Email],[Password], [Mobile], [SDate])
VALUES ('#Customer_Name', '#Email', '#Password', '#Mobile', CURRENT_TIMESTAMP)
END
END
And my table
This is working fine
This query works fine but when I am trying to insert it using stored procedure it throws an error.
I have an identity specification for customer_id on so no need to insert it
INSERT INTO [dbo].[Customer_Master] ([Customer_Name], [Email], [Password], [Mobile], [SDate])
VALUES('ewcewc', 'dewdw#dwc.com', 'dewdwd', '9999999999', CURRENT_TIMESTAMP)
Now when I am trying to execute my stored procedure with the following statement
exec customer_registrations 'insert', 'dsad', 'test#test.com', 'pass', '9999900000'
I get:
Error converting data type varchar to int
Lining up your arguments with the parameters:
'insert' -> #type varchar(50)
'dsad' -> #Customer_ID int
'test#test.com' -> #Customer_Name varchar(50)
'pass' -> #Email varchar(50)
'9999900000' -> #Password varchar(50)
-> #Mobile varchar(50) = null
...you can see that 'dsad' has no way of being understood as an int. Maybe there's a problem elsewhere as well, but at the very least, the stored procedure is not being called correctly.
Update:
If your intent was to omit some arguments that aren't relevant in a certain case, you have to use named parameters; otherwise, arguments can only be applied in the same order the parameters appear:
exec customer_registrations
'insert',
#Customer_Name = 'dsad',
#Email = 'test#test.com',
#Password = 'pass',
#Mobile = '9999900000';
Please pass null value in procedure while you insert the data in table. Run the procedure below way while inserting data in table. you should me manage all the parameter of procedure. you are not passed value of Customer_ID, so that's way error occur.
EXEC [dbo].[Customer_Registrations] 'insert',null,'ewcewc', 'dewdw#dwc.com', 'dewdwd', '9999999999'
Create Database Test
Create Table Employee
(
EmpId int identity(1,1) not null primary Key,
EmpName varchar(50),
Address varchar(50),
MobileNo int
)
Select * From [dbo].[Employee]
Alter Table [dbo].[Employee] Alter Column MobileNo Bigint
Insert into [dbo].[Employee] values('Harsh Kumar','Banglore','9748342075')
Create Proc MyProc
As
Select * From [dbo].[Employee]
EXEC MyProc
Create Proc SP_GetEmp
#EmpId int,
#EmpName varchar(50),
#Address varchar(50),
#MobileNo int
As
Insert into [dbo].[Employee](EmpId, EmpName, Address, MobileNo) Values(#EmpId, #EmpName, #Address, #MobileNo)
EXEC SP_GetEmp 'Rahul Kr','Pune', 8250707544
EXEC MyProc
Error:- Error converting data type varchar to int.
It returns null, why? The IDENT_CURRENT part but it works well with Scope_Identity, why ?
ALTER PROCEDURE [dbo]. [InsertComplaints]
#ComplaintCode varchar(50),
#ComplaintType_ID smallint,
#RecievingMode_ID smallint,
#Subject varchar(100),
#ComplainantID smallint,
#District_ID smallint,
#AddressedTo varchar(50),
#DiaryNo varchar(50),
#User_ID int,
#Status_ID smallint,
#RecievedDate smalldatetime,
#IGRemarks varchar(MAX) = null,
#PsoRemarks varchar(MAX) =null,
#FinalDecision varchar(250)=null,
#AgainstDist_ID smallint,
#HomePS_ID smallint,
#AgainstPS_ID smallint,
#Name varchar(75),
#DesigID int,
#ForwardedBy smallint,
#SMS_ID int = 0,
#result bit output,
#ID int output
AS
BEGIN
Begin Try
insert into dbo.Complaints
values (
#ComplaintCode,
#ComplaintType_ID,
#RecievingMode_ID ,
#Subject,
#ComplainantID ,
#District_ID ,
#AddressedTo ,
#DiaryNo,
#User_ID,
#Status_ID,
#RecievedDate,
#IGRemarks,
#PsoRemarks,
#FinalDecision,
#AgainstDist_ID,
#HomePS_ID,
#AgainstPS_ID,
#Name ,
#DesigID,
#ForwardedBy,
#SMS_ID
)
Set #result = ##ROWCOUNT
Set #ID = IDENT_CURRENT('ComplaintID') --SCOPE_IDENTITY()
Select #ID
End Try
Begin Catch
Set #result=0
End Catch
END
I want to get a last inserted id from particular table such that complaintID from complaints table but it doesn't return any but null. Help !
According to msdn the IDENT_CURRENT function will return null if the calling user does not have enough permissions on this object.
Another possibility is that your object name is wrong, i see you're doing your insert with the dbo prefix. Maybe that will help.
Hi I have created a Table in which I am storing first name, last name and email ID of some persons.
The table is as follows:
create table frnds
(
id int Primary Key,
firstName varchar (20) not null,
lastName varchar (20) not null,
emailID varchar (30)not null
)
I have to write a Stored Procedure to return the "first name" values from the table wherever there is a match with the input "last name" value.
I have some of the names with common last names. So I want to have all the first names as the output of the Stored Procedure.
I am using the following code to do that but have been able to get only one matching first name as output.
Create Procedure GetFirstName
(
#lastName varchar(20),
#firstName varchar(20) OUT
)
AS
Begin
Select #firstName = firstName from frnds where lastName = #lastName
End
Also this is how I am displaying the result:
declare #LastName varchar (20)
Exec GetFirstName Daniels, #LastName output
select #LastName
I know that this is because I have the output parameter such that it can hold only one matching first name. Since I am new to SQL, I am not able to figure out how to achieve this. Please help with any suggestion or some link which can guide me in the right direction.
Thanks!!!
You can use temporary table do store the varchars.
First create your procedure like this:
Create table #temp
(
fisrtName varchar(20) not null
)
go
Create Procedure GetFirstName
(
#lastName varchar(20)
-- , #firstName varchar(20) OUT with my solution you don't need it
)
AS
Begin
insert into #temp
Select firstName from frnds where lastName = #lastName
End
go
drop table #temp
Then you can use it as below
Create table #temp
(
fisrtName varchar(20) not null
)
exec GetFirstName 'Daniels'
select * from #temp
Try this
Create Procedure GetFirstName
(
#lastName varchar(20),
#firstName varchar(20) OUT
)
AS
Begin
Select firstName from frnds where lastName = #lastName
End
Create table #lastname(lastname varchar (20))
Insert into #lastname
Exec GetFirstName 'Daniels'
select * from #lastname
CREATE FUNCTION [myschema].[returnLastNames]
(
#lastName varchar(20),
)
RETURNS TABLE
AS
RETURN SELECT firstName from frnds where lastName = #lastName;
A function might be better here maybe?
Use it like f.ex.:
SELECT * FROM myschema.returnLastNames('Stevensson');
IF OBJECT_ID('usp_GetFirstName', 'P') IS NOT NULL
DROP PROCEDURE usp_GetFirstName;
GO
Create Procedure usp_GetFirstName
(
#lastName varchar(20),
#firstName varchar(20) OUTPUT
)
AS
Begin
SET NOCOUNT ON;
Select #firstName = firstName from frnds where lastName = #lastName;
RETURN
End
GO
DECLARE #Person varchar(20);
EXECUTE usp_GetFirstName
N'Daniels',#lastName = #Person OUTPUT;
PRINT 'LAST NAme IS' + #Person;
GO