while passing parameter in stored procedure getting error - sql

Question

alter procedure [dbo].[ParkingDeatailsReport]
as
begin
DECLARE #cols AS NVARCHAR(MAX),
#query AS NVARCHAR(MAX),
#locid INTEGER
select #cols = STUFF((SELECT distinct ',' + QUOTENAME(Vtype)
from VType_tbl
FOR XML PATH(''), TYPE).value('.', 'NVARCHAR(MAX)'), 1, 1, '')
set #query = 'SELECT Date, ' + #cols + '
from
(
select v.Vtype, convert(date, dtime) as Date
from Transaction_tbl t
inner join VType_tbl v on t.vtid = v.vtid
where locid = ' + CAST(#locid as varchar(max)) + ') d
pivot
(
count(Vtype)
for Vtype in (' + #cols + ')
) p '
execute(#query)
end

Answer 1

Notice the difference between #cols and #locid in dynamic SQL.
Replace
where locid = #locid
With
where locid = ' + CAST(#locid as varchar(max)) + '
Note: while this is a quick fix please see answer from RBarryYoung for best practice with dynamic SQL.

Answer 2

the error clearly say, your current SP code not accepting any parameters and you trying to pas parameters to SP. if you want to accept parameters in SP, syntax is:
Create Procedure Procedure-name
(
Input parameters ,
Output Parameters (If required)
)
As
Begin
Sql statement used in the stored procedure
End
So in your case SP can be change to :
alter procedure [dbo].[ParkingDeatailsReport]
(
#cols AS NVARCHAR(MAX),
#query AS NVARCHAR(MAX),
#locid INTEGER
)
as
begin
..... you code go hear
END