WebRTC + JSEP + Google Channel API - cannot receive remoteStream - webrtc
I've been trying to get this works, but I don't know what's wrong, can you guys help me? I tried WebRTC code with modification like this.
Both caller and callee enter the web
Web will create channel based on their username
Caller clicks the call button and sends message to spesific channel to some user's username. When caller clicks the call button, he then creates peerConnection and adds localStream
Callee will receive message, and the process goes on like WebRTC sample code. When callee receives an offer, he then creates peerConnection and adds localStream, then creates and sends answer
My code goes like this
var my_username = '{{ current_username }}';
var friend;
var localVideo;
var remoteVideo;
var localStream;
var remoteStream;
var channel;
var channelReady = false;
var pc;
var socket;
var started = false;
// Set up audio and video regardless of what devices are present.
var mediaConstraints = {'mandatory': {
'OfferToReceiveAudio':true,
'OfferToReceiveVideo':true }};
var isVideoMuted = false;
var isAudioMuted = false;
function choiceFriendInitialize() {
var choice_visible = false;
$('ul#friendlist > li').click(function(e) {
$(this).css('background-color', '#808080');
friend = $(this).text();
var choice = $('ul#choice');
choice_visible = true;
choice.css('display', 'inline-block');
choice.css('top', e.pageY);
choice.css('left', e.pageX);
});
// trigger call from here
$('li#call').click(function() {
$('ul#friendlist > li').css('background-color', 'transparent');
$('ul#choice').css('display', 'none');
choice_visible = false;
// call
maybeStart();
doCall();
});
$('li#unfriend').click(function() {
$('ul#friendlist > li').css('background-color', 'transparent');
$('ul#choice').css('display', 'none');
choice_visible = false;
});
$("body").mouseup(function(){
if (choice_visible) {
$('ul#friendlist > li').css('background-color', 'transparent');
$('ul#choice').css('display', 'none');
choice_visible = false;
}
});
}
function initialize() {
console.log("Initializing..");
choiceFriendInitialize();
localVideo = document.getElementById("localVideo");
remoteVideo = document.getElementById("remoteVideo");
openChannel();
doGetUserMedia();
}
function openChannel() {
console.log("Opening channel.");
var channel = new goog.appengine.Channel('{{ token }}');
var handler = {
'onopen': onChannelOpened,
'onmessage': onChannelMessage,
'onerror': onChannelError,
'onclose': onChannelClosed
};
socket = channel.open(handler);
}
function doGetUserMedia() {
// Call into getUserMedia via the polyfill (adapter.js).
var constraints = {"mandatory": {}, "optional": []};
try {
getUserMedia({'audio':true, 'video':constraints}, onUserMediaSuccess, onUserMediaError);
console.log("Requested access to local media with mediaConstraints:\n" + " \"" + JSON.stringify(constraints) + "\"");
} catch (e) {
alert("getUserMedia() failed. Is this a WebRTC capable browser?");
console.log("getUserMedia failed with exception: " + e.message);
}
}
function createPeerConnection() {
var pc_config = {"iceServers": [{"url": "stun:stun.l.google.com:19302"}]};
try {
// Create an RTCPeerConnection via the polyfill (adapter.js).
pc = new RTCPeerConnection(pc_config);
pc.onicecandidate = onIceCandidate;
console.log("Created RTCPeerConnnection with config:\n" + " \"" + JSON.stringify(pc_config) + "\".");
} catch (e) {
console.log("Failed to create PeerConnection, exception: " + e.message);
alert("Cannot create RTCPeerConnection object; WebRTC is not supported by this browser.");
return;
}
pc.onconnecting = onSessionConnecting;
pc.onopen = onSessionOpened;
pc.onaddstream = onRemoteStreamAdded;
pc.onremovestream = onRemoteStreamRemoved;
}
function maybeStart() {
if (!started && localStream && channelReady) {
console.log("Creating PeerConnection.");
createPeerConnection();
console.log("Adding local stream.");
pc.addStream(localStream);
started = true;
// Caller initiates offer to peer.
//if (initiator)
//doCall();
}
}
function doCall() {
console.log("Sending offer to peer.");
pc.createOffer(setLocalAndSendMessage, null, mediaConstraints);
}
function doAnswer() {
console.log("Sending answer to peer.");
pc.createAnswer(setLocalAndSendMessage, null, mediaConstraints);
}
function setLocalAndSendMessage(sessionDescription) {
// Set Opus as the preferred codec in SDP if Opus is present.
sessionDescription.sdp = preferOpus(sessionDescription.sdp);
pc.setLocalDescription(sessionDescription);
sendMessage({from: my_username, to: friend}, sessionDescription);
}
function sendMessage(client, message) {
console.log('C->S: ' + JSON.stringify(message));
var xhr = new XMLHttpRequest();
xhr.open('POST', '/send', true);
xhr.setRequestHeader("Content-type","application/json");
var msgString = {send_info: client, data_message: message};
xhr.send(JSON.stringify(msgString));
}
function processSignalingMessage(message) {
var msg = JSON.parse(message);
var data_message = msg.data_message;
var send_info = msg.send_info;
if (data_message.type === 'offer') {
// Callee creates PeerConnection
if (!started)
maybeStart();
pc.setRemoteDescription(new RTCSessionDescription(data_message));
friend = send_info.from;
doAnswer();
} else if (data_message.type === 'answer' && started) {
pc.setRemoteDescription(new RTCSessionDescription(data_message));
} else if (data_message.type === 'candidate' && started) {
var candidate = new RTCIceCandidate({sdpMLineIndex:data_message.label, candidate:data_message.candidate});
pc.addIceCandidate(candidate);
} else if (data_message.type === 'bye' && started) {
onRemoteHangup();
}
}
function onChannelOpened() {
console.log('Channel opened.');
channelReady = true;
}
function onChannelMessage(message) {
console.log('S->C: ' + message.data);
processSignalingMessage(message.data);
}
function onChannelError() {
console.log('Channel error.');
}
function onChannelClosed() {
console.log('Channel closed.');
}
function onUserMediaSuccess(stream) {
console.log("User has granted access to local media.");
// Call the polyfill wrapper to attach the media stream to this element.
attachMediaStream(localVideo, stream);
localVideo.style.opacity = 1;
localStream = stream;
// Caller creates PeerConnection.
//if (initiator) maybeStart();
}
function onUserMediaError(error) {
console.log("Failed to get access to local media. Error code was " + error.code);
alert("Failed to get access to local media. Error code was " + error.code + ".");
}
function onIceCandidate(event) {
if (event.candidate) {
sendMessage({from: my_username, to: friend}, {type: 'candidate',
label: event.candidate.sdpMLineIndex,
id: event.candidate.sdpMid,
candidate: event.candidate.candidate});
} else {
console.log("End of candidates.");
}
}
function onSessionConnecting(message) {
console.log("Session connecting.");
}
function onSessionOpened(message) {
console.log("Session opened.");
}
function onRemoteStreamAdded(event) {
console.log("Remote stream added.");
attachMediaStream(remoteVideo, event.stream);
remoteStream = event.stream;
waitForRemoteVideo();
}
function onRemoteStreamRemoved(event) {
console.log("Remote stream removed.");
}
function onHangup() {
console.log("Hanging up.");
transitionToDone();
stop();
// will trigger BYE from server
socket.close();
}
function onRemoteHangup() {
console.log('Session terminated.');
transitionToWaiting();
stop();
}
function stop() {
started = false;
isAudioMuted = false;
isVideoMuted = false;
pc.close();
pc = null;
}
function waitForRemoteVideo() {
if (remoteStream.videoTracks.length === 0 || remoteVideo.currentTime > 0) {
console.log('ada remote stream');
transitionToActive();
} else {
console.log('ga ada remote stream');
setTimeout(waitForRemoteVideo, 100);
}
}
function transitionToActive() {
remoteVideo.style.opacity = 1;
}
function transitionToWaiting() {
remoteVideo.style.opacity = 0;
}
function transitionToDone() {
localVideo.style.opacity = 0;
remoteVideo.style.opacity = 0;
}
function toggleVideoMute() {
if (localStream.videoTracks.length === 0) {
console.log("No local video available.");
return;
}
if (isVideoMuted) {
for (i = 0; i < localStream.videoTracks.length; i++) {
localStream.videoTracks[i].enabled = true;
}
console.log("Video unmuted.");
} else {
for (i = 0; i < localStream.videoTracks.length; i++) {
localStream.videoTracks[i].enabled = false;
}
console.log("Video muted.");
}
isVideoMuted = !isVideoMuted;
}
function toggleAudioMute() {
if (localStream.audioTracks.length === 0) {
console.log("No local audio available.");
return;
}
if (isAudioMuted) {
for (i = 0; i < localStream.audioTracks.length; i++) {
localStream.audioTracks[i].enabled = true;
}
console.log("Audio unmuted.");
} else {
for (i = 0; i < localStream.audioTracks.length; i++){
localStream.audioTracks[i].enabled = false;
}
console.log("Audio muted.");
}
isAudioMuted = !isAudioMuted;
}
setTimeout(initialize, 1);
// Send BYE on refreshing(or leaving) a demo page
// to ensure the room is cleaned for next session.
window.onbeforeunload = function() {
sendMessage({from: my_username, to: friend}, {type: 'bye'});
//Delay 100ms to ensure 'bye' arrives first.
setTimeout(function(){}, 100);
}
// Ctrl-D: toggle audio mute; Ctrl-E: toggle video mute.
// On Mac, Command key is instead of Ctrl.
// Return false to screen out original Chrome shortcuts.
document.onkeydown = function() {
if (navigator.appVersion.indexOf("Mac") != -1) {
if (event.metaKey && event.keyCode === 68) {
toggleAudioMute();
return false;
}
if (event.metaKey && event.keyCode === 69) {
toggleVideoMute();
return false;
}
} else {
if (event.ctrlKey && event.keyCode === 68) {
toggleAudioMute();
return false;
}
if (event.ctrlKey && event.keyCode === 69) {
toggleVideoMute();
return false;
}
}
}
// Set Opus as the default audio codec if it's present.
function preferOpus(sdp) {
var sdpLines = sdp.split('\r\n');
// Search for m line.
for (var i = 0; i < sdpLines.length; i++) {
if (sdpLines[i].search('m=audio') !== -1) {
var mLineIndex = i;
break;
}
}
if (mLineIndex === null)
return sdp;
// If Opus is available, set it as the default in m line.
for (var i = 0; i < sdpLines.length; i++) {
if (sdpLines[i].search('opus/48000') !== -1) {
var opusPayload = extractSdp(sdpLines[i], /:(\d+) opus\/48000/i);
if (opusPayload)
sdpLines[mLineIndex] = setDefaultCodec(sdpLines[mLineIndex], opusPayload);
break;
}
}
// Remove CN in m line and sdp.
sdpLines = removeCN(sdpLines, mLineIndex);
sdp = sdpLines.join('\r\n');
return sdp;
}
function extractSdp(sdpLine, pattern) {
var result = sdpLine.match(pattern);
return (result && result.length == 2)? result[1]: null;
}
// Set the selected codec to the first in m line.
function setDefaultCodec(mLine, payload) {
var elements = mLine.split(' ');
var newLine = new Array();
var index = 0;
for (var i = 0; i < elements.length; i++) {
if (index === 3) // Format of media starts from the fourth.
newLine[index++] = payload; // Put target payload to the first.
if (elements[i] !== payload)
newLine[index++] = elements[i];
}
return newLine.join(' ');
}
// Strip CN from sdp before CN constraints is ready.
function removeCN(sdpLines, mLineIndex) {
var mLineElements = sdpLines[mLineIndex].split(' ');
// Scan from end for the convenience of removing an item.
for (var i = sdpLines.length-1; i >= 0; i--) {
var payload = extractSdp(sdpLines[i], /a=rtpmap:(\d+) CN\/\d+/i);
if (payload) {
var cnPos = mLineElements.indexOf(payload);
if (cnPos !== -1) {
// Remove CN payload from m line.
mLineElements.splice(cnPos, 1);
}
// Remove CN line in sdp
sdpLines.splice(i, 1);
}
}
sdpLines[mLineIndex] = mLineElements.join(' ');
return sdpLines;
}
When it comes to waitForRemoteVideo, the function calls the else condition. But the blob url for remoteVideo exists.
It's funny that I've been searching for the error and re-writing the code for like three times, and suddenly after posted my question here, I realized my mistake.
Here in the function processSignallingMessage..
if (data_message.type === 'offer') {
// Callee creates PeerConnection
if (!started)
maybeStart();
pc.setRemoteDescription(new RTCSessionDescription(data_message));
friend = send_info.from;
doAnswer();
} else ....
Should be like this:
if (data_message.type === 'offer') {
friend = send_info.from;
// Callee creates PeerConnection
if (!started)
maybeStart();
pc.setRemoteDescription(new RTCSessionDescription(data_message));
doAnswer();
} else ....
because callee need variable friend to be filled before sending candidate message.
Related
Dynamically addTrack to offerer from answerer onnegotiationneeded in webrtc
Is there anyway to notify offerer that non-existing track before just added to get the new stream from the answerer from the code below? For my current issue now here is that the offerer can add new non-existing track and onnegotiationneeded will be fired and will also be able to createOffer and update media successfully, but when answerer do same process onnegotiationneeded fired normally also from the answerer but no media will be exchanged just because offerer do not have any new track on his end! I use replaceOrAddTrack(remotePartiID, track, TrackKind) in adding and replacing of tracks Only the replace works with either ends if it has same track kind from initial connection _cfg = { sdpConstraints: { mandatory: { OfferToReceiveAudio: true, OfferToReceiveVideo: true, VoiceActivityDetection: true, IceRestart: true }, optional: [] } ... }; var channels_wrap = (function() { return { ... init: function() { _cfg.defaultChannel.on('message', (message) => { if (_cfg.enableLog) { console.log('Client received message:', message); } if (message.type === 'newparticipant') { var partID = message.from; var partData = message.fromData; // Open a new communication channel to the new participant _cfg.offerChannels[partID] = this.openSignalingChannel(partID); // Wait for answers (to offers) from the new participant _cfg.offerChannels[partID].on('message', (msg) => { if (msg.dest === _cfg.myID) { if (msg.type === 'reoffer') { if (_cfg.opc.hasOwnProperty(msg.from)) { console.log('reoffering') _cfg.opc[msg.from].negotiationNeeded(); } } else if (msg.type === 'answer') { _cfg.opc[msg.from].peer.setRemoteDescription(new RTCSessionDescription(msg.snDescription), handlers_wrap.setRemoteDescriptionSuccess, handlers_wrap.setRemoteDescriptionError); } else if (msg.type === 'candidate') { var candidate = new RTCIceCandidate({ sdpMLineIndex: msg.label, candidate: msg.candidate }); if (_cfg.enableLog) { console.log('got ice candidate from ' + msg.from); } _cfg.opc[msg.from].peer.addIceCandidate(candidate, handlers_wrap.addIceCandidateSuccess, handlers_wrap.addIceCandidateError); } } }); // Send an offer to the new participant dialogs_wrap.createOffer(partID, partData); } else if (message.type === 'bye') { handlers_wrap.hangup(message.from, message.fromData); } }); }, initPrivateChannel: function() { // Open a private channel (namespace = _cfg.myID) to receive offers _cfg.privateAnswerChannel = this.openSignalingChannel(_cfg.myID); // Wait for offers or ice candidates _cfg.privateAnswerChannel.on('message', (message) => { if (message.dest === _cfg.myID) { if (message.type === 'offer') { var to = message.from; dialogs_wrap.createAnswer(message.snDescription, _cfg.privateAnswerChannel, to, message.fromData); } else if (message.type === 'candidate') { var candidate = new RTCIceCandidate({ sdpMLineIndex: message.label, candidate: message.candidate }); _cfg.apc[message.from].peer.addIceCandidate(candidate, handlers_wrap.addIceCandidateSuccess, handlers_wrap.addIceCandidateError); } } }); } }; })(); var tracks_wrap = (function() { return { getParticipants: function(partID = null) { var participants = {}; if (partID) { if (_cfg.opc.hasOwnProperty(partID)) { participants[partID] = { ID: partID, type: 'opc' }; } else if (_cfg.apc.hasOwnProperty(partID)) { participants[partID] = { ID: partID, type: 'apc' }; } } else { for (let key in _cfg.opc) { participants[key] = { ID: key, type: 'opc' }; } for (let key in _cfg.apc) { participants[key] = { ID: key, type: 'apc' }; } } return participants; }, replaceOrAddTrack: function(remotePartiID, track, TrackKind) { if (!TrackKind) { return; } var participants = this.getParticipants(remotePartiID); for (var partiID in participants) { var peer = null; if (participants[partiID].type === 'apc' && _cfg.apc.hasOwnProperty(partiID)) { peer = _cfg.apc[partiID].peer; } else if (participants[partiID].type === 'opc' && _cfg.opc.hasOwnProperty(partiID)) { peer = _cfg.opc[partiID].peer; } else { continue; } var foundTrack = null; peer.getSenders().forEach(function(rtpSender) { if (rtpSender.track && TrackKind === rtpSender.track.kind) { foundTrack = true; rtpSender.replaceTrack(track); } }); if (!foundTrack) { peer.addTrack(track, _cfg.localStream); //This work only if it is offerrer that add track but not working with answerer even if i tell the offerer to send offer again } } } }; })(); var dialogs_wrap = (function() { return { /** * * Send an offer to peer with id partID and metadata as partData * */ createOffer: function(partID, partData) { if (_cfg.enableLog) { console.log('Creating offer for peer ' + partID, partData); } var opcPeer = new RTCPeerConnection(_cfg.pcConfig, _cfg.peerSetup); _cfg.opc[partID] = {}; _cfg.opc[partID].peer = opcPeer; _cfg.opc[partID].peer.onicecandidate = handlers_wrap.handleIceCandidateAnswer(_cfg.offerChannels[partID], partID, partData); _cfg.opc[partID].peer.ontrack = handlers_wrap.handleRemoteStreamAdded(partID, partData); _cfg.opc[partID].peer.onremovetrack = handlers_wrap.handleRemoteStreamRemoved(partID, partData); _cfg.localStream.getTracks().forEach(track => _cfg.opc[partID].peer.addTrack(track, _cfg.localStream)); try { _cfg.sendChannel[partID] = _cfg.opc[partID].peer.createDataChannel("sendDataChannel", { reliable: false }); _cfg.sendChannel[partID].onmessage = handlers_wrap.handleMessage; if (_cfg.enableLog) { console.log('Created send data channel'); } } catch (e) { alert('Failed to create data channel. \n You need supported RtpDataChannel enabled browser'); console.log('createDataChannel() failed with exception: ', e.message); } _cfg.sendChannel[partID].onopen = handlers_wrap.handleSendChannelStateChange(partID); _cfg.sendChannel[partID].onclose = handlers_wrap.handleSendChannelStateChange(partID); var onSuccess = (partID, partData) => { var channel = _cfg.offerChannels[partID]; if (_cfg.enableLog) { console.log('Sending offering'); } channel.emit('message', { snDescription: _cfg.opc[partID].peer.localDescription, from: _cfg.myID, fromData: _cfg.myData, type: 'offer', dest: partID, destData: partData }); } _cfg.opc[partID].negotiationNeeded = () => { _cfg.opc[partID].peer.createOffer(_cfg.sdpConstraints).then(offer => { offer.sdp = sdp_wrap.SDPController(offer.sdp); return _cfg.opc[partID].peer.setLocalDescription(offer) }) .then(() => onSuccess(partID, partData)).catch(handlers_wrap.handleCreateOfferError); } _cfg.opc[partID].peer.onnegotiationneeded = () => { _cfg.opc[partID].negotiationNeeded(); } }, createAnswer: function(snDescription, cnl, to, toData) { if (_cfg.enableLog) { console.log('Creating answer for peer ' + to); } if (!_cfg.apc.hasOwnProperty(to)) { var apcPeer = new RTCPeerConnection(_cfg.pcConfig, _cfg.peerSetup); //apcPeer.setConfiguration(_cfg.pcConfig); _cfg.apc[to] = {}; _cfg.apc[to].peer = apcPeer; _cfg.apc[to].peer.onicecandidate = handlers_wrap.handleIceCandidateAnswer(cnl, to, toData); _cfg.apc[to].peer.ontrack = handlers_wrap.handleRemoteStreamAdded(to, toData); _cfg.apc[to].peer.onremovetrack = handlers_wrap.handleRemoteStreamRemoved(to, toData); _cfg.localStream.getTracks().forEach(track => _cfg.apc[to].peer.addTrack(track, _cfg.localStream)); _cfg.apc[to].peer.ondatachannel = handlers_wrap.gotReceiveChannel(to); } _cfg.apc[to].peer.setRemoteDescription(new RTCSessionDescription(snDescription), handlers_wrap.setRemoteDescriptionSuccess, handlers_wrap.setRemoteDescriptionError); var onSuccess = (channel) => { if (_cfg.enableLog) { console.log('Sending answering'); } channel.emit('message', { snDescription: _cfg.apc[to].peer.localDescription, from: _cfg.myID, fromData: _cfg.myData, type: 'answer', dest: to, destData: toData }); } _cfg.apc[to].peer.createAnswer().then(function(answer) { answer.sdp = sdp_wrap.SDPController(answer.sdp); return _cfg.apc[to].peer.setLocalDescription(answer); }) .then(() => onSuccess(cnl)) .catch(handlers_wrap.handleCreateAnswerError); var negotiationNeeded = false; _cfg.apc[to].peer.onnegotiationneeded = (ev) => { if (!negotiationNeeded) { negotiationNeeded = true; return; } //So i tried to create this to tell the offerer to do offer again, offerer do resend offer but nothing seem to happen cnl.emit('message', { from: _cfg.myID, fromData: _cfg.myData, type: 'reoffer', dest: to, destData: toData }); } } }; })();
Webrtc video chat not working in different networks
I am trying to implement video chat with webrtc using code from google code labs . It works fine on same network but does not work on different network. i have installed coturn on my server. I am not sure if it is working correctly. Any one used google codelabs code and made it working? This is the modified main.js file 'use strict'; var isChannelReady = false; var isInitiator = false; var isStarted = false; var localStream; var pc; var remoteStream; var turnReady; var pcConfig = { "iceServers":[ {'urls': 'stun:stun.l.google.com:19302'}, {"urls":["turn:78.129.167.90"],"username":"wyzturner1","credential":"wyzturnp2ss"}] }; // Set up audio and video regardless of what devices are present. var sdpConstraints = { offerToReceiveAudio: true, offerToReceiveVideo: true }; ///////////////////////////////////////////// var room = 'foo'; // Could prompt for room name: // room = prompt('Enter room name:'); var socket = io.connect('https://www.samplesite.com:8080'); if (room !== '') { socket.emit('create or join', room); console.log('Attempted to create or join room', room); } socket.on('created', function(room) { console.log('Created room ' + room); isInitiator = true; }); socket.on('full', function(room) { console.log('Room ' + room + ' is full'); }); socket.on('join', function (room){ console.log('Another peer made a request to join room ' + room); console.log('This peer is the initiator of room ' + room + '!'); isChannelReady = true; }); socket.on('joined', function(room) { console.log('joined: ' + room); isChannelReady = true; }); socket.on('log', function(array) { console.log.apply(console, array); }); //////////////////////////////////////////////// function sendMessage(message) { console.log('Client sending message: ', message); socket.emit('message', message); } // This client receives a message socket.on('message', function(message) { console.log('Client received message:', message); if (message === 'got user media') { maybeStart(); } else if (message.type === 'offer') { if (!isInitiator && !isStarted) { maybeStart(); } pc.setRemoteDescription(new RTCSessionDescription(message)); doAnswer(); } else if (message.type === 'answer' && isStarted) { pc.setRemoteDescription(new RTCSessionDescription(message)); } else if (message.type === 'candidate' && isStarted) { var candidate = new RTCIceCandidate({ sdpMLineIndex: message.label, candidate: message.candidate }); pc.addIceCandidate(candidate); } else if (message === 'bye' && isStarted) { handleRemoteHangup(); } }); //////////////////////////////////////////////////// var localVideo = document.querySelector('#localVideo'); var remoteVideo = document.querySelector('#remoteVideo'); navigator.mediaDevices.getUserMedia({ audio: false, video: true }) .then(gotStream) .catch(function(e) { alert('getUserMedia() error: ' + e.name); }); function gotStream(stream) { console.log('Adding local stream.'); localVideo.src = window.URL.createObjectURL(stream); localStream = stream; sendMessage('got user media'); if (isInitiator) { maybeStart(); } } var constraints = { video: true }; console.log('Getting user media with constraints', constraints); //if (location.hostname !== 'localhost') { // requestTurn( // 'https://computeengineondemand.appspot.com/turn?username=41784574&key=4080218913' // ); //} function maybeStart() { console.log('>>>>>>> maybeStart() ', isStarted, localStream, isChannelReady); if (!isStarted && typeof localStream !== 'undefined' && isChannelReady) { console.log('>>>>>> creating peer connection'); createPeerConnection(); isStarted = true; console.log('isInitiator', isInitiator); if (isInitiator) { doCall(); } } } window.onbeforeunload = function() { sendMessage('bye'); }; ///////////////////////////////////////////////////////// function createPeerConnection() { try { pc = new RTCPeerConnection(pcConfig); pc.addStream(localStream); pc.onicecandidate = handleIceCandidate; pc.onaddstream = handleRemoteStreamAdded; pc.oniceconnectionstatechange = function(){ console.log('ICE state: ',pc.iceConnectionState); } pc.onremovestream = handleRemoteStreamRemoved; console.log('Created RTCPeerConnnection'); } catch (e) { console.log('Failed to create PeerConnection, exception: ' + e.message); alert('Cannot create RTCPeerConnection object.'); return; } } function handleIceCandidate(event) { console.log('icecandidate event: ', event); if (event.candidate) { sendMessage({ type: 'candidate', label: event.candidate.sdpMLineIndex, id: event.candidate.sdpMid, candidate: event.candidate.candidate }); } else { console.log('End of candidates.'); } } function handleRemoteStreamAdded(event) { console.log('Remote stream added.'); remoteVideo.src = window.URL.createObjectURL(event.stream); remoteStream = event.stream; } function handleCreateOfferError(event) { console.log('createOffer() error: ', event); } function doCall() { console.log('Sending offer to peer'); pc.createOffer(setLocalAndSendMessage, handleCreateOfferError); } function doAnswer() { console.log('Sending answer to peer.'); pc.createAnswer().then( setLocalAndSendMessage, onCreateSessionDescriptionError ); } function setLocalAndSendMessage(sessionDescription) { // Set Opus as the preferred codec in SDP if Opus is present. // sessionDescription.sdp = preferOpus(sessionDescription.sdp); pc.setLocalDescription(sessionDescription); console.log('setLocalAndSendMessage sending message', sessionDescription); sendMessage(sessionDescription); } function onCreateSessionDescriptionError(error) { trace('Failed to create session description: ' + error.toString()); } function requestTurn(turnURL) { var turnExists = false; for (var i in pcConfig.iceServers) { if (pcConfig.iceServers[i].urls.substr(0, 5) === 'turn:') { turnExists = true; turnReady = true; break; } } // if (!turnExists) { // console.log('Getting TURN server from ', turnURL); // // No TURN server. Get one from computeengineondemand.appspot.com: // var xhr = new XMLHttpRequest(); // xhr.onreadystatechange = function() { // if (xhr.readyState === 4 && xhr.status === 200) { // var turnServer = JSON.parse(xhr.responseText); // console.log('Got TURN server: ', turnServer); // pcConfig.iceServers.push({ // 'url': 'turn:' + turnServer.username + '#' + turnServer.turn, // 'credential': turnServer.password // }); // turnReady = true; // } // }; // xhr.open('GET', turnURL, true); // xhr.send(); // } } function handleRemoteStreamAdded(event) { console.log('Remote stream added.'); remoteVideo.src = window.URL.createObjectURL(event.stream); remoteStream = event.stream; } function handleRemoteStreamRemoved(event) { console.log('Remote stream removed. Event: ', event); } function hangup() { console.log('Hanging up.'); stop(); sendMessage('bye'); } function handleRemoteHangup() { console.log('Session terminated.'); stop(); isInitiator = false; } function stop() { isStarted = false; // isAudioMuted = false; // isVideoMuted = false; pc.close(); pc = null; } /////////////////////////////////////////// // Set Opus as the default audio codec if it's present. function preferOpus(sdp) { var sdpLines = sdp.split('\r\n'); var mLineIndex; // Search for m line. for (var i = 0; i < sdpLines.length; i++) { if (sdpLines[i].search('m=audio') !== -1) { mLineIndex = i; break; } } if (mLineIndex === null) { return sdp; } // If Opus is available, set it as the default in m line. for (i = 0; i < sdpLines.length; i++) { if (sdpLines[i].search('opus/48000') !== -1) { var opusPayload = extractSdp(sdpLines[i], /:(\d+) opus\/48000/i); if (opusPayload) { sdpLines[mLineIndex] = setDefaultCodec(sdpLines[mLineIndex], opusPayload); } break; } } // Remove CN in m line and sdp. sdpLines = removeCN(sdpLines, mLineIndex); sdp = sdpLines.join('\r\n'); return sdp; } function extractSdp(sdpLine, pattern) { var result = sdpLine.match(pattern); return result && result.length === 2 ? result[1] : null; } // Set the selected codec to the first in m line. function setDefaultCodec(mLine, payload) { var elements = mLine.split(' '); var newLine = []; var index = 0; for (var i = 0; i < elements.length; i++) { if (index === 3) { // Format of media starts from the fourth. newLine[index++] = payload; // Put target payload to the first. } if (elements[i] !== payload) { newLine[index++] = elements[i]; } } return newLine.join(' '); } // Strip CN from sdp before CN constraints is ready. function removeCN(sdpLines, mLineIndex) { var mLineElements = sdpLines[mLineIndex].split(' '); // Scan from end for the convenience of removing an item. for (var i = sdpLines.length - 1; i >= 0; i--) { var payload = extractSdp(sdpLines[i], /a=rtpmap:(\d+) CN\/\d+/i); if (payload) { var cnPos = mLineElements.indexOf(payload); if (cnPos !== -1) { // Remove CN payload from m line. mLineElements.splice(cnPos, 1); } // Remove CN line in sdp sdpLines.splice(i, 1); } } sdpLines[mLineIndex] = mLineElements.join(' '); return sdpLines; }
Trello API add base64 data image as an attachement
I'd like to send base64 image as an attachment to a trello card through the API POST /1/cards/[card id or shortlink]/attachments There's a file field but it does not specify how should look the data there. Refs: https://developers.trello.com/advanced-reference/card#post-1-cards-card-id-or-shortlink-attachments Any idea?
Short answer: Trello's API only works to attach binary data via multipart/form-data. Examples below. Long answer: The Trello API to add attachments and images is frustratingly under-documented. They do have a coffeescript Client.js for those of us using Javascript to simplify all the basic operations: https://trello.com/1/client.coffee Using the vanilla Client.js file I have been able to attach links and text files. While the CURL example shows pulling a binary file in from a hard drive, that doesn't work for those of us completely on a server or client where we don't have permissions to create a file. From a LOT of trial and error, I've determined all binary data (images, documents, etc.) must be attached using multipart/form-data. Here is a jQuery snippet that will take a URL to an item, get it into memory, and then send it to Trello. var opts = {'key': 'YOUR TRELLO KEY', 'token': 'YOUR TRELLO TOKEN'}; var xhr = new XMLHttpRequest(); xhr.open('get', params); // params is a URL to a file to grab xhr.responseType = 'blob'; // Use blob to get the file's mimetype xhr.onload = function() { var fileReader = new FileReader(); fileReader.onload = function() { var filename = (params.split('/').pop().split('#')[0].split('?')[0]) || params || '?'; // Removes # or ? after filename var file = new File([this.result], filename); var form = new FormData(); // this is the formdata Trello needs form.append("file", file); $.each(['key', 'token'], function(iter, item) { form.append(item, opts.data[item] || 'ERROR! Missing "' + item + '"'); }); $.extend(opts, { method: "POST", data: form, cache: false, contentType: false, processData: false }); return $.ajax(opts); }; fileReader.readAsArrayBuffer(xhr.response); // Use filereader on blob to get content }; xhr.send(); I have submitted a new coffeescript for Trello developer support to consider uploading to replace Client.js. It adds a "Trello.upload(url)" that does this work. I've also attached here for convenience in JS form. // Generated by CoffeeScript 1.12.4 (function() { var opts={"version":1,"apiEndpoint":"https://api.trello.com","authEndpoint":"https://trello.com"}; var deferred, isFunction, isReady, ready, waitUntil, wrapper, slice = [].slice; wrapper = function(window, jQuery, opts) { var $, Trello, apiEndpoint, authEndpoint, authorizeURL, baseURL, collection, fn, fn1, i, intentEndpoint, j, key, len, len1, localStorage, location, parseRestArgs, readStorage, ref, ref1, storagePrefix, token, type, version, writeStorage; $ = jQuery; key = opts.key, token = opts.token, apiEndpoint = opts.apiEndpoint, authEndpoint = opts.authEndpoint, intentEndpoint = opts.intentEndpoint, version = opts.version; baseURL = apiEndpoint + "/" + version + "/"; location = window.location; Trello = { version: function() { return version; }, key: function() { return key; }, setKey: function(newKey) { key = newKey; }, token: function() { return token; }, setToken: function(newToken) { token = newToken; }, rest: function() { var args, error, method, params, path, ref, success; method = arguments[0], args = 2 <= arguments.length ? slice.call(arguments, 1) : []; ref = parseRestArgs(args), path = ref[0], params = ref[1], success = ref[2], error = ref[3]; opts = { url: "" + baseURL + path, type: method, data: {}, dataType: "json", success: success, error: error }; if (!$.support.cors) { opts.dataType = "jsonp"; if (method !== "GET") { opts.type = "GET"; $.extend(opts.data, { _method: method }); } } if (key) { opts.data.key = key; } if (token) { opts.data.token = token; } if (params != null) { $.extend(opts.data, params); } if (method === 'UPLOAD' && typeof (params) === "string" && params.length > 5) { var xhr = new XMLHttpRequest(); xhr.open('get', params); xhr.responseType = 'blob'; // Use blob to get the mimetype xhr.onload = function() { var fileReader = new FileReader(); fileReader.onload = function() { var filename = (params.split('/').pop().split('#')[0].split('?')[0]) || params || '?'; // Removes # or ? after filename var file = new File([this.result], filename); var form = new FormData(); form.append("file", file); $.each(['key', 'token'], function(iter, item) { form.append(item, opts.data[item] || 'ERROR! Missing "' + item + '"'); }); $.extend(opts, { method: "POST", data: form, cache: false, contentType: false, processData: false }); return $.ajax(opts); }; fileReader.readAsArrayBuffer(xhr.response); // Use filereader on blob to get content }; xhr.send(); } else { return $.ajax(opts); } }, authorized: function() { return token != null; }, deauthorize: function() { token = null; writeStorage("token", token); }, authorize: function(userOpts) { var k, persistToken, ref, regexToken, scope, v; opts = $.extend(true, { type: "redirect", persist: true, interactive: true, scope: { read: true, write: false, account: false }, expiration: "30days" }, userOpts); regexToken = /[&#]?token=([0-9a-f]{64})/; persistToken = function() { if (opts.persist && (token != null)) { return writeStorage("token", token); } }; if (opts.persist) { if (token == null) { token = readStorage("token"); } } if (token == null) { token = (ref = regexToken.exec(location.hash)) != null ? ref[1] : void 0; } if (this.authorized()) { persistToken(); location.hash = location.hash.replace(regexToken, ""); return typeof opts.success === "function" ? opts.success() : void 0; } if (!opts.interactive) { return typeof opts.error === "function" ? opts.error() : void 0; } scope = ((function() { var ref1, results; ref1 = opts.scope; results = []; for (k in ref1) { v = ref1[k]; if (v) { results.push(k); } } return results; })()).join(","); switch (opts.type) { case "popup": (function() { var authWindow, height, left, origin, receiveMessage, ref1, top, width; waitUntil("authorized", (function(_this) { return function(isAuthorized) { if (isAuthorized) { persistToken(); return typeof opts.success === "function" ? opts.success() : void 0; } else { return typeof opts.error === "function" ? opts.error() : void 0; } }; })(this)); width = 420; height = 470; left = window.screenX + (window.innerWidth - width) / 2; top = window.screenY + (window.innerHeight - height) / 2; origin = (ref1 = /^[a-z]+:\/\/[^\/]*/.exec(location)) != null ? ref1[0] : void 0; authWindow = window.open(authorizeURL({ return_url: origin, callback_method: "postMessage", scope: scope, expiration: opts.expiration, name: opts.name }), "trello", "width=" + width + ",height=" + height + ",left=" + left + ",top=" + top); receiveMessage = function(event) { var ref2; if (event.origin !== authEndpoint || event.source !== authWindow) { return; } if ((ref2 = event.source) != null) { ref2.close(); } if ((event.data != null) && /[0-9a-f]{64}/.test(event.data)) { token = event.data; } else { token = null; } if (typeof window.removeEventListener === "function") { window.removeEventListener("message", receiveMessage, false); } isReady("authorized", Trello.authorized()); }; return typeof window.addEventListener === "function" ? window.addEventListener("message", receiveMessage, false) : void 0; })(); break; default: window.location = authorizeURL({ redirect_uri: location.href, callback_method: "fragment", scope: scope, expiration: opts.expiration, name: opts.name }); } }, addCard: function(options, next) { var baseArgs, getCard; baseArgs = { mode: 'popup', source: key || window.location.host }; getCard = function(callback) { var height, left, returnUrl, top, width; returnUrl = function(e) { var data; window.removeEventListener('message', returnUrl); try { data = JSON.parse(e.data); if (data.success) { return callback(null, data.card); } else { return callback(new Error(data.error)); } } catch (error1) {} }; if (typeof window.addEventListener === "function") { window.addEventListener('message', returnUrl, false); } width = 500; height = 600; left = window.screenX + (window.outerWidth - width) / 2; top = window.screenY + (window.outerHeight - height) / 2; return window.open(intentEndpoint + "/add-card?" + $.param($.extend(baseArgs, options)), "trello", "width=" + width + ",height=" + height + ",left=" + left + ",top=" + top); }; if (next != null) { return getCard(next); } else if (window.Promise) { return new Promise(function(resolve, reject) { return getCard(function(err, card) { if (err) { return reject(err); } else { return resolve(card); } }); }); } else { return getCard(function() {}); } } }; ref = ["GET", "PUT", "POST", "DELETE", "UPLOAD"]; fn = function(type) { return Trello[type.toLowerCase()] = function() { return this.rest.apply(this, [type].concat(slice.call(arguments))); }; }; for (i = 0, len = ref.length; i < len; i++) { type = ref[i]; fn(type); } Trello.del = Trello["delete"]; ref1 = ["actions", "cards", "checklists", "boards", "lists", "members", "organizations", "lists"]; fn1 = function(collection) { return Trello[collection] = { get: function(id, params, success, error) { return Trello.get(collection + "/" + id, params, success, error); } }; }; for (j = 0, len1 = ref1.length; j < len1; j++) { collection = ref1[j]; fn1(collection); } window.Trello = Trello; authorizeURL = function(args) { var baseArgs; baseArgs = { response_type: "token", key: key }; return authEndpoint + "/" + version + "/authorize?" + $.param($.extend(baseArgs, args)); }; parseRestArgs = function(arg) { var error, params, path, success; path = arg[0], params = arg[1], success = arg[2], error = arg[3]; if (isFunction(params)) { error = success; success = params; params = {}; } path = path.replace(/^\/*/, ""); return [path, params, success, error]; }; localStorage = window.localStorage; if (localStorage != null) { storagePrefix = "trello_"; readStorage = function(key) { return localStorage[storagePrefix + key]; }; writeStorage = function(key, value) { if (value === null) { return delete localStorage[storagePrefix + key]; } else { return localStorage[storagePrefix + key] = value; } }; } else { readStorage = writeStorage = function() {}; } }; deferred = {}; ready = {}; waitUntil = function(name, fx) { if (ready[name] != null) { return fx(ready[name]); } else { return (deferred[name] != null ? deferred[name] : deferred[name] = []).push(fx); } }; isReady = function(name, value) { var fx, fxs, i, len; ready[name] = value; if (deferred[name]) { fxs = deferred[name]; delete deferred[name]; for (i = 0, len = fxs.length; i < len; i++) { fx = fxs[i]; fx(value); } } }; isFunction = function(val) { return typeof val === "function"; }; wrapper(window, jQuery, opts); }).call(this); <script src="https://ajax.googleapis.com/ajax/libs/jquery/1.2.3/jquery.min.js"></script>
YouTube OnStateChange with multiple players on the same page
I have multiple YouTube players on a single page inside a banner slider and I want to use the YouTube Player API to control them and do other stuff based on the state of the video's. I have the code below which I'm pretty sure of used to work fine where any state changes where registered. But it doesnt work for me anymore. The YouTube object is still there and I can use it to start and stop a video but the onStateChange event never gets triggered. What is wrong with this code? var YT_ready = (function() { var onReady_funcs = [], api_isReady = false; return function(func, b_before) { if (func === true) { api_isReady = true; for (var i = 0; i < onReady_funcs.length; i++) { onReady_funcs.shift()(); } } else if (typeof func == "function") { if (api_isReady) func(); else onReady_funcs[b_before ? "unshift" : "push"](func); } } })(); function onYouTubePlayerAPIReady() { YT_ready(true); } var players_homepage = {}; YT_ready(function() { $("li.video iframe.youtube").each(function(event) { var frameID_homepage = $(this).attr('id'); if (frameID_homepage) { players_homepage[frameID_homepage] = new YT.Player(frameID_homepage, { events: { 'onStateChange': onPlayerStateChange_homepage } }); } }); }); (function(){ var tag = document.createElement('script'); tag.src = "//www.youtube.com/iframe_api"; var firstScriptTag = document.getElementsByTagName('script')[0]; firstScriptTag.parentNode.insertBefore(tag, firstScriptTag); })(); function onPlayerStateChange_homepage(event) { if (event.data === 0) { // do something on end } else if (event.data === 1) { // do something on play } else if (event.data === 2) { // do something on pause } } function pauseVideo_homepage(previousVideo) { players_homepage[previousVideo].pauseVideo(); } function playVideo_homepage(currentVideo) { players_homepage[currentVideo].playVideo(); }
YouTube in UIWebView only plays once
I have a UIWebView with some YouTube Videos embeded via the iframe code: <iframe width="190" height="102" src="http://www.youtube.com/embed/...?showinfo=0" frameborder="0" allowfullscreen></iframe> When it first loads it is possible to view each video exactly once. After viewing it the area is just black with white "Youtube" in it. Any ideas? Of course reloading the UIWebView after watching a video fixes it, but I don't like this...
I did it! The following Javascript did the job: <script> VideoIDs = new Array(...some ids here...); function getFrameID(id){ var elem = document.getElementById(id); if (elem) { if(/^iframe$/i.test(elem.tagName)) return id; var elems = elem.getElementsByTagName("iframe"); if (!elems.length) return null; for (var i=0; i<elems.length; i++) { if (/^https?:\/\/(?:www\.)?youtube(?:-nocookie)?\.com(\/|$)/i.test(elems[i].src)) break; } elem = elems[i]; if (elem.id) return elem.id; do { id += "-frame"; } while (document.getElementById(id)); elem.id = id; return id; } return null; } var YT_ready = (function(){ var onReady_funcs = [], api_isReady = false; return function(func, b_before){ if (func === true) { api_isReady = true; for (var i=0; i<onReady_funcs.length; i++){ onReady_funcs.shift()(); } } else if(typeof func == "function") { if (api_isReady) func(); else onReady_funcs[b_before?"unshift":"push"](func); } } })(); function onYouTubePlayerAPIReady() { YT_ready(true) } (function(){ var s = document.createElement("script"); s.src = "http://www.youtube.com/player_api"; var before = document.getElementsByTagName("script")[0]; before.parentNode.insertBefore(s, before); })(); var players = new Array(); YT_ready(function() { for(index in VideoIDs) { var frameID = getFrameID(VideoIDs[index]); if (frameID) { players[frameID] = new YT.Player(frameID, { events: { "onStateChange": stateChange } }); } } }); function youtube_parser(url){ var regExp = /^.*((youtu.be\/)|(v\/)|(\/u\/\w\/)|(embed\/)|(watch\?))\??v?=?([^#\&\?]*).*/; var match = url.match(regExp); if (match&&match[7].length==11){ return match[7]; } } function stateChange(event) { if(event.data == YT.PlayerState.ENDED){ document.location = 'callback:finished'; document.getElementById(youtube_parser(event.target.getVideoUrl())).contentWindow.location.reload(true); } } </script>