I don't even know how to write a proper title for this. I kind of cobbled together some routing code based on a bunch of different articles, and now I'm wondering if I've painted myself into a corner.
I've got a NewsArticle model, and I want the links to look like this:
/news # List of all articles
/news/2011 # List of articles published this year
/news/2011/06 # List of articles published this month
/news/2011/06/28 # List of articles published on this day
/news/2011/06/28/my-post-title # Actual article
Ok, going against the Rails way already, but so be it.
I've got routes setup like this:
controller :news_articles, :via => [:get] do
match '/news(/:year/(/:month(/:day)))' => :index, :constraints => { :year => /\d{4}/, :month => /\d{2}/, :day => /\d{2}/ }
match '/news/:year/:month/:day/:id' => :show
end
Note there is no :as declaration. That's because when I do add something like :as => "news_archive" then I end up with news_archive_path which returns something stupid like "/news?year=2010&month=4". So, I excluded that bit and wrote my own path methods in my application helper file:
def news_archive_path(year = nil, month = nil, day = nil)
return "/news" if year.nil?
t = Time.zone.local(year.to_i, month.nil? ? nil : month.to_i, day.nil? ? nil : day.to_i)
if month.nil?
"/news/#{t.year}"
elsif day.nil?
"/news/#{t.year}/#{"%02d" % t.month}"
else
"/news/#{t.year}/#{"%02d" % t.month}/#{"%02d" % t.day}"
end
end
def news_article_path(article)
t = article.published_at.in_time_zone
"#{news_archive_path(t.year, t.month, t.day)}/#{article.friendly_id}"
end
Great, this all works in practice. But now I've run into a problem where I'm testing my controllers and I want to make sure that the right links appear on the rendered templates. (Oh yeah, I'm not keeping separate view tests but instead using render_views in my controller tests.) But the tests are failing with the error undefined methodnews_article_path' for #`.
So, have I just approached this all wrong and painted myself into a corner? Or can I get out of this by somehow including the helper methods in the controller test? Or do I just suck it up for the sake of getting the test to pass and hardcode the links as I expect them to be?
To make news_article_path available you need to do:
class MyClass
include Rails.application.routes.url_helpers
end
Now MyClass#news_article_path will be defined. You can try to include the url_helpers into your test case. I've seen that break recently with "stack level too deep" errors (it creates an infinite recursion of "super" calls in initialize). If it doesn't work, create your own view helpers class and do "MyViewHelper.new.news_article_path" etc.
It's probably not a good idea to be generating the paths by concatenating string in your path helpers. Instead, simply use the url_for() method. Eg:
def news_article_path(article, options = {})
url_for(options.merge(:controller => :articles,
:action => :show,
:id => article.id,
:year => article.year,
:month => article.month,
:day => article.day))
end
(This assumes day, month, year are added as quick methods on your model, eg:
def year
self.published_at.in_time_zone.year
end
For your tests, either include the helper methods via something along these lines: My helper methods in controller - or use the url_for method again.
...That said - as you suggested, testing views within controller tests isn't ideal. :)
Related
I have gmaps4rails working to show all locations. But, I would like to show a map with workorders using their locations. Workorder belongs_to location.
In the workorders controller, this will display all of the locations:
#json = Location.all.to_gmaps4rails
But, this won't display workorder locations:
#json = Workorder.location.all.to_gmaps4rails
This is the view code:
<%= gmaps("markers" => {"data" => #json, "options" => {"list_container" => "markers_list"} }) %>
<strong><ul id="markers_list"> </ul></strong>
belongs_to specifies a one-to-one association with another class (It returns only one entry).
to_gmaps4rails is a method from Enumerable (it expects to be called on an Array).
Also, you can't call the relation directly from the class (it's not a class method, it's an instance method):
Workorder.location.all.to_gmaps4rails
should be:
a_work_order = WOrkorder.first
a_work_order.location
and to use it with to_gmaps4rails
[a_work_order.location].to_a.compact.to_gmaps4rails
It isn't pretty, but it covers both when location is nil and when it returns something.
Is there a way to detect if a form is submitted? Im trying to set a class based on a custom validation something like below example, is that possible?
.control-group{ :class => ("error" if form_is_submitted ) }
Now trying :
.control-group{ :class => ("error" if params[:user][:profile_attributes][:gender] == nil) }
This fails if the form is not submitted because then the params are nill and throws an error
If your form data is submitted through fields with name attributes like user[profile_attributes][gender] (all having the user prefix), you can check if the :user exists in params.
... if params.include?(:user)
If for some reason (like coming from the route) params[:user] is already going to have a value even for GET requests, you can look for a specific form field having a value. For example, you could add a hidden field
<%= f.hidden_field :some_field, :value => true %>
and check for it in your condition
... if params[:user].include?(:some_field)
You can alternatively check if the request is via the POST method
... if request.post?
This works for other methods as well, like request.put? for an update method.
I have the following line in the routes:
match 'area/:area_id/stores', :to => "stores_directory#index", :as => "stores_directory"
I have a form where I can select an area_id as:
<%= form_tag stores_directory_path, :method=>:get do %>
<select id="area_id" name="area_id">
....
</select>
This ads the area_id as a parameter after ?. So, my question is: How would I make it to add it in between area and stores?
I see one solution (not the best maybe, but also quite acceptable). It is possible to write your own middleware to handle this request, but this is the wrong way I believe (in this case).
Instead, use JS redirect
This could be written as a method (example using JQuery):
$('#area_id option').click(function() {
if (this.value) { // check value is not empty
document.location.href = Routes.stores_directory_path({area_id: this.value})
}
});
OR using options_for_select:
options = []
areas.each do |a|
options << [a.to_s, a.id, {:onclick => "document.location.href = Routes.stores_directory_path({area_id: #{a.id}})"}]
end
options_for_select(options)
Here I used js-routes gem for nice url's.
Hope this will be helpful.
I am trying to render a view + layout based on a condition. The following code seems to work but loses access to #objects set upfront. I call this code in a ProfilesController method Show.
#profiles = Profile.where(:user_id => current_user.id).first
if #profile.nil? == true
render :view => "show",
:layout => "application"
else
render :template => "profiles/my_profile",
:layout => "profiles"
end
Gives output:
undefined method `profiles' for nil:NilClass
How could one render based on a condition and still preserve the previous set #objects (in this case the access to #profiles)
Setting layout in view is not the way to go, its not the rails way and was not advised so even if possible. I changed setting layout in controller action and render the right code in my show partial wich complete solved the issue.
I've made an Impressions model, which keeps track of how many "views" a certain photo or event has. It tracks this by remote_url, remote_ip and user_agent. It works the way I want it.
Photos controller:
def show
#photo.impressions.create(:request_url => request.url, :controller_name => controller_name, :action_name => action_name,
:ip_address => request.remote_ip, :user_agent => request.user_agent)
....
And my Events controller:
def show
#event.impressions.create(:request_url => request.url, :controller_name => controller_name, :action_name => action_name,
:ip_address => request.remote_ip, :user_agent => request.user_agent)
....
However, I am thinking of refactoring this (to make the code cleaner). Perhaps creating a method in the Photo and Event models called add_impression. Which does exactly the same thing as above, but encapsulates the functionality of how impressions are created. It would look something like:
Photos controller:
def show
#photo.add_impression(request.url, controller_name, action_name, request.remote_ip, request.user_agent)
....
And my Events controller:
def show
#event.add_impression(request.url, controller_name, action_name, request.remote_ip, request.user_agent)
....
With this approach, I would end up with an add_impression method in the Photo and Event model. Not exactly DRY (Don't Repeat Yourself). I'm considering creating an Impression module to tackle this.
Is this the right approach? Or is there something else that I should be doing?
PS Am not very well tuned with modules yet. So if anyone would like to leave a code snippet or links to articles worth reading. Please do so.
Personally I would make Impression responsible for creating an impression with a class method, as such:
class Impression < ActiveRecord::Base
def self.add_impression impressionable, options
impressionable.impressions.create options
end
end
Then in the controller:
Impression.add_impression #photo, options