I'm new to SQL and I'm stuck. If anyone could please help me out.
I have a stored procedure modifyMobileNo to change a mobile number, where ID and MobileNo are the parameters. Change Sarah Furgerson's number to 3246568413
Table columns:
ID INT NOT NULL
FirstName NVARCHAR(20) NOT NULL
LastName NVARCHAR(20) NOT NULL
HouseUnitLotNum NVARCHAR(5) NOT NULL
Street NVARCHAR(50) NOT NULL
Suburb NVARCHAR(50) NOT NULL
State NVARCHAR(3) NOT NULL
PostCode NCHAR(4) NOT NULL
MobileNo NCHAR(10) NULL
DateOfBirth DATE NOT NULL
Gender NCHAR(10) NOT NULL
Ref NVARCHAR(4) NOT NULL
CREATE PROCEDURE modifyMobileNo #ID INT, #MobileNo NCHAR(10)
AS
SELECT ID, Firstname, LastName, MobileNo
FROM Table
WHERE ID = #ID AND MobileNo = #MobilePNo
BEGIN
Do I need to add more parameters? Sorry, so confused.
Not sure where to start.
BEGIN
SET NOCOUNT ON;
UPDATE Table
SET ID = #ID,
MobileNo = #MobileNo
WHERE
FirstName = #FirstName
AND LastName = #LastName
END
seems like it should be something simple like -
CREATE PROCEDURE modifyMobileNo #ID INT, #MobileNo NCHAR(10)
AS
BEGIN
UPDATE Table
SET MobileNo = #MobileNo
WHERE ID = #ID
END
CREATE TABLE Persons
(
ID int NOT NULL,
ModifiedDate datetime,
FirstName varchar(50),
LastName varchar(50),
EMail varchar(30),
PhoneNumber varchar(15),
PRIMARY KEY (ID)
);
GetX (int IDX)
if the parameter is null returns all the rows of the table ordered by ModifiedDate field in descending order
otherwise returns just the row that matches the ID
What you are wanting is a "catch all" query. For SQL Server, this can be done a couple of ways. Aaron Bertrand writes about it here.
create procedure GetX (#IDX int = null)
as
select
ID
,ModifiedDate
,FirstName
,LastName
,EMail
,PhoneNumber
from Persons
where #IDX is null or ID = #IDX
order by ModifiedDate desc
Then
exec GetX #IDX = 4;
exec GetX #IDX = null;
My table is below
CREATE TABLE Customers
(
CustomerID int identity(1,1) not null primary key,
Name varchar(50) not null,
PhoneNumber varchar(20) not null
constraint chk_PhoneNumber check(PhoneNumber not like '%[^0-9]%'),
DoorNo varchar(50) not null,
StreetName varchar(50) not null,
City varchar(50) not null,
Statee varchar(50) not null,
Zipcode int not null
)
My stored procedure:
ALTER PROCEDURE stp_customers_insert
(#customerid int,
#name varchar(50),
#phone varchar(50),
#doorno varchar(50),
#streetname varchar(50),
#city varchar(50),
#state varchar(50),
#zip int)
AS
BEGIN
IF EXISTS (SELECT CustomerID FROM Customers WHERE CustomerID = #customerid)
BEGIN
RAISERROR ('employee id already exists', 1, 1)
END
ELSE
BEGIN
INSERT INTO Customers (Name, PhoneNumber, DoorNo, StreetName, City, Statee, Zipcode)
VALUES (#name, #phone, #doorno, #streetname, #city, #state, #zip)
END
END
Sample call:
exec stp_customers_insert 'ram', '674673932', '122', '5th cross', 'trichy', 'tamilnadu', 620001
I get this error:
Msg 8114, Level 16, State 5, Procedure stp_customers_insert, Line 23
Error converting data type varchar to int.
The problem appears to be that your stored procedure expects 8 parameters:
stp_customers_insert(#customerid int, #name varchar(50), #phone varchar(50),
#doorno varchar(50), #streetname varchar(50), #city varchar(50),
#state varchar(50), #zip int)
but you are only passing 7 parameters when you actually call the proc:
exec stp_customers_insert 'ram','674673932','122','5th cross','trichy','tamilnadu',620001
If you don't know or don't want to perform the duplicate check on the CustomerID, then you could slightly modify your call to just pass NULL:
exec stp_customers_insert NULL, 'ram','674673932','122','5th cross','trichy','tamilnadu',620001
As an aside, if the proc is not even inserting the CustomerID, and this field is auto increment, then I don't see the point of passing it. Instead, you might want to consider using a unique constraint to achieve the same.
exec stp_customers_insert 1,'ram','674673932','122','5thcross','trichy','tamilnadu',620001
You have to pass #customerid value in procedure parameters - then it will execute without error.
In your table structure CustomerID is defined as INT. But as your stored procedure is defined in this format:
stp_customers_insert(#customerid int,#name ....
You are sending ram as value for customerid in
exec stp_customers_insert 'ram','674673932'....
Correct this to:
exec stp_customers_insert '*enter the CustId value here*','ram','674673932'....
Replace *enter the CustId value here* with the CustomerID
Also change:
insert into Customers(Name,PhoneNumber,DoorNo,StreetName,City,Statee,Zipcode) values(#name,#phone,#doorno,#streetname,#city,#state,#zip)
To include CustomerID as:
insert into Customers(CustomerID,Name,PhoneNumber,DoorNo,StreetName,City,Statee,Zipcode) values(#customerid,#name,#phone,#doorno,#streetname,#city,#state,#zip)
I suggest remove #customerid from sp CustomerID is auto increment field so no need to pass any value for CustomerID. It should be like this:
alter procedure stp_customers_insert(#name varchar(50),#phone varchar(50),#doorno varchar(50),#streetname varchar(50),#city varchar(50),#state varchar(50),#zip int)
as
begin
if exists(select CustomerID from Customers where Name = #name ,phone = #phone ,doorno = #doorno ,streetname = #streetname ,city= #city,state= #state , zip = #zip )
begin
raiserror('employee id already exists',1,1)
end
else
begin
insert into Customers(Name,PhoneNumber,DoorNo,StreetName,City,Statee,Zipcode) values(#name,#phone,#doorno,#streetname,#city,#state,#zip)
end
end
exec stp_customers_insert 'ram','674673932','122','5th cross','trichy','tamilnadu',620001
It returns null, why? The IDENT_CURRENT part but it works well with Scope_Identity, why ?
ALTER PROCEDURE [dbo]. [InsertComplaints]
#ComplaintCode varchar(50),
#ComplaintType_ID smallint,
#RecievingMode_ID smallint,
#Subject varchar(100),
#ComplainantID smallint,
#District_ID smallint,
#AddressedTo varchar(50),
#DiaryNo varchar(50),
#User_ID int,
#Status_ID smallint,
#RecievedDate smalldatetime,
#IGRemarks varchar(MAX) = null,
#PsoRemarks varchar(MAX) =null,
#FinalDecision varchar(250)=null,
#AgainstDist_ID smallint,
#HomePS_ID smallint,
#AgainstPS_ID smallint,
#Name varchar(75),
#DesigID int,
#ForwardedBy smallint,
#SMS_ID int = 0,
#result bit output,
#ID int output
AS
BEGIN
Begin Try
insert into dbo.Complaints
values (
#ComplaintCode,
#ComplaintType_ID,
#RecievingMode_ID ,
#Subject,
#ComplainantID ,
#District_ID ,
#AddressedTo ,
#DiaryNo,
#User_ID,
#Status_ID,
#RecievedDate,
#IGRemarks,
#PsoRemarks,
#FinalDecision,
#AgainstDist_ID,
#HomePS_ID,
#AgainstPS_ID,
#Name ,
#DesigID,
#ForwardedBy,
#SMS_ID
)
Set #result = ##ROWCOUNT
Set #ID = IDENT_CURRENT('ComplaintID') --SCOPE_IDENTITY()
Select #ID
End Try
Begin Catch
Set #result=0
End Catch
END
I want to get a last inserted id from particular table such that complaintID from complaints table but it doesn't return any but null. Help !
According to msdn the IDENT_CURRENT function will return null if the calling user does not have enough permissions on this object.
Another possibility is that your object name is wrong, i see you're doing your insert with the dbo prefix. Maybe that will help.
how do i set a column value to null if the user don't select value or set the new value when the user select value
create procedure update2
#SSN int,
#Employee_FirstName varchar(50),
#Employee_lastName varchar(50),
#gender_ID int,
#Department_ID int,
#location_ID int,
#salary decimal(18, 3)
as
Update Employee set Employee_FirstName= #Employee_FirstName,
Employee_lastName=#Employee_lastName,gender=#gender_ID,Department_ID = #Department_ID,
location_ID=#location_ID or location_ID is null , salary=#salary
where SSN = #SSN
You can declare #location_ID as null
CREATE PROCEDURE update2
#SSN INT ,
#Employee_FirstName VARCHAR(50) ,
#Employee_lastName VARCHAR(50) ,
#gender_ID INT ,
#Department_ID INT ,
#location_ID INT = NULL ,
#salary DECIMAL(18, 3)
AS
UPDATE Employee
SET Employee_FirstName = #Employee_FirstName ,
Employee_lastName = #Employee_lastName ,
gender = #gender_ID ,
Department_ID = #Department_ID ,
location_ID = #location_ID ,
salary = #salary
WHERE SSN = #SSN
Try this one, If I correctly understood your question -
CREATE PROCEDURE dbo.update2
#SSN INT,
#Employee_FirstName VARCHAR(50),
#Employee_lastName VARCHAR(50),
#gender_ID INT,
#Department_ID INT,
#location_ID INT,
#salary DECIMAL(18, 3)
AS BEGIN
UPDATE dbo.Employee
SET
Employee_FirstName = #Employee_FirstName
, Employee_lastName = #Employee_lastName
, gender = #gender_ID
, Department_ID = #Department_ID
, location_ID = ISNULL(location_ID, #location_ID) --<-- ??
, salary = #salary
WHERE SSN = #SSN
END
#location_ID INT = NULL -- specify NULL like this wherever you need
But you have to remove any relations(foreign key) with this particular column otherwise you will get conflict occur error at the time of updation
Thanks
Arun Antony