SQL Server: help with a simple stored procedure? - sql

Question

I'm trying to create a simple stored procedure which I can use to write data to a log table. I'm a noob in stored procedures, so what I'm missing here? I get an error saying:
Msg 201, Level 16, State 4, Procedure toLog, Line 0
Procedure or function 'toLog' expects parameter '#messageTime', which was not supplied.
How to modify this code to get this work?
USE <database>
GO
IF EXISTS(SELECT TABLE_NAME FROM INFORMATION_SCHEMA.TABLES
WHERE TABLE_NAME = 'logTable')
DROP TABLE dbo.logTable
GO
CREATE TABLE dbo.logTable (
messageTime DATETIME NULL,
etlJobName NVARCHAR(40) NULL,
whereTo VARCHAR(10) NOT NULL,
messag VARCHAR(255) NULL
)
/*************** procedure ************/
--DROP PROC dbo.toLog
CREATE PROCEDURE dbo.toLog
#messageTime DATETIME,
#etlJobName NVARCHAR(60) = 'unknown',
#whereTo NVARCHAR(20) = 'print',
#messag NVARCHAR(255) = 'empty'
AS
BEGIN
SET #messageTime = GETDATE()
IF #whereTo = 'log' OR #whereTo = 'logandprint'
INSERT INTO logTable(messageTime, etlJobName, whereTo, messag)
VALUES (#messageTime, #etlJobName, #whereTo, #messag)
IF #whereTo = 'print' OR #whereTo = 'logandprint'
PRINT CONVERT(VARCHAR, GETDATE(), 113) + ', ' + #etlJobName + ', ' + #whereTo + ', ' + ', ' + #messag
END
GO
--execution
EXEC dbo.toLog #whereTo = 'log'

Answer 1

It's because your toLog sproc is expecting you to supply the #messageTime parameter, which you haven't done, and it doesn't have a default value like the other parameters.
As you set the #messageTime always to GETDATE() inside the sproc, it looks like you just want to scrap that parameter:
CREATE PROCEDURE dbo.toLog
#etlJobName NVARCHAR(60) = 'unknown',
#whereTo NVARCHAR(20) = 'print',
#messag NVARCHAR(255) = 'empty'
AS
BEGIN
IF #whereTo = 'log' OR #whereTo = 'logandprint'
INSERT INTO logTable(messageTime, etlJobName, whereTo, messag)
VALUES (GETDATE(), #etlJobName, #whereTo, #messag)
IF #whereTo = 'print' OR #whereTo = 'logandprint'
PRINT CONVERT(VARCHAR, GETDATE(), 113) + ', ' + #etlJobName + ', ' + #whereTo + ', ' + ', ' + #messag
END
Or, if you do want to be able to pass in a datetime yourself:
CREATE PROCEDURE dbo.toLog
#messageTime DATETIME = null,
#etlJobName NVARCHAR(60) = 'unknown',
#whereTo NVARCHAR(20) = 'print',
#messag NVARCHAR(255) = 'empty'
AS
BEGIN
IF (#messagetime IS NULL) SET #messagetime = GETDATE()
IF #whereTo = 'log' OR #whereTo = 'logandprint'
INSERT INTO logTable(messageTime, etlJobName, whereTo, messag)
VALUES (#messageTime, #etlJobName, #whereTo, #messag)
IF #whereTo = 'print' OR #whereTo = 'logandprint'
PRINT CONVERT(VARCHAR, #MessageTime, 113) + ', ' + #etlJobName + ', ' + #whereTo + ', ' + ', ' + #messag
END

Answer 2

When You are creating the stored procedure with parameters, At any cause we need to pass the parameter values, when executing stored procedure.
Example 1:
EXEC dbo.toLog '','','',''
In the above line when you are executing the stored procedure , it will not thrown any errors. because passed the Parameters values are a NULL.
Example 2:
EXEC dbo.toLog '','','log',''
In the above line when you are executing the stored procedure , it will not thrown any errors, data will be Logged in your table. Based on the Stored procedure inside script logic