How to add another discount to subtotal in Quotation Order? - odoo

Question

There is a subtotal (price_subtotal) field in Quotation Order Line.
I have added a new field extra_discount.
I have tried this code but to no avail.
#api.depends('product_uom_qty', 'price_unit', 'extra_discount')
def compute_all(self):
for record in self:
record.price_subtotal = (record.product_uom_qty * record.price_unit) - record.extra_discount
It does nothing to the subtotal.
So, how do I make this happen?

Answer 1

I would try to override the computation method behind the field sale.order.line.price_subtotal.
But i'm not sure if api.depends() extensions (adding one more recomputation trigger field) are working as expected.
But it should look something like that:
class SaleOrderLine(models.Model):
_inherit = "sale.order.line"
extra_discount = fields.Float()
#api.depends('product_uom_qty', 'discount', 'price_unit',
'tax_id', 'extra_discount')
def _compute_amount(self):
"""
Compute the amounts of the SO line.
Fully overridden to add field extra_discount to the
formula and triggers.
"""
for line in self:
price = line.price_unit * (1 - (line.discount or 0.0) / 100.0)
# new: substract extra_discount
price -= line.extra_discount
taxes = line.tax_id.compute_all(price, line.order_id.currency_id, line.product_uom_qty, product=line.product_id, partner=line.order_id.partner_shipping_id)
line.update({
'price_tax': sum(t.get('amount', 0.0) for t in taxes.get('taxes', [])),
'price_total': taxes['total_included'],
'price_subtotal': taxes['total_excluded'],
})
if self.env.context.get('import_file', False) and not self.env.user.user_has_groups('account.group_account_manager'):
line.tax_id.invalidate_cache(['invoice_repartition_line_ids'], [line.tax_id.id])