Getting data from two tables not working SQL - sql

Question

I am trying to get data from two tables based on a condition. Both tables has the same condition just the content change. B contains client data and A contain product data
I am using this this code for stored procedure
ALTER PROCEDURE [dbo].[printfatura]
#idfatura int
AS
SELECT DISTINCT *
FROM tbl_faturimi b, tblfaturimi_details a
WHERE b.ID_FATURES = #idfatura
AND a.NR_FATURES = #idfatura
If I choose the ID =2 then then I should take the result of 3 rows as much as the table has , but instead I am getting 6 row. Data are repeated or duplicate. In tables there is not duplicate or repeated data, but during the select query process I get repeated data.
What should I change in this code to make it work?
Thanks to everyone
The photos of data :https://www.sendspace.com/file/fk6c1u

Answer 1

Try this
ALTER PROCEDURE [dbo].[printfatura]
#idfatura int
AS
SELECT DISTINCT *
FROM tbl_faturimi inner join tblfaturimi_details a
ON b.ID_FATURES=a.NR_FATURES
WHERE b.ID_FATURES = #idfatura
AND a.NR_FATURES = #idfatura
OR
ALTER PROCEDURE [dbo].[printfatura]
#idfatura int
AS
SELECT DISTINCT *
FROM tbl_faturimi b, tblfaturimi_details a
WHERE b.ID_FATURES = #idfatura
AND a.NR_FATURES = #idfatura
AND b.ID_FATURES=a.NR_FATURES
As per the syntax When we try to join two table we have to write a ON clause which contains the matching columns of both tables.

Answer 2

Use inner join and group by clause.
SELECT A.*, B.*
FROM tbl_faturimi A
INNER JOIN tblfaturimi_details B
ON A.FEATURES = B.FEATURES
GROUP BY A.*, B.*;
Hope this helps. :)
ALTER PROCEDURE [dbo].[printfatura]
#idfatura int
AS
BEGIN
SELECT A.*, B.*
FROM tbl_faturimi A
INNER JOIN tblfaturimi_details B
ON A.fk_ID = B.pk_ID
GROUP BY A.SomeColumn
WHERE A.fk_ID = #idfatura
END;