Okay I am confused…But that’s me easily confused.
I have a table. tblPartDrawing.
This table has three columns being PartDrawingID, Part and PartDrawing(Path).
Column Part is linked to tlkupPart. tlkupPart has PartID, PartNumber, PartDescription and PartThread in it. The link is on PartID in the table structure.
I have created a look up from tblPartDrawing.Part to tlkupPart.PartID with the following SQL code:
SELECT tlkupPart.PartID, [PartNumber] & " " & [PartDescription] AS Expr1,tlkupPart.PartNumber
FROM tlkupPart
ORDER BY tlkupPart.PartNumber;
As I read this, and perhaps I am missing something here this means PartID is the stored value in the Part column of tblPartDrawing.Part
However when I ask SQL to produce the following:
SELECT tblPartDrawing.PartDrawingID, tblPartDrawing.Part, tblPartDrawing.Drawing, tlkupPart.PartNumber, tlkupPart.PartDescription, tlkupPart.PartThread
FROM tblPartDrawing INNER JOIN tlkupPart ON tblPartDrawing.Part = tlkupPart.PartID;
It is throwing a Type Mismatch error. Clearly I am missing something, but I cant see what. Anyone else see the issue here?
If Part Number is a Short Text field (as it contains P), then PartID should be a text field, so you can join both fields and not get a "Type Mismatch" error.
Related
I'm using a docmd to open a report in ms access.
This command works as expected:
Docmd.OpenReport "rptCustomerProject", acViewReport, , "ProjectStatusID IN ([TempVars]![StatusActive], [TempVars]![StatusCompleted], [TempVars]![StatusPending]"
This command also works as expected:
Docmd.OpenReport "rptCustomerProject", acViewReport, , "CompanyOrgID = " & cboCompany
My problem occurs when I try and combine the two where clauses into one. I get a
Run-time error '13': Type mismatch.
I've tried various formatting but can't figure it out.
Docmd.OpenReport "rptCustomerProject", acViewReport, , "CompanyOrgID = " & cboCompany AND "ProjectStatusID IN ([TempVars]![StatusActive], [TempVars]![StatusCompleted], [TempVars]![StatusPending]"
Thanks in advance.
I made the changes and the Type mismatch error disappeared, however the ProjectStatusID no longer works.
I originally included the Where clause in the reports record source, but it said it was too complicated to analyze, so I redid the Select statement in my record source and put the Where clause in the form that calls the report. Different buttons on the form have different Where clauses. This is the only one I can't get to work.
My Reports record source is:
SELECT *
FROM (SELECT tblCompanyOrg.CompanyOrgID, tblCompanyOrg.CompanyOrg, tblCustomer.CustomerID, tblCustomer.CustPhone, tblCustomer.CustEmail, [CustFName] & " " & [CustLName] AS FullName FROM tblCompanyOrg INNER JOIN tblCustomer ON tblCompanyOrg.CompanyOrgID = tblCustomer.CompanyOrgID) AS q1 INNER JOIN (SELECT tbl2Project.ProjectID, tbl2Project.CustomerProjectID, tbl2Project.CustomerID, tbl2Project.ProjectStatusID FROM tbl2Project) AS q2 ON q1.CustomerID = q2.CustomerID;
After several days of troubleshooting I have found the issue. My TempVars are either a numeric value or a null. When evaluating the where clause with just the ProjectStatusID IN (TempVars list) everything works fine. When I add an additional stipulation to the Where clause I get a Run-Time error ‘3071’ This expression is too complex to be evaluated. Setting my TempVars that are Null to 0 solves the problem. My ProjectStatusID field is an autonumbered field and doesn’t contain a value of 0. Another solution I found was to build a string variable and only assign TempVars that are not Null to it. As far as the original question was asked, braX did provide the solution. Thanks to all.
I'm trying to send a email with multiple data from an SQL statement but I can't get the result of the SQL statement to be saved in the variable.
str = "SELECT Test.*,TestTopicScore.[Easy Question Score],TestTopicScore.[Medium Question Score],TestTopicScore.[Hard Question Score] from Test INNER JOIN TestTopicScore on Test.TestID = TestTopicScore.TestID ORDER BY Test.Score DESC"
mycommand = New OleDbCommand(str, myconnection)
myReader = mycommand.ExecuteReader
myReader.Read()
emailcontents = myReader("emailcontents")
The connection with the access database is fine and the data is read but i just cant get it to save in a variable.
The error I get:
An unhandled exception of type 'System.IndexOutOfRangeException' occurred in System.Data.dll
Additional information: emailcontents
Let's look at your query first, I've formatted it a bit to make it easier to see what's going on:
SELECT Test.*
,TestTopicScore.[Easy Question Score]
,TestTopicScore.[Medium Question Score]
,TestTopicScore.[Hard Question Score]
FROM Test
INNER JOIN TestTopicScore
ON Test.TestID = TestTopicScore.TestID
ORDER BY Test.Score DESC
What that is doing is selecting several different fields, not one value. Your code emailcontents = myReader("emailcontents") attempts to read one field which is named "emailcontents". Unfortunately, there is no such named field.
It is worse than that: you don't even know how many fields Test.* is going to return.
So, start by enumerating every field which you want from Test.
Then, you appear to want just one string as the result, so you will need to concatenate the fields as strings instead of returning them separately.
In Access, the operator to join strings together is &, and it should convert numeric values into strings for you, thus:
SELECT Test.SomeField & Chr(13) & Chr(10)
& Test.SomeOtherField
& Test.AnotherField
& TestTopicScore.[Easy Question Score]
& TestTopicScore.[Medium Question Score]
& TestTopicScore.[Hard Question Score]
AS [emailcontents]
FROM Test
INNER JOIN TestTopicScore
ON Test.TestID = TestTopicScore.TestID
ORDER BY Test.Score DESC
Notice how I put & Chr(13) & Chr(10) between Test.SomeField and Test.SomeOtherField: that puts in a new line between the two. You might want to do it in between all the fields.
Also, I gave a name to the concatenated data with AS.
Now we're getting into really messy stuff by having to put the formatting of the output into the database. You don't want to do that. Let me emphasise this so it stands out: A better way is to read all the fields individually in your VB.NET code and format them into a string there.
ETA: Not only all that, but it looks like you might return more than one set of results (from seeing the ORDER BY), in which case you will have to read all the results in a loop.
I have this query:
Select
'<ALL>' as name,
'<ALL>' as pid,
'<ALL>' as type
union all
Select distinct
instructor.name as name,
instructor.Pid as pid,
instructor_type as type
From sisinfo.dbo.SISCRSI instructor
inner join section_info as section
on section.sctn_id_code = instructor.sctn_id_code
Where section.sctn_term_code in (#Terms)
and section.subj_code in (#Subject)
order by name
When I run it in SSMS, it completes in pretty close to zero time. It also runs fast in the SSRS query designer when I feed it some values. But when I preview the report, the query takes at least two minutes to run. I'm not sure what is going on here, I've never had this kind of a problem with SSRS before.
As discussed in the comments, let's get rid of the parameters to see if your query is getting affected by parameter sniffing.
To do this we build the SQL statement from scratch. Most things in SSRS can be expressions including the SQL query so you can build it as a string. With the parameters, we'll convert them to a comma delimited list using JOIN.
So for your SQL statement, go into the Dataset Properties dialogue (not the query editor) and press the fx expression editor button to edit the query expression as text and make it be an expression as per below:
="Select '<ALL>' as name, '<ALL>' as pid, '<ALL>' as type "
&"union all "
&"Select distinct instructor.name as name, instructor.Pid as pid, instructor_type as type "
&"From sisinfo.dbo.SISCRSI instructor "
&"inner join section_info as section on section.sctn_id_code = instructor.sctn_id_code "
&"Where section.sctn_term_code in (" & Join(Parameters!Terms.Value, ",") & ") "
&"and section.subj_code in (" & Join(Parameters!Subject.Value, ",") & ") "
&"order by name "
What we have done here is turn the SQL expression into a string where we supply the multivalue parameters as strings rather than parameters, thereby eliminating parameter sniffing as a cause of a slow running query.
If your query is slow after this, you know it isn't parameter sniffing that is the problem but at least you will have dismissed it as a cause.
There's a couple of options I tried when I came across the same thing.
First was to change the parameters for variables in the stored procedure, and then use those new variables in your query.
Declare #TermsNew DataType = #Terms
Declare #SubjectNew DataType = #Subject
Select '<ALL>' as name, '<ALL>' as pid, '<ALL>' as type
union all
Select distinct instructor.name as name, instructor.Pid as pid, instructor_type as type
From sisinfo.dbo.SISCRSI instructor
inner join section_info as section on section.sctn_id_code = instructor.sctn_id_code
Where section.sctn_term_code in (#TermsNew) and section.subj_code in (#SubjectNew)
order by name
Another option that has already been suggested here is to add
Option(Recompile);
at the end of your query to recompile the execution plan.
The thing that worked for me though having tried the above... If you're pulling big result sets make sure that in the tablix properties that it is not set to "Keep results on one page if possible". I turned that off and my report went from 70 seconds to 7.
Actually, it turns out that this query was not the one bogging down, it was another one that was running at the same time (I think SSRS can run multiple queries at once). I thought it was the posted one as it was populating a field. Thanks for all the suggestions, I will probably wind up using them in the future.
This sounds like parameter sniffing to me - I see this all the time when the SELECT is at all complex. I would add the OPTION (RECOMPILE) hint to the end of your SQL.
I have a db in Access and I'm trying to get a textbox to run my query and pass an other bounded textbox's value in as the criteria in DLookUp. I have the query running in design view and when I enter the criteria directly it returns the correct results. When I open the report it gives me the sum of all the possible rows. In other words it doesn't filter the rows.
I haven't used Access in about twelve years, thankfully, and everything I've done up to this point has been tutorial/example patchwork, but here it is...
SQL Query:
SELECT Sum(IIf(Attended=-1,1,0)) AS attendance
FROM Students_Classes_Attendance
WHERE (((CStr([Students_Classes_Attendance].[Class_Id]))=[classId]));
DLookUp as Control Source:
=DLookUp("[Total Attendance by Class]![attendance]",
"[Total Attendance by Class]",
"[Class_Id] =" & [Class_Id])
I'm lost at the moment. I'm guessing that the value isn't there before the query fires and since the criteria is an optional parameter that it's being passed null, but I would hope you'd get an error from that. Not that #Error is very meaningful anyway.
Does anyone know for certain the problem and the best way to correct it? Thanks.
Edit:
I did the changes recommended in the answer so now my DLookUp looks like...
=DLookUp("[attendance]",
"[Total Attendance by Class]",
"[Class_Id] =" & [Class_Id])
...still returns the total for all rows. Removing the criteria completely makes no difference either, which returns me to thinking it has something to do with the bound textbox not having a value.
DLookup uses the following syntax:
Syntax for numerical values:
DLookup("FieldName" , "TableName" , "Criteria = n")
Syntax for strings: (note the single apostrophe before and after the string value)
DLookup("FieldName" , "TableName" , "Criteria= 'string'")
Syntax for dates: (note the # before and after the date value)
DLookup("FieldName" , "TableName" , "Criteria= #date#")
I believe you just need to remove the table name from the first parameter. Try this:
=DLookUp("[attendance]", "[Total Attendance by Class]", "[Class_Id] = " & [Class_Id])
Keep in mind that if Class_Id is a Text Field, you need to surround it by single quotes:
=DLookUp("[attendance]", "[Total Attendance by Class]", "[Class_Id] = '" & [Class_Id] & "'")
I'll try and break down my problem as best I can and explain what I'm trying to achieve. Firstly, I have three tables:
**RFI** (stands for Request For Information)-
Fields: rfi_id, Customer_id .....
**RFI_project** -
Fields: rfipro_id, project_id, rfi_id *"....." represents other unnecessary fields*
**Customer** -
Fields: Customer_id, company .....
I have an access form with two comboboxes. On the first combobox I select the name of a project at which point the second textbox changes to show those *rfi_id*'s where there is a match with the project name selected.
Now what I'm trying to do is this - When I select an *rfi_id* in the second combobox I want it to display in a textbox on my form the company where there the *rfi_id* value matches the value in the combobox. It's a bit tricky due to the way the tables are joined...here is what I'm essentially trying to display in the textbox field in SQL terms:
SELECT Customer.company, RFI.Customer_id
FROM Customer, RFI
WHERE (((Customer.Customer_id)=[RFI].[Customer_id]) AND ((RFI.rfi_id)=[Forms]![Request for Info Form]![Combo90]))
ORDER BY Customer.company;
In order to do this I have tried the following to no avail. In the after update event of my second combobox I have inserted the following:
companyTB = DLookup("company", "Customer", "Customer_id =" & DLookup("Customer_id", "RFI" And "rfi_id =" & [Forms]![Request for Info Form]![cmbRFI]))
When I change the combobox value I get the error Run-time error '13': Type mismatch. I've tried searching for what I've done wrong but this is a very broad error apparently and I can't find anything similar (or that I understand). I also tried this instead -
companyTB = DLookup("company", "Customer", "Customer_id =" & DLookup("Customer_id", "RFI", "rfi_id =" & cmbRFI))
which gives me the following error - Run-time error '3075': Syntax error(missing operator)in query expression. Anyway, would anybody be kind enough to give me a breakdown of what I need to do to achieve this, or what I'm doing wrong (or maybe a better way to do it?). Forgive me for being to seemingly stupid at this, I've only just begun working with access more in depth in the last 3 weeks or so. Thank you.
Your first DLookUp has incorrect syntax:
companyTB = DLookup("company", "Customer", "Customer_id ="
& DLookup("Customer_id", "RFI" And "rfi_id ="
& [Forms]![Request for Info Form]![cmbRFI]))
I have broken it into three lines to make this easier to see. The second line has And between "RFI" and "rfi_id" when it should have a comma.
companyTB = DLookup("company", "Customer", "Customer_id ="
& DLookup("Customer_id", "RFI", "rfi_id =" & cmbRFI))
The error you are getting on your second combo seems likely to be due to the result returned by cmbRFI. You can check this by filling in an actual rfi_id, rather than the reference to the combo and by setting a text box equal to cmbRFI and see what it is returning. Combo can be difficult because the displayed column and the bound column can be different.
It can be convenient to set up your combobox with several columns, as shown in your query, so the rowsource might be:
SELECT rfi.ID, Customer.company, RFI.Customer_id
FROM Customer
INNER JOIN RFI
ON Customer.Customer_id=RFI.Customer_id
ORDER BY Customer.company;
(or the three tables, joined, if necessary)
Then
Column count = 3
Column widths = 2cm;0;0
Bound column = 1
You can now refer to the second column in your textbox:
= cmbRFI.Column(1)
Columns are numbered from zero.
It is always worth reading up on sql before working with Access:
Fundamental Microsoft Jet SQL for Access 2000
Intermediate Microsoft Jet SQL for Access 2000
Advanced Microsoft Jet SQL for Access 2000
Your last Dlookup statement seems absolutely fine so I'm a little confused as to why it isn't working, you may be able to get round the problem like this though:
Combox2_AfterUpdate (Or whatever the event is called)
Dim rs As Recordset
Set rs = Currentdb.OpenRecordset("SELECT C.Company, R.Customer_ID " & _
"FROM Customer As C, RFI As R " & _
"WHERE C.Customer_ID = R.Customer_ID " & _
"AND R.RFI_ID =" & [Forms]![Request for Info Form]![Combo90] & " " & _
"ORDER BY C.Company")
CompanyTB = rs!Company
rs.Close
Set rs = Nothing
End Sub