Excel VBA Programming : Code Needed to Be Modified [closed] - vba

Question

Closed. This question needs details or clarity. It is not currently accepting answers.
Want to improve this question? Add details and clarify the problem by editing this post.
Closed 7 years ago.
Improve this question
I have displayed YES if the Data of Column C>=0.05 and NO if it is not satisfied . Also , I have done same with Column D in the Excel. The program Code is Given.
Now , I want to Modify my program . I want to display all the Output in single display Box like in Qbasic Programming , C programming . Also, If My output is YES , Just I need to display YES and If it is NO , I need to Display corresponding values of A cell .
The Code is Given
Sub ArrayLoops1()
Dim arrCMarks()
Dim arrDMarks()
Dim i, j As Integer
a = 0
b = 0
'For Column C
arrCMarks = Range("C2:C1439").Value
For i = LBound(arrCMarks, 1) To UBound(arrCMarks, 1)
If arrCMarks(i, 1) >= 0.005 Then
a = a + 1
End If
Next i
If a = 0 Then
MsgBox (" YES ")
Else
MsgBox ("NO")
End If
' For Column D
arrDMarks = Range("D2:D1439").Value
For j = LBound(arrDMarks, 1) To UBound(arrDMarks, 1)
If arrDMarks(j, 1) >= 0.005 Then
b = b + 1
End If
Next j
If b = 0 Then
MsgBox ("YES")
Else
MsgBox ("NO")
End If
End Sub

Answer 1

To make sure I understood your problem correctly:
If at least one of the values in Column C is bigger than or equal 0.005, you want to display a MsgBox saying "Yes", if no value is bigger or equal one that says "No" and the same thing again for column D?
And now you want to combine that in a single MsgBox?
In that case, do the following:
Format your code to have a better overview
We can not stop iterating anymore because we need to find all values.
Construct a String out of multiple elements
Resulting Code:
Sub ArrayLoops1()
Dim i As Integer, j As Integer
Dim a As Boolean, b As Boolean
Dim MsgString As String
MsgString = "Column C: "
'For Column C
For i = 2 To 1439
If Range("C" & i).Value >= 0.005 Then
If a = False Then
a = True
MsgString = MsgString & "NO, values from coumn A are:" & vbCrLf
End If
'Add value from column A
MsgString = MsgString & Range("A" & i).Value & vbCrLf
'Can not stop iterating since we need to find all values
End If
Next i
If a = False Then
MsgString = MsgString & "YES" & vbCrLf
End If
MsgString = MsgString & "Column D: "
' For Column D
For j = 2 To 3
If Range("D" & i).Value >= 0.005 Then
If b = False Then
b = True
MsgString = MsgString & "NO, values from coumn A are:" & vbCrLf
End If
'Add value from column A
MsgString = MsgString & Range("A" & i).Value & vbCrLf
'Can not stop iterating since we need to find all values
End If
Next j
If b = False Then
MsgString = MsgString & "YES"
End If
'Display the message
MsgBox MsgString
End Sub
BTW, the line
Dim i, j As Integer
results in i beeing a Variant (not good) and only j beeing an Integer.
Better:
Dim i as Integer, j as Integer
Bye, vat
Edit: If result is No, the corresponding value from column A is displayed (see comments below)
Edit 2: The code now does not stop iterating since we need to find all violating values. All corresponding values from column A are now shown.

Answer 2

Okay this will output a one msgbox:
Sub ArrayLoops1()
Dim arrCMarks()
Dim arrDMarks()
Dim i As Integer, j As Integer
Dim otptStr As String
'For Column C
arrCMarks = Range("C2:C1439").Value
For i = LBound(arrCMarks, 1) To UBound(arrCMarks, 1)
If arrCMarks(i, 1) >= 0.005 Then
otptStr = otptStr & "C: " & arrCMarks(i, 1) & " A" & i + 1 & ": " & Range("A" & i + 1).text & vbCrLf
End If
Next i
' For Column D
arrDMarks = Range("D2:D1439").Value
For j = LBound(arrDMarks, 1) To UBound(arrDMarks, 1)
If arrDMarks(j, 1) >= 0.005 Then
otptStr = otptStr & "D: " & arrDMarks(j, 1) & " A" & j + 1 & ": " & Range("A" & j + 1).text & vbCrLf
End If
Next j
MsgBox otptStr, vbOKOnly, "Both Columns"
End Sub
It will output any that are greater than the .005.

Answer 3

Unless you (or your users) are totally obsessed with popup dialogs, I would suggest to use a filter instead.
Such a filter would hide the majority of rows, leaving only the ones where column C or D, or both, satisfy some condition. The reason for a row to remain visible, will be reported in a separate column.
Sub FilterCD()
' Use column Z to report violating columns.
' In this example: C = the value in column C > 0.005
' D = the value in column D < 0.006
' CD = both
Range("Z2").Formula = "=CONCATENATE(IF(C2>0.005,""C"",""""), IF(D2<0.006,""D"",""""))"
Range("Z2:Z6").FillDown
' Hide rows where column Z is empty.
AutoFilterMode = False
Cells.AutoFilter Field:=26, Criteria1:="<>"
End Sub
Notes:
Adding more column in addition to C and D, is straightforward; CONCATENATE accepts any number of arguments.
You need a header row above your data to make this work. In other words, your data should start from row 2. Considering your original code, I guess that is already the case with you.
You can use Ctrl+Shift+L to undo the filter afterwards.
On big Excels sheets, I expect this code to be a lot faster than anything using For loops. But I must admit I did not profile it.
Please let me know if there is anything in my answer that does not meet your demands.