How to fire a trigger after the SPROC has completed execution? - sql

Question

I have written a trigger that sends email once a row INSERT is performed.
ALTER TRIGGER TR_SendMailOnDataRequest
ON DataRequest
AFTER INSERT
AS
BEGIN
SET NOCOUNT ON;
DECLARE
#DR_Id INT,
#DR_FullName VARCHAR(200),
#DR_Email VARCHAR(200),
#DR_Phone VARCHAR(20),
#UT_Name VARCHAR(50),
#DR_UserTypeOther VARCHAR(50) = NULL,
#D_Name VARCHAR(200),
#DR_RequestDate DATETIME,
#UF_LinkedFiles VARCHAR(MAX),
#DRN_Names VARCHAR(200),
#DR_Description VARCHAR(1200),
#DR_CreatedOn DATETIME,
#analystMailList VARCHAR(MAX),
#tableHtml NVARCHAR(MAX),
#downloadLink VARCHAR(MAX) = N'NONE'
SELECT #DR_Id = MAX(DR_Id) FROM dbo.DataRequest
SELECT
#DR_FullName = DR_FullName,
#DR_Email = DR_Email,
#DR_Phone = DR_Phone,
#UT_Name = UT_Name,
#DR_UserTypeOther = DR_UserTypeOther,
#D_Name = D_Name,
#DR_RequestDate = DR_RequestDate,
#UF_LinkedFiles = UF_LinkedFiles,
#DRN_Names = DRN_Names,
#DR_Description = DR_Description,
#DR_CreatedOn = DR_CreatedOn
FROM
dbo.FN_GetDataRequest(#DR_Id)
SELECT #analystMailList = dbo.FN_GetAnalystsMailList()
IF (LEN(#UF_LinkedFiles) > 0)
BEGIN
SET #downloadLink = N'Downloads'
END
SET #tableHTML =
N'<H1>Data Request</H1>' +
N'<UL>' +
N'<LI>Full Name: ' + #UF_LinkedFiles + N'</LI>' +
N'<LI>Email: ' + #DR_Email + N'</LI>' +
N'<LI>Phone: ' + CAST(#DR_Phone AS VARCHAR(20)) + N'</LI>' +
N'<LI>User Type: ' + #UT_Name + N'</LI>' +
N'<LI>User Type Other: ' + COALESCE(#DR_UserTypeOther, N'NONE') + N'</LI>' +
N'<LI>Reuest Date: ' + CONVERT(VARCHAR(20), #DR_RequestDate, 107) + N'</LI>' +
N'<LI>Downloads: ' + #downloadLink + N'</LI>' +
N'</UL>';
BEGIN
EXEC msdb.dbo.sp_send_dbmail
#profile_name = 'Example',
#recipients = 'John Doe<jdoe#example>',
--#recipients = #analystMailList,
#reply_to = #DR_Email,
#subject = 'Email Test',
#body_format = 'HTML',
#body = #tableHtml
END
END
GO
The above trigger is fired when there is a ROW INSERT operation on table DataRequest. After the row insert operation, I take the IDENTITY element generated after the INSERT operation and use that as the foreign key, and INSERT other values in a different table. Finally, I use the values from both the tables and create an email to be sent.
I wasn't getting the values from the other tables (e.g. #UF_LinkedFiles), so I realized that the TRIGGER is being fired just after the INSERT in FIRST table but before the INSERT in the SECOND table, thus no values available when SENDING EMAIL.
So how do I make sure that TRIGGER is fired only after the SPROC that does all the INSERT activities in multiple tables has completed the transaction.
Here is the table diagram -

Answer 1

Instead of using a trigger, I have included the EMAIL SENDING code in the SPROC where rows are being inserted.

Answer 2

Not sure if that is your case because you don't explain how is the behavior between the tables. But i had an scenario where i try to execute a SELECT during a series of insert and i couldn't find the row because the transaction wasn't finish yet.
What i did was create an additional table
tblProgress
id integer,
fieldA integer,
fieldB integer,
fieldC integer
So if you have 3 tables TableA, TableB and TableC each table will have one INSERT trigger and will do some job then access tblProgress.
TableA create a row
TableB and TableC update.
Then tblProgress will also have an AFTER UPDATE trigger, where you validate all 3 field have NOT NULL value
When you have all 3 values you can send the email.