SQL Oracle CREATE - unknown issue [closed] - sql

Question

Closed. This question does not meet Stack Overflow guidelines. It is not currently accepting answers.
This question appears to be off-topic because it lacks sufficient information to diagnose the problem. Describe your problem in more detail or include a minimal example in the question itself.
Closed 8 years ago.
Improve this question
After copping much abuse for the first time I asked this question I have calmed down and I am trying again and trying to be more specific.
I have done an assignment for Uni and this was the following prompt for one of the questions:
Write Create Table SQL statements for the relational schema that you have created
Place the text in the specified location in the file: ASS1_SQL.TXT
• All tables must have primary keys.
• All tables must have appropriate foreign key constraints.
• Each foreign key column must have identical column name, datatype and size of the primary key
that it refers to
• Add any NOT NULL constraints as dictated by the ERD
• The following columns data types and sizes must be used
suppid, stkid number(2)
suppname, stkname varchar2(30)
sellprice, purchaseprice number(6,2)
MY response to this was:
CREATE Table SUPPLIER(
suppid Number(2) NOT NULL,
suppname varchar2(30),
stkid Number(2) NOT NULL,
citycode Number(2) NOT NULL,
Primary Key (suppid),
Foreign Key (citycode) references CITY
)
CREATE Table STOCKITEM(
stkid Number(2) NOT NULL,
stkname varchar2(30) ,
sellprice Number(6,2) ,
purchaseprice Number(6,2) ,
suppid Number(2) ,
Primary Key (stkid) ,
whid Number(2) NOT NULL,
suppid Number(2) Foreign Key references SUPPLIER ,
whid Number(4) Foreign Key references WAREHOUSE
)
Before you say that I am pointing to tables that I haven't created (and mark my Question down), Please note that the WAREHOUSE and CITY tables have been created in the Database that I am using already.
This code works and creates the tables. However, I received 0 marks out of 10 with no explanation. The above code is slightly improved from initially as (I believe) I have fixed up the NOT NULL attributes.
Do my NOT NULL and FOREIGN KEY Constraints seem to have the right syntax?
The ERD can be found in a pdf at https://www.dropbox.com/sh/eohlj5h073kwp4u/Ot08kbdY7Q
Before voting this question down please consult me first and I can adjust it. I am new to this website so give me a chance please

Answer 1

Your foreign key syntax is incorrect.
Try this:
CONSTRAINT fk1 FOREIGN KEY (suppid)
REFERENCES STOCKITEM(suppid)
Change your syntax to resemble the above.
Also, your primary key should be declared before any of your variables.
Lastly, the Primary key syntax in oracle looks like this:
CONSTRAINT pk PRIMARY KEY (suppid));
Complete Code:
CREATE Table SUPPLIER(
suppid Number(2) NOT NULL,
suppname varchar2(30),
stkid Number(2) NOT NULL,
citycode Number(2) NOT NULL,
CONSTRAINT pk1 PRIMARY KEY (suppid),
CONSTRAINT fk1 FOREIGN KEY (citycode) References ParentTable(primary_key_column)
)
CREATE Table STOCKITEM(
stkid Number(2) NOT NULL,
stkname varchar2(30) ,
sellprice Number(6,2) ,
purchaseprice Number(6,2) ,
suppid Number(2) ,
whid Number(2) NOT NULL,
CONSTRAINT pk2 PRIMARY KEY (stkid),
CONSTRAINT fk2 FOREIGN KEY (suppid) References SUPPLIER(primary_key_column),
CONSTRAINT fk3 FOREIGN KEY (whid) References WAREHOUSE (primary_key_column)
)
Note:
You will, of course, need to change *primary_key_column* in the above example to your column name.

Answer 2

This is wrong:
Foreign Key (citycode) references CITY
because it doesn't reference a field in that table.
Also, these appear to be in the wrong order:
Primary Key (stkid) ,
whid Number(2) NOT NULL,
I always declare all my fields before my keys.