In MVC routing I have a problem.
In basic routing you can simply sort routes by writing them in order you wish. Like below :
routes.MapRoute(
"Default",
"{controller}/{action}/{id}",
new { controller = "Home", action = "Index", id = UrlParameter.Optional },
new [] {"SampleApp.UI.Web.Controllers"}
);
routes.MapRoute(
"CompanyRoute",
"{Company_url}/{action}/{id}",
new { controller = "Home", action = "Index", id = UrlParameter.Optional },
new[] { "SampleApp.UI.Web.Controllers" }
);
What about areas ?
In a spesific situation I need to register one of my areas before other one.
How can I sort area routes ?
From what I've figured out with the help of disassembler:
internal static void RegisterAllAreas(RouteCollection routes, IBuildManager buildManager, object state) {
List<Type> areaRegistrationTypes = TypeCacheUtil.GetFilteredTypesFromAssemblies(_typeCacheName, IsAreaRegistrationType, buildManager);
foreach (Type areaRegistrationType in areaRegistrationTypes) {
AreaRegistration registration = (AreaRegistration)Activator.CreateInstance(areaRegistrationType);
registration.CreateContextAndRegister(routes, state);
}
}
This is a method of an abstract class AreaRegistration where all your custom area registration classes are called. As you can see, there is no ordering. Deeper in the TypeCacheUtil.GetFilteredTypesFromAssemblies method no ordering either.
I can't see any way to use AreaRegistration class for orderable areas registration. The class hasn't any extension point which can be used for the purpose.
Related
I have two similar seo friendly routes going to different controllers/actions:
routes.MapRoute(
"Locations",
"{controller}/{locationId}/{location}",
new { controller = "Locations", action = "Location", location = UrlParameter.Optional },
new { locationId = #"\d+" }
);
routes.MapRoute(
"News",
"{controller}/{newsId}/{newsTitle}",
new { controller = "News", action = "NewsItem", newsTitle = UrlParameter.Optional },
new { newsId = #"\d+" }
);
The News route returns a 404 error and visa versa if I swap them. I tried adding a default controller to each - this did nothing. I then tried replacing {controller} with the actual name of the controller. This generated a
The matched route does not include a 'controller' route value, which
is required
error message.
Here's a link for each:
#Html.ActionLink(x.newsTitle, "NewsItem", "News", new { newsId = x.newsID, newsTitle = x.newsTitle.ToSeoUrl() },null)
<i class="fa fa-map-marker fa-li red"></i>My Place Name
I 'fixed it' by switching locationId and location querystring elements. OK so it works, but I feel this isn't the right solution. What if I have a third controller action with a similar querystring pair?
A final attempt was to make the route more generic:
routes.MapRoute(
"SEO",
"{controller}/{Id}/{Title}",
new { Title = UrlParameter.Optional },
new { Id = #"\d+" }
);
Bu then I can't pass the action and I'd be back to a less SEO friendly URL.
In the end I would like to end up with:
Locations/locationId/my-place-name
News/newsId/my-news-item
I'm relatively new to MVC and I'm sure I'm missing something fundamental (or just being dumb).
The problem is that a URL for both actions will match the first route you have added. For example, this URL:
http://yoursite.com/News/123/some-news-article
Will attempt to call the action Locations in your News controller, which obviously doesn't exist and gives you a 404 error.
You can get around this by specifying the path in the URL of the route instead of using {controller}. For example:
routes.MapRoute(
"Locations",
"Locations/{locationId}/{location}",
new { controller = "Locations", action = "Location", location = UrlParameter.Optional },
new { locationId = #"\d+" }
);
routes.MapRoute(
"News",
"News/{newsId}/{newsTitle}",
new { controller = "News", action = "NewsItem", newsTitle = UrlParameter.Optional },
new { newsId = #"\d+" }
);
I have managed to get my MVC project to present a list of news items in an SEO friendly manner:
/News/ - to present the list
/News/NewsItem/id/news-item-title - the individual news item
What I would really like is:
News/id/news-item-title
Exactly how Stackoverflow presents its questions.
However, I cant seem to get my head around how to do the routing to differentiate between two actions with the same controller action name (Index).
Any suggestions would be appreciated.
EDIT:
Here's my routes config:
routes.MapRoute(
"News",
"News/NewsItem/{newsId}/{newsTitle}",
new { controller = "News", action = "NewsItem", newsTitle = UrlParameter.Optional },
new { newsId = #"\d+" }
);
routes.MapRoute(
name: "Default",
url: "{controller}/{action}/{id}",
defaults: new { controller = "SkipHire", action = "Index", id = UrlParameter.Optional }
);
EDIT 2:
This is what I've amended everything to:
Route
routes.MapRoute(
"News",
"{controller}/{id}/{newsTitle}",
new { action = "NewsItem", newsTitle = UrlParameter.Optional }
);
Controller
public class NewsController : Controller
{
public ActionResult Index()
{
var q = _ctx.tblNews.OrderBy(x => x.newsCreateDate)
.Where(x => x.WebsiteID == 2).ToList();
return View(q);
}
public ActionResult NewsItem(int newsId, string newsTitle)
{
return View();
}
}
View - Index (Segment)
<table>
#foreach (var x in Model)
{
<tr>
<td>#Html.ActionLink(x.newsTitle, "NewsItem", new { newsId = x.newsID, newsTitle = x.newsTitle.ToSeoUrl() })
</td>
</tr>
}
</table>
Actionlink produces: News/NewsItem?newsId=3&newsTitle=my-news-item
I want: News/3/my-news-item
One way you could do this is to introduce an additional route into the route configuration
RouteConfig.cs:
routes.MapRoute(
name: "News_seo_friendly",
url: "{controller}/{id}/{seo}",
defaults: new { action = "NewsItem", seo = UrlParameter.Optional }
);
*Note the action value in this route. You will need a corresponding action method on that controller.
Also, since this route is more specific it goes above the existing, more generic route(s)
An Alt RouteConfig.cs that might be safer:
routes.MapRoute(
name: "News_seo_friendly",
url: "News/{id}/{seo}",
defaults: new { controller = "News", action = "NewsItem", seo = UrlParameter.Optional }
);
NewsController:
public ActionResult NewsItem(string id)
{
return View();
}
Another way you could do this is to make "News" its own Area within the project. This gives you the opportunity to isolate your routes, if your app is larger, and flexibility for your controller name(s).
Edited after feedback
Wanted to draw attention to the fact that the parameter name on the controller's NewsItem() method should match what is being declared in the route settings. In the above scenario, url: "{controller}/{id}/{seo}"
should match the parameter name in NewsItem(string id)...or vice-versa.
I need to routing a dynamic controller for example:
example.com/user1
example.com/user2
example.com/user3
example.com/usernnnnn
and too
example.com/about (not dynamic)
example.com/contact (not dynamic)
so you can try
routes.MapRoute(null,
"{Controller}/{id}",
new { controller = "User", action = "Index", id = UrlParameter.Optional },
new { id = #"user\d{1,9}*?" });
As a side note, I understand the whole ambiguous controller names problem and have used namespacing to get my routes working, so I don't think that is an issue here.
So far I have my project level controllers and then a User Area with the following registration:
public class UserAreaRegistration : AreaRegistration
{
public override string AreaName
{
get
{
return "User";
}
}
public override void RegisterArea(AreaRegistrationContext context)
{
context.MapRoute(
"UserHome",
"User/{id}",
new { action = "Index", controller = "Home", id = 0 },
new { controller = #"Home", id = #"\d+" }
);
context.MapRoute(
"UserDefault",
"User/{controller}/{action}/{id}",
new { action = "Index", id = UrlParameter.Optional }
);
}
}
The "UserHome" route is there so I can allow the route /User/5 vs. /User/Home/Index/5 which looks cleaner IMO.
Ideally I would like to use Url.RouteUrl("UserHome", new { id = 5 }), to generate the route elsewhere, but this always either comes back blank or gives me an exception saying it cannot find the route name, which is obviously there.
However when I use Url.RouteUrl("UserHome", new { controller = "Home", action = "Index", id = 5 }) it works no problem.
Why do I have to specify the action and controller when they have defaults already in the route mapping? What am I missing?
Everyone please see #ryanulit's answer below. This issue may be fixed for you with a newer framework version.
Not sure if there has been a hot fix, but the behavior now is a bit different.
Using your exact code and trying:
Url.RouteUrl("UserHome", new { id = 5 })
I now get:
/User/5?httproute=True
This still looks awkward, so I experimented with the route and added another default param:
context.MapRoute(
"UserHome",
"User/{id}",
new { action = "Index", controller = "Home", area = "User", id = 0,
httproute = true },
new { controller = #"Home", id = #"\d+" }
);
Now when I use
Url.RouteUrl("UserHome", new { id = 5 })
I get a nice url of
/User/5
disclaimer There could be unwanted side effects of httproute=true in the route declaration.
Also, the more verbose use:
#Url.RouteUrl("UserHome", new { controller = "Home", action = "Index", id = 5 })
still works as well.
Try this:
#Url.Action("Index", "Home", new { Area = "User" })
I can confirm that with .NET 4.5.1 and MVC 5.2.2 at the minimum, that this behavior has been fixed and now works as is with this same exact code using Url.RouteUrl("UserHome", new { id = 5 }).
It looks like this was a bug that has been fixed since the time of my post.
Adding this as the answer since although TSmith's solution would work, you no longer need to do that extra work now that there is a fix.
I'm trying to accomplish the following and receiving the "resource not found" error for #2. Assuming because the routing is not configured correctly.
Desired URLs:
1) domain.com/Customer
2) domain.com/Customer/1 *Does Not Work
3) domain.com/Customer/All
public ActionResult Index(int? id)
{
var viewModel = new CustomerViewModel();
if (!id.HasValue)
id = 1; // ToDo: Current Logged In Customer Id
viewModel.Load(id.Value);
return View(viewModel);
}
public ActionResult All()
{
return View(CustomerModel.All());
}
My Route Config has the default route setup and I've tried adding an additional route to no avail.
routes.MapRoute(
name: "Customer",
url: "{controller}/{action}/{id}",
defaults: new { controller = "Customer", action = "Index", id = UrlParameter.Optional }
);
I've excluded my attempts at setting up a new route since it doesn't work.
Your route would normalize out to domain.com/Customer/Index/1. When you have subsequent parts of the route, you can't eliminate an earlier component just because its value will be the default. In this case, it's looking for an action named "1" which it can't find.
Edit:
If your desired route is domain.com/Customer/ID, then you can add such a route to your route table:
routes.MapRoute(
name: "CustomerAll",
url: "Customer/All",
defaults: new { controller = "Customer", action = "All" }
);
routes.MapRoute(
name: "CustomerByID",
url: "Customer/{id}",
defaults: new { controller = "Customer", action = "Index" }
);
These more-specific routes should come before your default route.
try to add this route before the default one
routes.MapRoute(
name: "Customer",
url: "Customers/{id}",
defaults: new { controller = "Customer", action = "Index", id = UrlParameter.Optional }
);
and note that the url starts with Customers not Customer.
and your desired URL will be : domain.com/Customers/1 instead of domain.com/Customer/1